From patchwork Sat Aug 12 12:05:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 22115 Received: (qmail 118630 invoked by alias); 12 Aug 2017 12:05:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 118527 invoked by uid 89); 12 Aug 2017 12:05:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=22810 X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 206E661E4B Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer@redhat.com Date: Sat, 12 Aug 2017 14:05:20 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Remove internal_function attribute from string-to-float functions User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20170812120520.43C334027587E@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) These are called across DSO boundaries and should therefore use the standard calling convention. 2017-08-12 Florian Weimer * include/stdlib.h: (__strtof_nan, __strtod_nan, __strtold_nan) (__wcstof_nan, __wcstod_nan, __wcstold_nan): Remove internal_function. * stdlib/sttod_nan_main.c (STRTOD_NAN): Likewise. diff --git a/include/stdlib.h b/include/stdlib.h index 6fd868828b..c4a6e6f737 100644 --- a/include/stdlib.h +++ b/include/stdlib.h @@ -201,16 +201,12 @@ libc_hidden_proto (strtoll) libc_hidden_proto (strtoul) libc_hidden_proto (strtoull) -extern float __strtof_nan (const char *, char **, char) internal_function; -extern double __strtod_nan (const char *, char **, char) internal_function; -extern long double __strtold_nan (const char *, char **, char) - internal_function; -extern float __wcstof_nan (const wchar_t *, wchar_t **, wchar_t) - internal_function; -extern double __wcstod_nan (const wchar_t *, wchar_t **, wchar_t) - internal_function; -extern long double __wcstold_nan (const wchar_t *, wchar_t **, wchar_t) - internal_function; +extern float __strtof_nan (const char *, char **, char); +extern double __strtod_nan (const char *, char **, char); +extern long double __strtold_nan (const char *, char **, char); +extern float __wcstof_nan (const wchar_t *, wchar_t **, wchar_t); +extern double __wcstod_nan (const wchar_t *, wchar_t **, wchar_t); +extern long double __wcstold_nan (const wchar_t *, wchar_t **, wchar_t); libc_hidden_proto (__strtof_nan) libc_hidden_proto (__strtod_nan) @@ -228,10 +224,8 @@ extern __typeof (strtof128_l) __strtof128_l; libc_hidden_proto (__strtof128_l) libc_hidden_proto (strtof128) -extern _Float128 __strtof128_nan (const char *, char **, char) - internal_function; -extern _Float128 __wcstof128_nan (const wchar_t *, wchar_t **, wchar_t) - internal_function; +extern _Float128 __strtof128_nan (const char *, char **, char); +extern _Float128 __wcstof128_nan (const wchar_t *, wchar_t **, wchar_t); libc_hidden_proto (__strtof128_nan) libc_hidden_proto (__wcstof128_nan) diff --git a/stdlib/strtod_nan_main.c b/stdlib/strtod_nan_main.c index 96b788cb1e..9f7dd14ad2 100644 --- a/stdlib/strtod_nan_main.c +++ b/stdlib/strtod_nan_main.c @@ -29,7 +29,6 @@ return a default NAN. If ENDPTR is not NULL, set *ENDPTR to point to the character after the initial n-char-sequence. */ -internal_function FLOAT STRTOD_NAN (const STRING_TYPE *str, STRING_TYPE **endptr, STRING_TYPE endc) {