diff mbox

Add more tests for memchr

Message ID 20170524154520.GC14778@lucon.org
State New, archived
Headers

Commit Message

Lu, Hongjiu May 24, 2017, 3:45 p.m. UTC 
  This patch adds tests for len == 0 and tests for positions close to the
beginning, which are equivalent to positions close to the end for memchr.

Any comments?

H.J.
---
	* string/test-memrchr.c (test_main): Add tests for len == 0
	and tests for positions close to the beginning, which are
	equivalent to positions close to the end for memchr.
---
 string/test-memrchr.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Rafal Luzynski May 29, 2017, 8:36 a.m. UTC | #1 
If the subject line of this message is an actual commit comment
then shouldn't it say "memrchr" instead of "memchr"?

Otherwise I think I'm unable to tell for sure if the patch is
correct or not.

Regards,

Rafal
diff mbox

Patch

diff --git a/string/test-memrchr.c b/string/test-memrchr.c
index bfc9920..15483f5 100644
--- a/string/test-memrchr.c
+++ b/string/test-memrchr.c
@@ -151,15 +151,32 @@  test_main (void)
 
   for (i = 1; i < 8; ++i)
     {
+      /* Test len == 0.  */
+      do_test (i, i, 0, 0);
+      do_test (i, i, 0, 23);
+
       do_test (0, 16 << i, 2048, 23);
       do_test (i, 64, 256, 23);
       do_test (0, 16 << i, 2048, 0);
       do_test (i, 64, 256, 0);
+
+      do_test (0, i, 256, 23);
+      do_test (0, i, 256, 0);
+      do_test (i, i, 256, 23);
+      do_test (i, i, 256, 0);
+
     }
   for (i = 1; i < 32; ++i)
     {
       do_test (0, i, i + 1, 23);
       do_test (0, i, i + 1, 0);
+      do_test (i, i, i + 1, 23);
+      do_test (i, i, i + 1, 0);
+
+      do_test (0, 1, i + 1, 23);
+      do_test (0, 2, i + 1, 0);
+      do_test (i, 1, i + 1, 23);
+      do_test (i, 2, i + 1, 0);
     }
 
   do_random_tests ();