From patchwork Wed May 24 11:13:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 20557 Received: (qmail 38782 invoked by alias); 24 May 2017 11:13:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 38770 invoked by uid 89); 24 May 2017 11:13:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:format-, sk:format, HContent-Transfer-Encoding:8bit X-HELO: NAM01-BN3-obe.outbound.protection.outlook.com Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=caviumnetworks.com; From: Yury Norov To: libc-alpha@sourceware.org Cc: Yury Norov Subject: [PATCH] nss_nisplus/nisplus-alias.c: fix build warning on gcc7 Date: Wed, 24 May 2017 14:13:38 +0300 Message-Id: <20170524111338.3495-1-ynorov@caviumnetworks.com> MIME-Version: 1.0 X-ClientProxiedBy: VI1P194CA0002.EURP194.PROD.OUTLOOK.COM (10.175.178.12) To BN3PR0701MB1267.namprd07.prod.outlook.com (10.160.118.141) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR0701MB1267: X-MS-Office365-Filtering-Correlation-Id: ac8f37b3-3fdd-4fe6-8a74-08d4a295f57a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BN3PR0701MB1267; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 3:cvFyS15sPPiKjzSRiIx3t5gPhhwXmOwkWhtikCcUauMTtwqyPIyhrHe5cjanXRKB7n8QteCapywKaunP2fFwqfpsrwa1KExCOrttmEvpJUotXExF4c8V30m5W6D4CA+KlyzdCZgq0noW2y6okFyKTYGonodOVCQKxKWh86e35ftWbCZUWySpUgul5GZxWWc5wjnKpwzYYGPC3vKE/Oi7K8/yXGM4RaZ9SdJyB3KXrceASOQqSBuhwK4ChJ17eA/ISMv90rN2r6mLem51ARvIm+PCR3eaDY76+dTLtDWl16bztMWHidm6ZNZKFzhSYgBFphSInMIDS0o4k71716miVg==; 25:oG/3anl0bjqEQ6opcmOPaLH5XFi1xdS5c0xkxNBsc2uzqMwA/CY5+hWcDiu2ne6XYemrumPVH/bMSmgwvRC2tp/G1Z7shMivLE5HnZVjAawb4ZySS4joOIsQP8pttC4/xTr8Jei+A5kTaPvcNvTqGhBhfTjiHxaCHkjqqeZzdujKYD1o9CIeJHQamZNMW+i9dL5ODrHcG/V8mDwpJNVbfTzv0H6/TULTOt0Uvxb+uG+y7WC2u6wO5RE05wn5a0bzv7PC+q8mPQQJLghn+4AiiDMY1Jvrw/wISHWEYvHRkcA9wAo8e7hb0S98n4IXVcB7IQGQY/gzvDUm279iHa/OvfWswawag52aEV1x80KYnjP60PVK+cDGTsacA8lRf891XGCo64R6O4yNcH3O7KhwtUu58KDFq6X9nQWNnKGulsKHWowRKjgTQNqTw6AuyO6E2wmOp+OuDUpNsT1uYwtMMtY6bgurk8efHNq3FqPhWs8= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 31:ok4dfj7QEX+JDQtaodNjKwsdIl9EK1NQwON8TCjWkNWRuDeKh9Ifp6rDLo9rZHRpiutEpe3WeTGRTKN8cfT0+KowjYTptPzvQF1tBjAoZMdmTQcb/3XQ3SIFoqgUoDh6xJFNl5MW1dWUV69Bo//N22eUCqY3WyrawQ9WIhtqVFH52y2WVM5BCJIsFEg+CSxsT+5M1QayTRKtFYgIKI2IdyxpbtRNGJDUk1DEgfMwtw0=; 20:wDWtMQKCLhYSJULQMF/JPYtnAPVZAC/9t2c/ESFWB4FkkTOaU1Cxn+vR1U3zuywbZKtYFPJeuqh0k6cX4raq4ySFjEExSwAY7iYyhe1byg94GD0ezlwAWKV1H5netY75PMNIiqxOhYd15rYy06pXREuLigBPA3IjDunzeCo3zGEUNqw8P6gVXX0mdfpsduOSoudx17hX1ji+5EXNenml6AyV2V8xgpnXuJtoh145Wr7RFJ6VUXhtbcyhZlDu3SsZ4Cjt7dtnuzbx0nOKZdGyOX04MEM2Yq0CXYHeuu12a03NqudcNAX/C1fWdUkDF7DMQGrdEB+fUJ7VIoFn67NafzC3poCuklVI9za/TVTJ9pkp4ZwV0wm2GfK7S2AsEgDCCiAe9M760mDrPUvx+r609gzn1POSUPW1Y6Jbi+8IHfrP8Sq51Jh8olnQQ9qa9/XXxwzYhDFR0sJb3Ls4mlkdhB4Bl+w8qXyU2ZwcK6DJu83YyIQJsILujtG2Kdlz6bv/QQlE+hyjxdkXIAiA5X6ll3JKnlJVIKuR/g3IXyICoFi/w1gEaM2xNXgHlKjbAUIqd0C5oM3v7ZZxumGaiRd5ISLckVCJrX6XCoxeP1XuEBk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(6072148); SRVR:BN3PR0701MB1267; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1267; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 4:vPUdDjniDoR7E3UVVgLd2Ss+KFIQPuNpo9E+C5OKHWqSM8j6UB4pTS1n+kefSSkegUl/TZnmgfnAeSz71gpUwF/rM4RJS/9Uvi85bC3ypuMO29LPNRV6u+LKYdqGVclsCVmb8Hp7XLk6wcWu2dRsoixFSCpbczEm2+7hJHIk9R1mD53pg0O7nSwz+Q111KrTx9rNBIsjQCkqE/vdmsjGdmIxxEK0SSnoc6sGDaOv8c6pIvfLxZe6174k1RPrDBJr1wacyI0jkPjbpUy25NS+k2I7WABGudRk9yM6dFQE0R7Qgfi2Cg31p7PERPeyt7voXkPBxREbuhBLRyPQRyWjt6UyoLnlyPOlCj/Jj92pVpe8QGrq8qNt4IH6fqcwUzDZmcpJ8/J2a+loswuH4xJEIpuOLJuKtSBcHSSFjnJnPeO/z7pFNQ1Y3aNIboBoGvWR86wxffg0dWYI3B47pS0myGMiqbAjuFZO9BhjOhxdIh80/nHCk5Tl7wnzRXp0Tpudf35yn0/IIYgX37a95xh0zMyIssmmwqf9WfLjBsksD61cVwcqX2ma4fbFGy16VU9RfqwpHhWYpdE/qRi3ComedPUCTJSe+uDqsAqfJoKprejlsTR6ORx3kuTb8QeSURCn6pZxHYgrr0mKp1T5++k+3V1RXCa590WrIuc+CYcmFk5yWPs7izWFihOMmaqxGLeHgwJGup4XhytEnqCprnQgknqXZp0mdc+fMr4Wve+LxsplB2pGT7ADXTH1vdXBZWQ4hUuLvAMNR7sJu8eUvGnF3w== X-Forefront-PRVS: 031763BCAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39850400002)(39400400002)(39410400002)(39840400002)(39450400003)(51444003)(53754006)(52314003)(305945005)(2870700001)(42882006)(36756003)(7736002)(2906002)(478600001)(66066001)(47776003)(50226002)(2361001)(2351001)(5660300001)(81166006)(6916009)(33646002)(50986999)(6116002)(3846002)(6496005)(50466002)(110136004)(107886003)(38730400002)(6666003)(8676002)(72206003)(189998001)(76506005)(42186005)(1076002)(4326008)(6486002)(53936002)(23676002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1267; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjA3MDFNQjEyNjc7MjM6S0VFdjNmZWE2VW9hRVBWWWRRMHBTZ3Mr?= =?utf-8?B?WlFzZ3dKQTlJMnZPbVgvWTBlNURhSkg1M0pYeVlicGFvSlI4dnRGYStmcVpy?= =?utf-8?B?eWYyN05MSkdFVk54UWdjYVFzUnhSaW1sQm5PTDVhVzlwUWpvQ0E2dFQyUGlD?= =?utf-8?B?RmxkREN5UHY5a0ptU242VUdtUVR4eWJVRTY4OEZNajV3bGRQQ3FRWU8vM0F5?= =?utf-8?B?Z2hEWW5JWFBQVzdvRzlLQUhPeFU5dkRkZ2tGVEFFRTZPRzM5TFo5TW4yYmtu?= =?utf-8?B?b2FTUUFSemxXeGoxdUlOUTdSTlVOOUp2WEVCYkRLR3oxcXFlM0xPY2RmWDJl?= =?utf-8?B?dnRhRVNvYTVvRWRQYXo1UDFFck1acVZPSlBWaGE5alpuSVlRdWlOWkQ0dW5w?= =?utf-8?B?Z2EzYThuaXJUdkp5NTJCRlhYaStDRTBUR2JVek1OVldLNUwxcHhZbUl6OGMx?= =?utf-8?B?Q3hxaHpuL0kwVGF3U3hLTkc0Q1NZMWk2Vll5VDRPUXJjSFoxd29IUHpnUTZo?= =?utf-8?B?ajF1eWlsQmxxTDlVL1VRM1hscTB3am0vYUs1VTU0UmhKWmtONmZGdVlxaUtG?= =?utf-8?B?d1MyWmpFRzh3UjBBbFpsWUl6MmVZdFgrY0tSOVg5V29xT2txdW9MaHNiTTZj?= =?utf-8?B?STFCNjY5UWlGeDdNaG5rRHRjU2xFZGx5bC9FUlRFQ0g3Y00yTm5RRW80N3BF?= =?utf-8?B?SXFFUVFYalNCTlZmdC9GQ3ZxZEJxV3ErN2lveFBDYmxxS2xLK0ZnWjIzNWdD?= =?utf-8?B?QXpzL2VVZ2x4SEg3RTJxU1B0SHl3M3MzbVBUWGxLUmlyY0JzanhkNVlVZjNk?= =?utf-8?B?c2MxOUFIdXJwWDFUVUt3SUlldHNYRGlvblV3RmdhdkRDOTRSckMydnhSaU9K?= =?utf-8?B?SExSVlRpT1ovUTVyL09SaFVYazVhVGhsNEJ1OHdESmhtL2t2OUtPWFVPaFFh?= =?utf-8?B?SGJwazkxVTRhcmt2NXJuTC83a1VXVWRlMFlKVzNvcm5oZG1DTk5iTlYycFl2?= =?utf-8?B?QVpUWHJSWC9uQzJ0SzJyVVJJRGdRd1lxUUhmK2ticHdVZCtyTmk2UlJ4QitS?= =?utf-8?B?NW5IbXNweUFKUWcvaXNpR21MTEZQR2I1YlgrZEFnWjJya1dJNlRWeUdESE5q?= =?utf-8?B?dVM0NjNUb01LcmJvZURucE9pL05VVHhPemd5YzFjdHB5emY1SE1GdXMyeE55?= =?utf-8?B?ODNiVjFTTjMyZ1QrRmo4T2Yzc294a3VtNm85NjI4SXdEenVXeFFvUStMNHNE?= =?utf-8?B?dmV4L0ZMR2NVRDUxSmlZWnU2S0FQRXZ5TFVxakxLYnpVWHJ0MkQyYlZhTXVm?= =?utf-8?B?cTdjckVqTE55WTJnRkVVcktmY2pxVVpHSHNQRjVndEFYTDRLZFpYVmFKeGRz?= =?utf-8?B?a1FQaWVieWdSc2JQNmMzamJ0OXg3TXBiVVJLQ0xpeWUwOG1Kak9YdGhvV05I?= =?utf-8?B?L1hqMVVORUZQK3V5YWZVemlCYjdlTjdFeldKeFlaTUFTeXBESndQaTRLUFlz?= =?utf-8?B?S3RoM3BPZWdsNTBFYjRGOWxtMldvN1p6OGttVmxCSDdRSHp5YkRHZGl5QWMz?= =?utf-8?B?NlNad0Rha0JPQkxoMEtxTUJmZVI0eDFRQT09?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 6:hrKy+U8E5+j1Noa7HW4spQZUxX8O5pVDdejLY+k63EJhMbMfmEMfZ4/6Qbtv1Ou5kHE8Umq2kV7jIpdw5zvRHxvO9mxJy4ic1ac7t+ylrfD/0ws+c+6Yuxos8JG7JQ2yUKWkMkufcop11DteXn8ZNMjASKQKblx+bQqg1ErrBUvEyQwPbQ58+lHs1vByr2CHLf0gFA+IfiWMwdpUU6cdE8t7pGB5eNxkuSQgMGAKiHEwQyqMqG1hrQ9lDGwFslVNpuNeNDMcit6xpjAWXzhoI0Y9P3ufJfcbcntRRfOAXn4/UbVv1icqzfJeIpmCrnaWRz3wyzcRHADCWgEfQ88ZZ6m9g9pa5RUp0dScrEevcQfZLeHse40OUM7E6b7jt5AS+5ECpqGF1Q54I00pY+GNEunI/x+FT5qr+ywtCeyt/ojUSYgZxJHiu4I3Wlav5/JPl6KufaFwYYCbpeFlG8C/Cptu6mMr3nVcu3uPH8XWdNmYbBaPSEf8sAeP93QxTc1QXE2fjMHI6FqGKJGcF4tflQ==; 5:QuVLSbGQNkr/C52piEEgaRj2joGNpzrR2GEDqIblWArytlx7GuBhZdxDysB8PKVvWIUVY6YD/Ai7EEVe11+CwiinDTmvfrp07aNkr98+eNTyocJgqqpSaRds3kPadMNfvtABT7AaNN02iVrtdWGL1GO0XdKkqlkOtR/fNA+O8+Q=; 24:kqEisSSrAC+srOG5oCpKYaXyhBxxlD8/WpXrNGz0ufSlv4oGpaquXvCSRx3obZOCCk+AoOw0xHBTL4GgzmA9p2q1/Fw/csEiQEfm2X2/7N4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 7:BFjtvnoRon9sl4/fM1OxPynVmZTK/xxAjElAnqe2LDAP3qretrShjUOgUNp54ulUwN1GW92JgBL0jxO+rmfaVY3ZQek2aK9t7PyYtsbKNk8QOSyLiTcHFs+ad6qBsfCBYBxNNKsgWmXIrjxruDFzPKAYgKslTYGGAa/+Fc5vcQX9fmAMQOlgYTCVHBJJCbm2f35B9avT3TWdZ2TLsmy3nb4kUYNZW9m2ldvFPqCwm08oRT7q1f8NNSMjIPZGu9o6YTkgNN2QndpGiAuKFIVW1lRbq62rKTpqAeK7qLV4uurVU/HoFPpNUsTbng4SEPAIqUq637E9RJj4q3u8TW+6zQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2017 11:13:51.2783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1267 Hi all, gcc7 for arm64 warns about NULL pointer passed to strlen() and snprintf() in _nss_nisplus_getaliasbyname_r(). If Werror is enabled, it is treaded as error, and so breask build: nss_nisplus/nisplus-alias.c: In function ‘_nss_nisplus_getaliasbyname_r’: nss_nisplus/nisplus-alias.c:300:12: error: argument 1 null where non-null expected [-Werror=nonnull] char buf[strlen (name) + 9 + tablename_len]; ^~~~~~~~~~~~~ In file included from ../include/string.h:54:0, from nss_nisplus/nisplus-alias.c:23: ../string/string.h:394:15: note: in a call to function ‘strlen’ declared here extern size_t strlen (const char *__s) ^~~~~~ nss_nisplus/nisplus-alias.c:303:39: error: ‘%s’ directive argument is null [-Werror=format-truncation=] snprintf (buf, sizeof (buf), "[name=%s],%s", name, tablename_val); ^~ cc1: all warnings being treated as errors * nis/nss_nisplus/nisplus-alias.c: don't pass name variable known to be NULL to strlen() and snprintf() in _nss_nisplus_getaliasbyname_r() If the line "[name=],..." looks weird, I'll resend the patch, if someone will hint me how it should look. Anyway, I think that it currently should look like this. Signed-off-by: Yury Norov --- nis/nss_nisplus/nisplus-alias.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nis/nss_nisplus/nisplus-alias.c b/nis/nss_nisplus/nisplus-alias.c index 7f698b4e6d..509ace1f83 100644 --- a/nis/nss_nisplus/nisplus-alias.c +++ b/nis/nss_nisplus/nisplus-alias.c @@ -297,10 +297,10 @@ _nss_nisplus_getaliasbyname_r (const char *name, struct aliasent *alias, return NSS_STATUS_UNAVAIL; } - char buf[strlen (name) + 9 + tablename_len]; + char buf[tablename_len + 9]; int olderr = errno; - snprintf (buf, sizeof (buf), "[name=%s],%s", name, tablename_val); + snprintf (buf, sizeof (buf), "[name=],%s", tablename_val); nis_result *result = nis_list (buf, FOLLOW_PATH | FOLLOW_LINKS, NULL, NULL);