From patchwork Thu May 18 21:03:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lu, Hongjiu" X-Patchwork-Id: 20498 Received: (qmail 37470 invoked by alias); 18 May 2017 21:03:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 37456 invoked by uid 89); 18 May 2017 21:03:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, NO_DNS_FOR_FROM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=2.9.4 X-HELO: mga04.intel.com X-ExtLoop1: 1 Date: Thu, 18 May 2017 14:03:13 -0700 From: "H.J. Lu" To: GNU C Library Subject: [committed, PATCH] Correct comments in x86_64/multiarch/memcmp.S Message-ID: <20170518210313.GA23696@lucon.org> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.0 (2017-02-23) * sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct comments. --- ChangeLog | 5 +++++ sysdeps/x86_64/multiarch/memcmp.S | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 06ef578..5ebd3a0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-05-18 H.J. Lu + + * sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct + comments. + 2017-05-18 Siddhesh Poyarekar * elf/Makefile (tst-env-setuid-ENV): Reduce value of diff --git a/sysdeps/x86_64/multiarch/memcmp.S b/sysdeps/x86_64/multiarch/memcmp.S index 8262317..6129820 100644 --- a/sysdeps/x86_64/multiarch/memcmp.S +++ b/sysdeps/x86_64/multiarch/memcmp.S @@ -56,9 +56,9 @@ END(memcmp) # ifdef SHARED # undef libc_hidden_builtin_def -/* IFUNC doesn't work with the hidden functions in shared library since - they will be called without setting up EBX needed for PLT which is - used by IFUNC. */ +/* It doesn't make sense to send libc-internal memcmp calls through a PLT. + The speedup we get from using SSE4 instructions is likely eaten away + by the indirect call in the PLT. */ # define libc_hidden_builtin_def(name) \ .globl __GI_memcmp; __GI_memcmp = __memcmp_sse2 # endif