From patchwork Thu Mar 30 16:33:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 19774 Received: (qmail 61978 invoked by alias); 30 Mar 2017 16:33:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 61678 invoked by uid 89); 30 Mar 2017 16:33:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: bombadil.infradead.org From: Christoph Hellwig To: Linus Torvalds , Alexander Viro Cc: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, libc-alpha@sourceware.org Subject: [PATCH 2/2] fs: reject unknown open flags Date: Thu, 30 Mar 2017 18:33:27 +0200 Message-Id: <20170330163327.23920-3-hch@lst.de> In-Reply-To: <20170330163327.23920-1-hch@lst.de> References: <20170330163327.23920-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html This way userspace can probe for actually supported flags. Signed-off-by: Christoph Hellwig --- fs/open.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/open.c b/fs/open.c index 949cef29c3bb..9106ed7310f0 100644 --- a/fs/open.c +++ b/fs/open.c @@ -900,6 +900,9 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o int lookup_flags = 0; int acc_mode = ACC_MODE(flags); + if (flags & ~VALID_OPEN_FLAGS) + return -EINVAL; + if (flags & (O_CREAT | __O_TMPFILE)) op->mode = (mode & S_IALLUGO) | S_IFREG; else