From patchwork Sat Dec 31 08:03:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 18733 Received: (qmail 128795 invoked by alias); 31 Dec 2016 08:03:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 128667 invoked by uid 89); 31 Dec 2016 08:03:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=RELA, sk:elf_bac, Relocations, rela X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pg0-f65.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YEORmtwE5NVWdXW7uh94WXgnZaWS9kBgbSY4g/8tvkA=; b=PDupxn8vtJkg/SCkQyvb6fP2FIlCSQE7HhRBYAom4dMmamnzZviHmFBjalq024QcNv g9s2+u8BEFicdg1/ITgnAfn6UrGtpK0chxqOHUcvQjGA1Z/j0Ot+uYq4rX0NuXiwCW2p Rx+DLELWx3LT6qpZkT4jFvZUzSeP30A8r9R8l1/izBpleL5UA7iU11wcRgnkn2+po4wF qh5efuFy0gzk1NnDCEadjV7D114t6iV+o41suMezoXjVdB5HLnB99WMBRuA7v5BBKfec NCxhX9Oa8f92+1VhOYYRjwMMmI39cYy/8XyDcP4vEDm4dTAZxnR5z6RtbX059nvgTAUU JmTg== X-Gm-Message-State: AIkVDXJnBkYuLPQA6xazhqnrtDqqZs0C9FEnGMWvTxmDCid6uVlHELmpmP7CnPSZ0Hd1ag== X-Received: by 10.84.211.7 with SMTP id b7mr105344521pli.83.1483171397723; Sat, 31 Dec 2016 00:03:17 -0800 (PST) Date: Sat, 31 Dec 2016 18:33:12 +1030 From: Alan Modra To: Joseph Myers Cc: Mathias Payer , Florian Weimer , binutils@sourceware.org, libc-alpha@sourceware.org, Xinyang Ge , Trent Jaeger Subject: Re: Read-only data in ELF libraries may be remapped writable at runtime (upcoming NDSS'17 paper) Message-ID: <20161231080312.GH29355@bubble.grove.modra.org> References: <5bb116b9-2633-bb9d-bd93-edece2fc56ec@redhat.com> <20161223143554.GG2896@bubble.grove.modra.org> <1f4b9a13-3d00-9782-1190-23dc6eb0d804@redhat.com> <20161226082913.GD340@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) On Fri, Dec 30, 2016 at 03:11:01PM +0000, Joseph Myers wrote: > One of these changes appears to have broken building glibc for MIPS64 (n32 > ABI; others untested) with binutils master (not tested 2.28). Building Thanks for the notification. A silly omission on my part. * elfn32-mips.c (elf_backend_want_dynrelro): Define. diff --git a/bfd/elfn32-mips.c b/bfd/elfn32-mips.c index c7ca646..ef09a14 100644 --- a/bfd/elfn32-mips.c +++ b/bfd/elfn32-mips.c @@ -3687,6 +3687,7 @@ static const struct ecoff_debug_swap mips_elf32_ecoff_debug_swap = { #define elf_backend_ecoff_debug_swap &mips_elf32_ecoff_debug_swap #define elf_backend_got_header_size (4 * MIPS_RESERVED_GOTNO) +#define elf_backend_want_dynrelro 1 /* MIPS n32 ELF can use a mixture of REL and RELA, but some Relocations work better/work only in RELA, so we default to this. */