From patchwork Thu Jun 26 17:50:20 2014
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Siddhesh Poyarekar <siddhesh@redhat.com>
X-Patchwork-Id: 1771
Received: (qmail 5862 invoked by alias); 26 Jun 2014 17:49:22 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 5850 invoked by uid 89); 26 Jun 2014 17:49:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL, BAYES_00,
	SPF_HELO_PASS, SPF_PASS,
	T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Date: Thu, 26 Jun 2014 23:20:20 +0530
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix Wundef warning for DEBUG in mktime
Message-ID: <20140626175019.GY4477@spoyarek.pnq.redhat.com>
References: <20140626171842.GA12565@spoyarek.pnq.redhat.com>
	<20140626171935.320CA2C39BC@topped-with-meat.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20140626171935.320CA2C39BC@topped-with-meat.com>
User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16)

On Thu, Jun 26, 2014 at 10:19:35AM -0700, Roland McGrath wrote:
> How close are we to mktime being harmonized with gnulib already?

Not far at all; there's just one change that should bring us in sync
with gnulib.  Patch below with the right attribution.

> If we're already there, then please coordinate this change with them.

OK.

Siddhesh

2014-06-26  Paul Eggert  <eggert@cs.ucla.edu>

	* time/mktime.c (leapyear): Remove inline keyword.

diff --git a/time/mktime.c b/time/mktime.c
index a4a2d58..077f9c4 100644
--- a/time/mktime.c
+++ b/time/mktime.c
@@ -142,7 +142,7 @@ verify (twos_complement_arithmetic,
 verify (base_year_is_a_multiple_of_100, TM_YEAR_BASE % 100 == 0);
 
 /* Return 1 if YEAR + TM_YEAR_BASE is a leap year.  */
-static inline int
+static int
 leapyear (long_int year)
 {
   /* Don't add YEAR to TM_YEAR_BASE, as that might overflow.