From patchwork Tue Jun 24 11:42:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 1686 Received: (qmail 5050 invoked by alias); 24 Jun 2014 12:13:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 5037 invoked by uid 89); 24 Jun 2014 12:13:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Tue, 24 Jun 2014 17:12:49 +0530 From: Siddhesh Poyarekar To: "Joseph S. Myers" Cc: libc-alpha@sourceware.org Subject: Re: conformtest failures on i386 Message-ID: <20140624114248.GN4477@spoyarek.pnq.redhat.com> References: <20140624074749.GG4477@spoyarek.pnq.redhat.com> <20140624105051.GM4477@spoyarek.pnq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) On Tue, Jun 24, 2014 at 11:02:26AM +0000, Joseph S. Myers wrote: > On Tue, 24 Jun 2014, Siddhesh Poyarekar wrote: > > > On Tue, Jun 24, 2014 at 10:37:58AM +0000, Joseph S. Myers wrote: > > > On Tue, 24 Jun 2014, Siddhesh Poyarekar wrote: > > > > > > > Hi, > > > > > > > > The conformtest run on i386 builds have 40 FAILs in addition to the > > > > 120 XFAILS. Are these known are do those need to be fixed? > > > > > > You don't say what any of the actual errors shown in the logs for the > > > individual tests are. The presumption is that any such failure should be > > > fixed, as indicating an architecture-specific header bug (unless it > > > indicates a problem with the testcase, or that the internal include/ > > > headers are missing an _ISOMAC conditional). > > > > I hadn't looked at the actual causes of failures because the failures > > themselves were not relevant to the code I was testing. I'll look > > through the failures and file bugs wherever applicable. > > The few I just looked at were: > > Namespace violation: "d" > > which may be coming from bits/pthreadtypes.h. Yeah, all of the failures are the same as above. How about this for a fix: Siddhesh * sysdeps/x86/nptl/bits/pthreadtypes.h (pthread_mutex_t): Rename member __data.d to __data.__elision_data. diff --git a/sysdeps/x86/nptl/bits/pthreadtypes.h b/sysdeps/x86/nptl/bits/pthreadtypes.h index 7f8076b..aad2e14 100644 --- a/sysdeps/x86/nptl/bits/pthreadtypes.h +++ b/sysdeps/x86/nptl/bits/pthreadtypes.h @@ -115,10 +115,10 @@ typedef union { short __espins; short __elision; -# define __spins d.__espins -# define __elision d.__elision +# define __spins __elision_data.__espins +# define __elision __elision_data.__elision # define __PTHREAD_SPINS { 0, 0 } - } d; + } __elision_data; __pthread_slist_t __list; }; #endif