From patchwork Tue Jun 24 10:47:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 1684 Received: (qmail 7676 invoked by alias); 24 Jun 2014 10:46:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7663 invoked by uid 89); 24 Jun 2014 10:46:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Tue, 24 Jun 2014 16:17:39 +0530 From: Siddhesh Poyarekar To: Andreas Schwab Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Fix build warning in pthread_rwlock_* Message-ID: <20140624104739.GL4477@spoyarek.pnq.redhat.com> References: <20140619165137.GR7238@spoyarek.pnq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) On Tue, Jun 24, 2014 at 11:54:14AM +0200, Andreas Schwab wrote: > Siddhesh Poyarekar writes: > > > The first argument of elision_adapt and that of ELISION_*LOCK have > > different signs since __elision_rwcount is singned char and the > > __elision_rwcount doesn't exist. I have no idea where I got that from; it should have been __rwelision. > > argument of elision_adapt is uint8_t. Modified elision_adapt to > > accept int8_t instead of uint8_t. > > Make it signed char. Thanks, committed. Siddhesh commit 08e5862f5f087138047c757376edb1b63217d547 Author: Siddhesh Poyarekar Date: Tue Jun 24 16:12:43 2014 +0530 Fix build warning in pthread_rwlock_* The first argument of elision_adapt and that of ELISION_*LOCK have different signs since __elision_rwcount is signed char * and the argument of elision_adapt is uint8_t *. Modified elision_adapt to accept signed char * instead of uint8_t *. diff --git a/ChangeLog b/ChangeLog index 9b119b5..8bfdf80 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2014-06-24 Siddhesh Poyarekar + * sysdeps/x86/nptl/elide.h (elision_adapt): Make first + argument type signed char. + * Makerules (check-abi): Dump diff of symlist if the test fails. diff --git a/sysdeps/x86/nptl/elide.h b/sysdeps/x86/nptl/elide.h index 19f27e5..5befa53 100644 --- a/sysdeps/x86/nptl/elide.h +++ b/sysdeps/x86/nptl/elide.h @@ -26,7 +26,7 @@ /* Adapt elision with ADAPT_COUNT and STATUS and decide retries. */ static inline bool -elision_adapt(uint8_t *adapt_count, unsigned int status) +elision_adapt(signed char *adapt_count, unsigned int status) { if (status & _XABORT_RETRY) return false;