From patchwork Tue Jun 24 06:38:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 1683 Received: (qmail 10094 invoked by alias); 24 Jun 2014 06:36:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10082 invoked by uid 89); 24 Jun 2014 06:36:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Tue, 24 Jun 2014 12:08:02 +0530 From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [PATCH] Print offending diff when check-abi fails Message-ID: <20140624063802.GA19745@spoyarek.pnq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) The earlier version of check-abi would print a diff of the expected ABI vs the built ABI when there was a difference. Bring back this behaviour. * Makerules (check-abi): Dump diff of symlist if the test fails. --- Makerules | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makerules b/Makerules index 817d07e..6b30e8c 100644 --- a/Makerules +++ b/Makerules @@ -1257,7 +1257,8 @@ subdir_check-abi: check-abi subdir_update-abi: update-abi else check-abi: subdir_check-abi - if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then exit 1; fi + if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then \ + cat $(objpfx)*/check-abi*.out && exit 1; fi update-abi: subdir_update-abi endif