From patchwork Fri May 9 17:06:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 864 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A2FED360073 for ; Fri, 9 May 2014 10:07:09 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id 682A141927A33; Fri, 9 May 2014 10:07:09 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 45991419276BC for ; Fri, 9 May 2014 10:07:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; q= dns; s=default; b=VfWZfUgGNovhjrQ5S6cjmFTzTziNLPz7tECoh5izmHi+K+ zTeNjhyCufVGPd4cWROn+miKFVOsxHA+SQQUqK/F6j6ngRkm8PhX3ioREy00hcZh d+abw9puQjEgJQIK+6b05mf/ukE+oI0vPmmcERIDhL4f3XDW4+wyN/WRZYKJA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; s= default; bh=3vPGOlqwLiE/XSztHCiMBIMSPHg=; b=fYpzXi259uYttAfAXTBJ A7AqHOJJqajNcSCdh+WaFeIyon+3Zi+xBWGbY97i/+FEcfi/Pfw4NxkfXSyW8tZc 1/ES+HYaAjgXCJPskeQQgTcvrTJAJcnRtPkO4SR356bAIlb9vyPz2zndNzzwqnyZ BHsehSayneW1ufj88fp7o6Y= Received: (qmail 24788 invoked by alias); 9 May 2014 17:06:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 24743 invoked by uid 89); 9 May 2014 17:06:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: "GNU C. Library" Subject: [COMMITTED PATCH] Silence a missing-noreturn warning for _Unwind_Resume. Message-Id: <20140509170647.9E9772C39EF@topped-with-meat.com> Date: Fri, 9 May 2014 10:06:47 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=J405smXS c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=2zQJBIMF0VsA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=5L8S1lOW3OalwV7ASuQA:9 a=CjuIK1q_8ugA:10 X-DH-Original-To: glibc@patchwork.siddhesh.in 2014-05-09 Roland McGrath * sysdeps/gnu/unwind-resume.c (libgcc_s_resume): Mark as noreturn. --- a/sysdeps/gnu/unwind-resume.c +++ b/sysdeps/gnu/unwind-resume.c @@ -21,7 +21,8 @@ #include #include -static void (*libgcc_s_resume) (struct _Unwind_Exception *exc); +static void (*libgcc_s_resume) (struct _Unwind_Exception *exc) + __attribute__ ((noreturn)); static _Unwind_Reason_Code (*libgcc_s_personality) (int, _Unwind_Action, _Unwind_Exception_Class, struct _Unwind_Exception *, struct _Unwind_Context *); @@ -37,7 +38,8 @@ init (void) if (handle == NULL || (resume = __libc_dlsym (handle, "_Unwind_Resume")) == NULL || (personality = __libc_dlsym (handle, "__gcc_personality_v0")) == NULL) - __libc_fatal (LIBGCC_S_SO " must be installed for pthread_cancel to work\n"); + __libc_fatal (LIBGCC_S_SO + " must be installed for pthread_cancel to work\n"); libgcc_s_resume = resume; libgcc_s_personality = personality; @@ -48,7 +50,7 @@ _Unwind_Resume (struct _Unwind_Exception *exc) { if (__glibc_unlikely (libgcc_s_resume == NULL)) init (); - libgcc_s_resume (exc); + (*libgcc_s_resume) (exc); } _Unwind_Reason_Code @@ -59,6 +61,6 @@ __gcc_personality_v0 (int version, _Unwind_Action actions, { if (__glibc_unlikely (libgcc_s_personality == NULL)) init (); - return libgcc_s_personality (version, actions, exception_class, - ue_header, context); + return (*libgcc_s_personality) (version, actions, exception_class, + ue_header, context); }