From patchwork Tue Mar 25 02:04:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 257 X-Patchwork-Delegate: azanella@linux.vnet.ibm.com Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id B97AD360172 for ; Mon, 24 Mar 2014 19:04:51 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14307373) id 651611F4B907; Mon, 24 Mar 2014 19:04:51 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 3AC1DACE008 for ; Mon, 24 Mar 2014 19:04:51 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=jNASoFpaCp858GfZDtS60nQTHwZNU 1W8xAPyJg0FTeb3MZERysYiKsbtiJeEg47XR9pKuBqSfk0tEI/W01ZDsvlY5DO76 LGUZqtCc3anEvq3hQt0n1/dLUFzTytaEZ2ABxAEUVjZk/ZuaLb9RXu+UwaOPPvgI KcHo72LzmhGGkY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=cB0ln7WTE+IC64elswXDsIsDLPY=; b=Q0+ yZGpYOnPljNi8zu7yf+6xNPROwxNQN7Y/j3zqagcwmJu4jAuHo2rrbPxDaz/00eg DklKRV+z2tQ+1f+iIgOfeh2cIITzWupDUTpYwAtmvjNlxyE8+4FvtGQDeyPky7TF YfEjgSQTNGtRMJwe4dBlO0buxJ3hg/hDYScEwKCU= Received: (qmail 17421 invoked by alias); 25 Mar 2014 02:04:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 17320 invoked by uid 89); 25 Mar 2014 02:04:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f44.google.com X-Received: by 10.68.143.231 with SMTP id sh7mr75839200pbb.7.1395713075118; Mon, 24 Mar 2014 19:04:35 -0700 (PDT) Date: Tue, 25 Mar 2014 12:34:30 +1030 From: Alan Modra To: libc-alpha@sourceware.org Subject: Correct prefetch hint in power7 memrchr Message-ID: <20140325020430.GE18201@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-DH-Original-To: glibc@patchwork.siddhesh.in Typo fix. Discovered when looking at some disassembly, and wondering why this disassembled as dcbtt. My simple benchmark testing didn't show any effect of using the wrong hint, but at a guess you'd only see a difference on a very long memrchr with cold caches. * sysdeps/powerpc/powerpc64/power7/memrchr.S: Correct stream hint. diff --git a/sysdeps/powerpc/powerpc64/power7/memrchr.S b/sysdeps/powerpc/powerpc64/power7/memrchr.S index 40e436f..0c01ca2 100644 --- a/sysdeps/powerpc/powerpc64/power7/memrchr.S +++ b/sysdeps/powerpc/powerpc64/power7/memrchr.S @@ -29,7 +29,7 @@ ENTRY (__memrchr) mr r10,r3 clrrdi r6,r7,7 li r9,3<<5 - dcbt r9,r6,16 /* Stream hint, decreasing addresses. */ + dcbt r9,r6,8 /* Stream hint, decreasing addresses. */ /* Replicate BYTE to doubleword. */ insrdi r4,r4,8,48