diff mbox

[ping,2/2] Mark nscd service as forking in systemd service file (#16639)

Message ID 20140310072553.GB1656@spoyarek.pnq.redhat.com
State Committed
Headers show

Commit Message

Siddhesh Poyarekar March 10, 2014, 7:25 a.m. UTC
Ping!

Sending patch again to track on patchwork.  nscd now correctly waits
for the child process to start normally before exiting, so the forking
type works correctly for it.

Siddhesh

	* nscd/nscd.service: Make service type forking.

---
 nscd/nscd.service | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Siddhesh Poyarekar March 10, 2014, 7:50 a.m. UTC | #1
Thanks, I've pushed this now - replying since you accidentally
responded off-list :)

Siddhesh

On Mon, Mar 10, 2014 at 05:33:56PM +1000, Allan McRae wrote:
> On 10/03/14 17:25, Siddhesh Poyarekar wrote:
> > Ping!
> > 
> > Sending patch again to track on patchwork.  nscd now correctly waits
> > for the child process to start normally before exiting, so the forking
> > type works correctly for it.
> > 
> > Siddhesh
> > 
> > 	* nscd/nscd.service: Make service type forking.
> 
> Looks fine to me.  (I'd say this is obvious after your nscd change.)
> 
> Allan
>
diff mbox

Patch

diff --git a/nscd/nscd.service b/nscd/nscd.service
index 99c7563..b7428a3 100644
--- a/nscd/nscd.service
+++ b/nscd/nscd.service
@@ -4,8 +4,8 @@ 
 Description=Name Service Cache Daemon
 
 [Service]
-Type=simple
-ExecStart=/usr/sbin/nscd --foreground
+Type=forking
+ExecStart=/usr/sbin/nscd
 ExecStop=/usr/sbin/nscd --shutdown
 ExecReload=/usr/sbin/nscd -i passwd
 ExecReload=/usr/sbin/nscd -i group