diff mbox

Prefer https: for GNU and FSF URLs

Message ID 1c22e434-1091-dba1-7604-c1e909ecef8a@cs.ucla.edu
State Committed
Headers show

Commit Message

Paul Eggert Sept. 7, 2019, 10:22 a.m. UTC
On 9/7/19 3:06 AM, Paul Eggert wrote:
> I assume that to install this patch I would need to fix the pre-commit hooks on 
> the sourceware.org side

Scratch that: it's easier to pacify the pre-commit hooks than to change them, so 
I installed the attached patch instead.

I was puzzled because you patched these three files when updating copyright 
dates in January, whereas I couldn't patch them today without fixing their 
trailing-newline style. I guess the pre-commit hooks have changed since January, 
but I don't know where they're kept.

Comments

Joseph Myers Sept. 9, 2019, 4:28 p.m. UTC | #1
On Sat, 7 Sep 2019, Paul Eggert wrote:

> I was puzzled because you patched these three files when updating copyright
> dates in January, whereas I couldn't patch them today without fixing their
> trailing-newline style. I guess the pre-commit hooks have changed since
> January, but I don't know where they're kept.

Yes, we switched to using the AdaCore set of hooks, which must have some 
differences from the old hooks in exactly how they detect problems with 
trailing whitespace.

https://sourceware.org/ml/libc-alpha/2019-04/msg00335.html
Florian Weimer Sept. 9, 2019, 5:45 p.m. UTC | #2
* Joseph Myers:

> On Sat, 7 Sep 2019, Paul Eggert wrote:
>
>> I was puzzled because you patched these three files when updating copyright
>> dates in January, whereas I couldn't patch them today without fixing their
>> trailing-newline style. I guess the pre-commit hooks have changed since
>> January, but I don't know where they're kept.
>
> Yes, we switched to using the AdaCore set of hooks, which must have some 
> differences from the old hooks in exactly how they detect problems with 
> trailing whitespace.
>
> https://sourceware.org/ml/libc-alpha/2019-04/msg00335.html

I think the old hooks did not bother to complain if the old file
contained the same whitespace violation.

Thanks,
Florian
diff mbox

Patch

From 5cb226d7e4e710939cff7288bf9970cb52ec0dfa Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 7 Sep 2019 02:54:48 -0700
Subject: [PATCH] Fix three GNU license URLs, along with trailing-newline
 issues.

---
 sysdeps/powerpc/powerpc64/ppc-mcount.S          | 3 +--
 sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S | 4 ++--
 sysdeps/unix/sysv/linux/s390/s390-64/syscall.S  | 3 +--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/sysdeps/powerpc/powerpc64/ppc-mcount.S b/sysdeps/powerpc/powerpc64/ppc-mcount.S
index fb301a77be..36299dac2b 100644
--- a/sysdeps/powerpc/powerpc64/ppc-mcount.S
+++ b/sysdeps/powerpc/powerpc64/ppc-mcount.S
@@ -14,7 +14,7 @@ 
 
    You should have received a copy of the GNU Lesser General Public
    License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
+   <https://www.gnu.org/licenses/>.  */
 
 #include <sysdep.h>
 /* We don't need to save the parameter-passing registers as gcc takes
@@ -38,4 +38,3 @@  ENTRY(_mcount)
 	addi		 r1,r1,FRAME_MIN_SIZE
 	blr
 END(_mcount)
-
diff --git a/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S b/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
index 17f5f26391..99bf82d435 100644
--- a/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
+++ b/sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
@@ -16,7 +16,7 @@ 
 
    You should have received a copy of the GNU Lesser General Public
    License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
+   <https://www.gnu.org/licenses/>.  */
 
 #include <sysdep.h>
 
@@ -322,4 +322,4 @@  small_copy_unaligned:
 
 END(__memcpy_ultra3)
 
-#endif
\ No newline at end of file
+#endif
diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S b/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
index b51aa2fc50..bbe4d79848 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
@@ -14,7 +14,7 @@ 
 
    You should have received a copy of the GNU Lesser General Public
    License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
+   <https://www.gnu.org/licenses/>.  */
 
 #include <sysdep.h>
 
@@ -59,4 +59,3 @@  ENTRY (syscall)
 	jgnl   SYSCALL_ERROR_LABEL
 	br     %r14		   /* Return to caller.	 */
 PSEUDO_END (syscall)
-
-- 
2.17.1