From patchwork Tue Dec 3 17:30:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Kilroy X-Patchwork-Id: 36482 Received: (qmail 16163 invoked by alias); 3 Dec 2019 17:30:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 15669 invoked by uid 89); 3 Dec 2019 17:30:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9H9O+XtCay8hCLI7vMna1/i3HZSdUw1h4yR8ZYmLve0=; b=5YDB64tWs8HA4bOCq/f/ghyn3FFm47xNnMDpf38DO8ySQ2QigbYVvb2QyKauvOvCDHqDcVdkY59VhlYRCKuqmoiyZYYl4lYcOYBeVigmT992hN2ckIdZhscH8lVAcIkgbaYmNfHsO7AmIDlENdCCQLDHPNfZzaWsGkcbA8YnK7o= Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b5a7b96ff383b61c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OoBcdohWe9f30Ys0/5+Uzi9sLGT54KSN5xl4bVr5S0JFpwT2AGSQZf0/w4RZRgyEADmWv2vj4/NstoiYmkfWiEQEyfzRRVYunFODoT6e5W0m5zZAGKXov8SK6UZIHxFLLoV2VDb8hmBoZsm9f+i0d2YIUx9Xp2J3yY8Y0FQtQZdxrcrQKlPV9hEBGzMxsuzuQ/7b4ARDfIOD4pKrCUvLPx4/wAEb0rS3S1zPN/zs0jfzVZsYuLxOnWFrOmrvPRHabUDjS2bgZmHcSu9R+o3zTox2NZiWT1lzYteSCWu3mwGlB6V1qu4J015d5jMMX0wrHCvPVAoy1V/rFkkc4txL9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9H9O+XtCay8hCLI7vMna1/i3HZSdUw1h4yR8ZYmLve0=; b=Ekf1kEiWWLISfsIeKgWZYZMS1sYDrNiQlsDc8Un45O+m/5Atec80BjMvlGQeKLLOcHDMsCnBFBjbkzMTh/H/yKU8mA7M3BgnmOBLntTBrabjTe1e3M75cknB851s1a7pfHeTCsuT7QC9A6vUwB+pzMLSesgiSEFWaIcLWMTKjLNV0dZSOKpLorympXOV+jIQ3IqEDPawnaYfDjdjHSvzTfjiz5lKXYGVftO0AlW4jGhidpq368Umd/CDwufczQijkv17bT2SwV3BMYEikHZ8O0bhMrQU4agb+P+VmcwhoHPJEyd6oXrkkyH2e5mldN4sB/JTHbLRZ4as7tJcD2L9Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9H9O+XtCay8hCLI7vMna1/i3HZSdUw1h4yR8ZYmLve0=; b=5YDB64tWs8HA4bOCq/f/ghyn3FFm47xNnMDpf38DO8ySQ2QigbYVvb2QyKauvOvCDHqDcVdkY59VhlYRCKuqmoiyZYYl4lYcOYBeVigmT992hN2ckIdZhscH8lVAcIkgbaYmNfHsO7AmIDlENdCCQLDHPNfZzaWsGkcbA8YnK7o= From: David Kilroy To: "libc-alpha@sourceware.org" CC: nd Subject: [PATCH v3 2/3] elf: avoid redundant sort in dlopen Date: Tue, 3 Dec 2019 17:30:11 +0000 Message-ID: <1575394197-18006-3-git-send-email-david.kilroy@arm.com> References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> In-Reply-To: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=David.Kilroy@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(199004)(189003)(99286004)(102836004)(6436002)(4326008)(478600001)(14454004)(2906002)(386003)(50226002)(36756003)(186003)(6916009)(2616005)(6506007)(305945005)(76176011)(52116002)(86362001)(81156014)(25786009)(26005)(71190400001)(6486002)(71200400001)(256004)(81166006)(2501003)(14444005)(7736002)(3846002)(8676002)(8936002)(446003)(11346002)(44832011)(316002)(4744005)(66476007)(6512007)(66556008)(66446008)(64756008)(66946007)(2351001)(5660300002)(6116002)(5640700003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4001; H:AM0PR08MB4068.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ihBQL5joMI34yQaOAsyJQLygMiMBbjKzD4Rwl5HSQZoQDqaxwzq/P9cF3X4flHapDr1F57luDxar7XgiWbdIdfZ9GzwgxOSxlxVkZiJBWrByflpRBSnv/MBIv/KvAkQINHeCzJTAxmKU77VqsKLw4gbDMZq48d1sGdTOgwkpykhtZ/Eo8nEYC/X1ZyY5C1dA6XRmhJJbWM5wcybifmNNx6Rjl8HFh0yFVdqjsAlfoxXUzXVS5MEKjugfd2ogGA2JYzlRu5aaMF77CDYsANYbM3zrubOdUFT/hbF7VS/o2fYQg0bSFu4mmw5IMFK1l2pbyA2KrM/2lxvlBITjWegVH9jUqKvW1+XUu4I1NP8Jofm0kC4dJ2dxrMZMBtZ/w+k3KIWK+qn40PN6RC1SSIcabSWKlF+TFcEXJS5f1hwKSnw8qrGtxUu94VVbmXTLS4ol x-ms-exchange-transport-forked: True MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Kilroy@arm.com; Return-Path: David.Kilroy@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5e1584c4-d8de-49c0-f21e-08d77816731d l_initfini is already sorted by dependency in _dl_map_object_deps(), so avoid sorting again in dl_open_worker(). Tested by running the testsuite on x86_64. Reviewed-by: Adhemerval Zanella --- elf/dl-open.c | 1 - 1 file changed, 1 deletion(-) diff --git a/elf/dl-open.c b/elf/dl-open.c index 9996fe9..c4d09c7c 100644 --- a/elf/dl-open.c +++ b/elf/dl-open.c @@ -658,7 +658,6 @@ dl_open_worker (void *a) l = new->l_initfini[++j]; } while (l != NULL); - _dl_sort_maps (maps, nmaps, NULL, false); int relocation_in_progress = 0;