From patchwork Fri Dec 15 16:43:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 24966 Received: (qmail 93354 invoked by alias); 15 Dec 2017 16:43:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 93344 invoked by uid 89); 15 Dec 2017 16:43:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1513356200.23720.6.camel@cavium.com> Subject: [Patch] Increase buffer size due to warning from ToT GCC From: Steve Ellcey Reply-To: sellcey@cavium.com To: libc-alpha Date: Fri, 15 Dec 2017 08:43:20 -0800 Mime-Version: 1.0 X-ClientProxiedBy: MWHPR18CA0036.namprd18.prod.outlook.com (10.175.9.150) To BLUPR0701MB2033.namprd07.prod.outlook.com (10.163.122.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c659896-31f8-4138-2186-08d543daf610 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:BLUPR0701MB2033; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2033; 3:BZdMi3sLoRoqeWIES2wzgAnnA54LNXy41U3HHHA1RqNo4+ydCgMCvFUOxywm8RCGtdhI5lVkn5rQeYFoWQOU+4YVc8JTJNFKoLwE0vpbAPorEgSJi6kNArvd4pvZx5zHzJloRKOVDwOMeNbGgukuhlIbJfX8gJnktYErahRe+fhB/ZvAhzNQivyQZhSwAi4HsU1pgsXCZQ5dkEsz3FcbvSUr7IWUgZdgqUSjdvpZHOCPyIN4EPJCor400vqLIaSU; 25:hRiEqaK4JIlUM2WNPKRVHDPPeQIq2uO/RzNfE2w6fDMpMQdoE+mBEK45B9IS/p9aW6ec58ebp/HCgpWgpkYGqMY2pjH3Larv57yL8LXt/huBWbij90wkLZpFgVTWTQH4y77Y3pbxXzFN2t47OZBr+vJ5MDQLMpx2yrzjHTagHOF5iZY6pqPsJ27JlcQAuiMGv+hKJLYKlq5WWxBob20k6yVS23mlun9erdsjjPwUC89gn7jhzwPgkNfEOMQn+pa9RSFsIbFTcq2FF4nmfClRpOJ5gjWBVufjA04YbdvjBq3ocJ104K1UNIiN6bQTGZLzwOUtv2xr9EkQuQrhkG4gdVu+bwKcc6njwEJhx8jNqJw=; 31:FOZ/WiIVGlVgR2nBXqFx+DOr9yStSrak3na4g3z03vfgM2FD3pfRabwgLWgO3JAWFfQmEN6M9HvZHhiM9gt5w18yUt++ITFkPEh5x9bHERvdUvKO5EzFA/cCfwokJ+Dnj6QJqq1JcM780vveeMXkFbkgF1KNcjcscgzFRijjxeul+LQHhh/jvcw0igb6kCLyh7skqqGgtzhYnEdmpHmXusMXI7ZRSXZRc3mySWJhe70= X-MS-TrafficTypeDiagnostic: BLUPR0701MB2033: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2033; 20:evPvL3pQQaq1QxP1O3QSOoNwG1qOwekd7H9QT3Zp3n5yCNN7TS9hWZB2jeXl1RHgYad/Vep+u9LdCTuoJ+rNoDQmrLLIU4trYntT5LQWareqWMwScAwtsUUoWUbOHPwSvvWFWoUmCsj4AVTtIqSdQJVMxpvGdlOcWjAQTtMcJFapATTy0zglXhlPFv7ugyel/X/E31RfWBlGFJmMRd1jd6ikV0msutowrPX8e+8TNQdDxL1pe9oxtxfFtpjtEVGHTBLbGNkIuNHe7+maoej9jysiMlsBQb13fTMHM2mzaw970DbWUwjeHw1pJCKLlKOvpL+7e8+cyObY7hZuKMOfIJwdCQ8OMwyVcxj17WvwmPaYq2B8Ndteak6gWLu/qJ1oB5AZzXehx8qk0tEp0xpupfqXbjX13RRgFAKI1v18+rONL/9CwdAPO2f+9wv2lDN4bvPTOaO8QX52d98Q7Z6B3Z1pXPgSUGPwGUHAMICXnuI5beITSvALcduruVr1MnNJ; 4:Fdo/oMqi1QX47pRdOvUM0dTxbDAisiwKHuyFl1Az5+zM6DrPnXXnGDISexeDyLPB+R7S+DQhKhdVX02wrzF3Uu1wY+bPVCHpiOoDl+B96QDvrkjHVjXTI/ArJtNKjyY5Tansh+yzEThxPEsuJDxMKgoWNm4uqV4MW/QSI4O2tHVXjN3vBrwzFyzydQVpbgLzJKa3n8+e4TdniF6T09ptjQ2bjoQM7bunNoKZRdlSPgyr1NmYFpgbadIi48TElWgJIbPWatioEACdpK0kG5MPYA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231023)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011); SRVR:BLUPR0701MB2033; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BLUPR0701MB2033; X-Forefront-PRVS: 05220145DE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39850400004)(396003)(377424004)(199004)(189003)(43066004)(106356001)(2870700001)(16526018)(53936002)(316002)(105586002)(50466002)(6486002)(386003)(6506007)(3846002)(97736004)(6116002)(103116003)(5820100001)(7736002)(305945005)(4001150100001)(6666003)(6916009)(72206003)(50226002)(52116002)(8676002)(23676004)(8936002)(2906002)(478600001)(36756003)(66066001)(53416004)(47776003)(25786009)(81156014)(68736007)(69596002)(5660300001)(81166006)(6512007)(3450700001)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2033; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3MDFNQjIwMzM7MjM6cjRlc0l3bzYwNVpsc1lxWnFLMlFRSlBY?= =?utf-8?B?ZStaYmpTanY1a3FhTm9ZWnY0Q3h4QnRNdEZ3d3dxd1hZT0RpaEZXOVRIb2li?= =?utf-8?B?SmlpY3owRmJMZkR1cm1GZWpnR29qdnU2MGwybXFVblU5MmZlZVdkWGFER2dV?= =?utf-8?B?SzRTbTkrbTFGZ3Nwb0N4bHpmRXJjMkJxZk9VeWMrUzBla3lxQU1LUEZpOGtF?= =?utf-8?B?bzN2eTcxajlKV3oxckN3Z09EWmNkTnVTWnhtTHJ3TkdQd2RiczVlbGxMTDc0?= =?utf-8?B?QTc4U2YvL1plbGd1K0FBZjNjckNldWdmUzdlRkdmUlVOWmlVajJLWUZMQ1FM?= =?utf-8?B?TDJJUm4yMUlXbVJPNGFtNGp6Q1JqSWdXSndHQVlnSzFuaGpqdXhiLy9PbHlR?= =?utf-8?B?LytITVBuMXdsaUdhQUJJVm1COFBDYkFaU2JOTkhiR2N6THYvc3p0b1BST0V5?= =?utf-8?B?M01BM3RMT0dXN0lxQytpOER6M1Q3NzZzRU1qbmVMVHpJdmlpZEd1SmVma040?= =?utf-8?B?QVB5dS9uUDljelErVU1XQ2FzZmNVUEZ5T2pnL1ZJQjdSZWpsQWkxMUlrNjZp?= =?utf-8?B?cTd5ZFNyNVpFTkEyc1NVWWw1aDdCeHdoS2J5L3pqcG4wUFR5ZDg2cGhudHJu?= =?utf-8?B?S210NlRFc1lKUEl0SzBacU5nU3FuWTRnTU91L2FqeHlmQmFzNzZEaWdtWkNF?= =?utf-8?B?TEdWbVlsd3NiU1Uvd3FjS09jYnU3MDVSaXk5M1I2bmFIU1JDckRnWWpUN2Fz?= =?utf-8?B?L0JUc21iQ3NnaFFBMDN4UTArNVBmTHpGUnZJMEdpdExkVUF3VGU1K04xSUJX?= =?utf-8?B?S3FGM0dTci9qbHR4ektxODN6OGQwb3NMbEFwNnptZkR0OHlWN1UyTkdkSHNy?= =?utf-8?B?RE1jNDRmS2tudXRpT2VRMHVzeGFmZ0NNZm1hSDUzVVVhVjZQSXlweVpZRWdr?= =?utf-8?B?UDJVM3pVS0RnMFNvdVRVenlGL0dFQ0lDcTFrWEZRZHEveWZOTFQvc1VNUXBm?= =?utf-8?B?SXdXRGZyeHQrSGpXU1FmbTZUV1lPM3BtZk00ZkpNM2phaG5JRXJadkNWTSty?= =?utf-8?B?a1FFTGZjZExteHZYbzhpZTZNdlhINkFTaEl0L05jaS9YZUpNMTRmdm5ST1RI?= =?utf-8?B?cmY5NUVGalQrcEludUxxdjhZMFhjbmJSY0FMUW5sWWdYUGdvdU40aWpuUU5n?= =?utf-8?B?OE45TDdvK2gwTHZaMm02LytydVZCT01LUmc3K3hjcEc0QXRtYjJVNlJISm44?= =?utf-8?B?cU9uUUV3ek9lR2tmUHFad2pCTVo3dnE4dnBJNCs0dUFYMHFsSUVmcXVQai9y?= =?utf-8?B?RHA0NEpuai80U1ovZFFxOVZHbDJBV3JKWmE2MUxwMzVJRzEwYlROYmFXdzM5?= =?utf-8?B?Q2hHa0hLeGg4VEhEYjJNckRSNXRycHpWTFRhbjd6MFgvOUIrb3BhMk04b25S?= =?utf-8?B?SVdoSi9WVzlDUXBLbXFJOWoxOHk4RDZodVk2ZkYrbjdGRHE4Uk5tOVN6ZDAw?= =?utf-8?B?N25FQzkxeUVaVWhaekFjTmk1TDRTclJoQ0o3MXhNeTQ1SS9oWUhJc2tyWHdS?= =?utf-8?B?YWFkMVVHWXl4b3VSc0ZuNVQ4am5CZXdrbWcyUzhuQmxZQkxSRXJuNmJuRzJp?= =?utf-8?Q?g=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2033; 6:AKfp4Mleita0iXZuQGpKnC0DgUB7/xYHuc260yKTTjsHQ02Pqu/wcGo2L+NWMTsUdpQTJJopfqJDLsl5iEE6bnXVbw8NXluRmqR0MmbcwJavZG67TaQgrrV7E/nIs8mHLXGXhrqRNs878FWbLJpthbnjJdUnVYba1ardSYNkjzvI40LaCNDwpAsgFGMRN//xbtjCM0yj+Weo6+dwjHksb1sGrI8C3aa/6pU2uKV4Iu7giZVT6C5IyMko982/5qh9w9ymNtmpVWFgonK3Au6bQyAQQNTX8CMrpAQJIG0ALSx/2moOmq146dHKHydbrH0FQeOEIOJ/b5Ky8N77oDqt7V3jEfe/YzBS339ztWh73MI=; 5:m1K4dzT7Xy3PMeji53Kht/hRAaOO5KYYA2y8ujIAFuOaFpLX6uslYHbTiZU6Be3zplkkIn9DoEOwWSwG+5hySFj7ADJANCO7mTBsaAnSFUhixpdQnquhDCV0EYzDGadg6qL5RQ/tQUNwlR/fiprd2Qd67cFqKIG6htevWGRyclQ=; 24:ctIddP690ScSfMulsffkPt7RHntAGgJr77ofLAdq3GCOinwGW99RYawO13mGrfWQM+ZL1VuNJGx7sc/U3mLL+U4u+ki6utBPC9B4MwrSIko=; 7:i05qdCX7eU7c3T2fwpjECsD9dBEHefezAPNBEyhs5J7WZsVyLgMt/d3ejpFMSpSgp2QVFI/s8jLHJV/u7J4Lu993N+qZQRCgfwFnVx3mPI7LECopgRB7+yuTuSr9gg7mucOFqnz5HfOuJS2EfJ6JU/I+EyxgPCK93hYPc9YCwoSmt0I92WWf8yju5nwYgQ2bJohyW0iNNg3VNTPor75X5GbJXldocRx9TsZVlsmWOk4OopZXx5XcLsOy5szGHA2f SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2017 16:43:24.9539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c659896-31f8-4138-2186-08d543daf610 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2033 I ran into another error while building ToT glibc with ToT GCC. dbg_log.c: In function ‘dbg_log’: dbg_log.c:71:46: error: ‘%s’ directive output may be truncated writing up to 511 bytes into a region of size between 241 and 506 [-Werror=format-truncation=]        snprintf (msg, sizeof (msg), "%s - %d: %s%s", buf, getpid (), msg2,                                               ^~                     ~~~~ In file included from ../libio/stdio.h:862,                  from ../include/stdio.h:2,                  from dbg_log.c:19: ../libio/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 7 and 784 bytes into a destination of size 512    return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~         __bos (__s), __fmt, __va_arg_pack ());         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ../o-iterator.mk:9: recipe for target '/home/sellcey/tot/obj/glibc64/nscd/dbg_log.o' failed make[2]: *** [/home/sellcey/tot/obj/glibc64/nscd/dbg_log.o] Error 1 Here is a patch to fix it, OK to checkin? 2017-12-15  Steve Ellcey   * nscd/dbg_log.c (dbg_log): Increase msg buffer size. diff --git a/nscd/dbg_log.c b/nscd/dbg_log.c index d4b19ac..2190c16 100644 --- a/nscd/dbg_log.c +++ b/nscd/dbg_log.c @@ -67,7 +67,7 @@ dbg_log (const char *fmt,...)        char buf[256];        strftime (buf, sizeof (buf), "%c", &now);   -      char msg[512]; +      char msg[1024];        snprintf (msg, sizeof (msg), "%s - %d: %s%s", buf, getpid (), msg2,   msg2[strlen (msg2) - 1] == '\n' ? "" : "\n");        if (dbgout)