From patchwork Fri Nov 3 21:40:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 24087 Received: (qmail 38168 invoked by alias); 3 Nov 2017 21:41:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 38114 invoked by uid 89); 3 Nov 2017 21:41:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=3l7+yspJC4LaeFVnz2D5Rmamb0AtBF407lwLW2BX6M8=; b=ZJd9xtdbAhasJ9+kUAurL+MAAq05ySzrTTHZL5civQbcZIbQ0Fb62+cli6kBNDcQGP /dpaLGPhqOJDkuxi0ieigCCLz0chjmpqRG2RdenFSKnoN0brcBBm3/3ms//3B9+sMfeg HaSbdc2Hb9HlPuD3LZQIyz7/wSZNBJ3gkfV8FixNYaP/fg7fVlvSxUO0txMK3tF6rdJb 86clDcaOP8i7OTa2P/b8IDmDhIEfdJ3IUYKIUymafLkU8s2ccfyB14Al9XFvF2d9SYuB ktHGaQVGSfMRHiYp5hYkQ9zLrSfGXstMu5lJeWpTSkP6Ott8T+0ymHV/U477+VaHpszb 1udg== X-Gm-Message-State: AMCzsaXcYgmxwq7QNMwM5pnkQVZ8namjadWSWz7cMUHFTGhQMu038HmA rmAtPRl+0ns/nM8H9OabzQHcOMQNPZg= X-Google-Smtp-Source: ABhQp+QFxVLHk3wqEi61Tscg2im/k7nfwbcPbxde6FxBRUpvnjsQ9jvGgbDb3bMu5PMGSZCOvm9cNg== X-Received: by 10.237.36.130 with SMTP id t2mr12124575qtc.148.1509745263776; Fri, 03 Nov 2017 14:41:03 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 5/6] Optimize sighold implementation Date: Fri, 3 Nov 2017 19:40:48 -0200 Message-Id: <1509745249-11404-5-git-send-email-adhemerval.zanella@linaro.org> In-Reply-To: <1509745249-11404-1-git-send-email-adhemerval.zanella@linaro.org> References: <1509745249-11404-1-git-send-email-adhemerval.zanella@linaro.org> This patch simplifies sighold a bit by removing an extra sigprocmask and using SIG_BLOCK (which union of the current set and the set argument). Checked on x86_64-linux-gnu. * signal/sighold.c (sighold): Optimize implementation. Signed-off-by: Adhemerval Zanella --- ChangeLog | 2 ++ signal/sighold.c | 10 ++-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/signal/sighold.c b/signal/sighold.c index 2e32e47..955ac5b 100644 --- a/signal/sighold.c +++ b/signal/sighold.c @@ -26,14 +26,8 @@ sighold (int sig) { sigset_t set; - /* Retrieve current signal set. */ - if (__sigprocmask (SIG_SETMASK, NULL, &set) < 0) - return -1; - - /* Add the specified signal. */ + sigemptyset (&set); if (sigaddset (&set, sig) < 0) return -1; - - /* Set the new mask. */ - return __sigprocmask (SIG_SETMASK, &set, NULL); + return __sigprocmask (SIG_BLOCK, &set, NULL); }