New generic sinf

Message ID 1509097635-18473-1-git-send-email-raji@linux.vnet.ibm.com
State Superseded
Headers

Commit Message

Rajalakshmi S Oct. 27, 2017, 9:47 a.m. UTC
  The same logic used in s_sinf.S version of x86 and powerpc
is moved as generic s_sinf.c, so there is no performance
improvement in x86_64 and powerpc64.
For s390, this is the improvement noted.

With patch:
benchtests/bench-sinf
  "": {
    "duration": 9.91026e+09,
    "iterations": 4.6512e+08,
    "max": 130.26,
    "min": 7.027,
    "mean": 21.3069
   }
Without patch:
 "": {
    "duration": 1.00656e+10,
    "iterations": 1.65699e+08,
    "max": 1740.57,
    "min": 4.729,
    "mean": 60.7461
   }

Also addressed comments from Joseph on generic sincosf version
Ref:https://sourceware.org/ml/libc-alpha/2017-10/msg00367.html

---

This implementation is based on optimized sinf assembly versions
of x86_64 and powerpc.

Tested on s390, x86_64 and powerpc64le.

2017-10-27  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>

	* sysdeps/ieee754/flt-32/s_sinf.c: New implementation.
---
 sysdeps/ieee754/flt-32/s_sinf.c | 247 +++++++++++++++++++++++++++++++++-------
 1 file changed, 209 insertions(+), 38 deletions(-)
  

Comments

Joseph Myers Oct. 27, 2017, 4:38 p.m. UTC | #1
On Fri, 27 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:

>  #if defined(LIBM_SCCS) && !defined(lint)
>  static char rcsid[] = "$NetBSD: s_sinf.c,v 1.4 1995/05/10 20:48:16 jtc Exp $";

If you're replacing the whole implementation, it definitely doesn't make 
sense to keep this.

How does this patch affect the performance on the testcase in bug 5997?  
It's not a *good* benchmark, but if the patch sufficiently improves 
performance it could be considered to fix [BZ #5997].
  
Rajalakshmi S Oct. 30, 2017, 5:32 a.m. UTC | #2
On 10/27/2017 10:08 PM, Joseph Myers wrote:
> On Fri, 27 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:
> 
>>   #if defined(LIBM_SCCS) && !defined(lint)
>>   static char rcsid[] = "$NetBSD: s_sinf.c,v 1.4 1995/05/10 20:48:16 jtc Exp $";
> If you're replacing the whole implementation, it definitely doesn't make
> sense to keep this.

Ack.
> 
> How does this patch affect the performance on the testcase in bug 5997?
> It's not a*good*  benchmark, but if the patch sufficiently improves
> performance it could be considered to fix [BZ #5997].


On s390 for the testcase mentioned in BZ #5997 for sinf:
Time without patch:
real	0m4.931s
user	0m4.924s
sys	0m0.002s

Time with patch:

real	0m0.223s
user	0m0.220s
sys	0m0.002s
  

Patch

diff --git a/sysdeps/ieee754/flt-32/s_sinf.c b/sysdeps/ieee754/flt-32/s_sinf.c
index 3ec98f811d..5af506a905 100644
--- a/sysdeps/ieee754/flt-32/s_sinf.c
+++ b/sysdeps/ieee754/flt-32/s_sinf.c
@@ -1,17 +1,20 @@ 
-/* s_sinf.c -- float version of s_sin.c.
- * Conversion to float by Ian Lance Taylor, Cygnus Support, ian@cygnus.com.
- */
+/* Compute sine of argument.
+   Copyright (C) 2017 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
 
-/*
- * ====================================================
- * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
- *
- * Developed at SunPro, a Sun Microsystems, Inc. business.
- * Permission to use, copy, modify, and distribute this
- * software is freely granted, provided that this notice
- * is preserved.
- * ====================================================
- */
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
 
 #if defined(LIBM_SCCS) && !defined(lint)
 static char rcsid[] = "$NetBSD: s_sinf.c,v 1.4 1995/05/10 20:48:16 jtc Exp $";
@@ -28,35 +31,203 @@  static char rcsid[] = "$NetBSD: s_sinf.c,v 1.4 1995/05/10 20:48:16 jtc Exp $";
 # define SINF_FUNC SINF
 #endif
 
-float SINF_FUNC(float x)
-{
-	float y[2],z=0.0;
-	int32_t n, ix;
+/* Chebyshev constants for sin, range -PI/4 - PI/4.  */
+static const double C0 = -0x1.ffffffffe98aep-2;
+static const double C1 = 0x1.55555545c50c7p-5;
+static const double C2 = -0x1.6c16b348b6874p-10;
+static const double C3 = 0x1.a00eb9ac43ccp-16;
+static const double C4 = -0x1.23c97dd8844d7p-22;
+static const double S0 = -0x1.5555555551cd9p-3;
+static const double S1 = 0x1.1111110c2688bp-7;
+static const double S2 = -0x1.a019f8b4bd1f9p-13;
+static const double S3 = 0x1.71d7264e6b5b4p-19;
+static const double S4 = -0x1.a947e1674b58ap-26;
+static const double SS0 = -0x1.555555543d49dp-3;
+static const double SS1 = 0x1.110f475cec8c5p-7;
+static const double SMALL = 0x1p-50;
+static const double inv_PI_4 = 0x1.45f306dc9c883p+0;
+static const double PI_2_hi = -0x1.921fb544p+0;
+static const double PI_2_lo = -0x1.0b4611a626332p-34;
 
-	GET_FLOAT_WORD(ix,x);
+#define FLOAT_EXPONENT_SHIFT 23
+#define FLOAT_EXPONENT_BIAS 127
 
-    /* |x| ~< pi/4 */
-	ix &= 0x7fffffff;
-	if(ix <= 0x3f490fd8) return __kernel_sinf(x,z,0);
+static const double pio2_table[] = {
+  0 * M_PI_2,
+  1 * M_PI_2,
+  2 * M_PI_2,
+  3 * M_PI_2,
+  4 * M_PI_2,
+  5 * M_PI_2
+};
 
-    /* sin(Inf or NaN) is NaN */
-	else if (ix>=0x7f800000) {
-	  if (ix == 0x7f800000)
-	    __set_errno (EDOM);
-	  return x-x;
-	}
+static const double invpio4_table[] = {
+  0x0p+0,
+  0x1.45f306cp+0,
+  0x1.c9c882ap-28,
+  0x1.4fe13a8p-58,
+  0x1.f47d4dp-85,
+  0x1.bb81b6cp-112,
+  0x1.4acc9ep-142,
+  0x1.0e4107cp-169,
+  0x1.ca2c756p-196,
+  0x1.bd778acp-224
+};
 
-    /* argument reduction needed */
-	else {
-	    n = __ieee754_rem_pio2f(x,y);
-	    switch(n&3) {
-		case 0: return  __kernel_sinf(y[0],y[1],1);
-		case 1: return  __kernel_cosf(y[0],y[1]);
-		case 2: return -__kernel_sinf(y[0],y[1],1);
-		default:
-			return -__kernel_cosf(y[0],y[1]);
-	    }
-	}
+static const int ones[] = { +1, -1 };
+
+static inline float
+reduced (const double theta, const unsigned long n,
+         const unsigned long signbit)
+{
+  double sx, theta2;
+  /* We are operating on |x|, so we need to add back the original
+   * signbit for sinf.  */
+  int sign_sin;
+  sign_sin = ones[((n >> 2) & 1) ^ signbit];
+  theta2 = theta * theta;
+  /* Chebyshev polynomial of the form for sin:
+   * x+x^3*(S0+x^2*(S1+x^2*(S2+x^2*(S3+x^2*S4)))).
+   * 1.0+x^2*(C0+x^2*(C1+x^2*(C2+x^2*(C3+x^2*C4)))).  */
+  if ((n & 2) == 0)
+    {
+      sx = S3 + theta2 * S4;     /* S3+x^2*S4.  */
+      sx = S2 + theta2 * sx;     /* S2+x^2*(S3+x^2*S4).  */
+      sx = S1 + theta2 * sx;     /* S1+x^2*(S2+x^2*(S3+x^2*S4)).  */
+      sx = S0 + theta2 * sx;     /* S0+x^2*(S1+x^2*(S2+x^2*(S3+x^2*S4))).  */
+      /* x+x^3*(S0+x^2*(S1+x^2*(S2+x^2*(S3+x^2*S4)))).  */
+      sx = theta + theta * theta2 * sx;
+    }
+  else
+    {
+      sx = C3 + theta2 * C4;     /* C3+x^2*C4.  */
+      sx = C2 + theta2 * sx;     /* C2+x^2*(C3+x^2*C4).  */
+      sx = C1 + theta2 * sx;     /* C1+x^2*(C2+x^2*(C3+x^2*C4)).  */
+      sx = C0 + theta2 * sx;     /* C0+x^2*(C1+x^2*(C2+x^2*(C3+x^2*C4))).  */
+      /* 1.0 + x^2*(C0+x^2*(C1+x^2*(C2+x^2*(C3+x^2*C4)))).  */
+      sx = 1.0 + theta2 * sx;
+    }
+
+  /* Add in the signbit and assign the result.  */
+  return sign_sin * sx;
+}
+
+float
+SINF_FUNC(float x)
+{
+  double cx;
+  double theta = x;
+  double abstheta = fabs (theta);
+  /*  if |x|< Pi/4.  */
+  if (abstheta < M_PI_4)
+    {
+      if (abstheta >= +0.03125) /* |x| >= 2^-5.  */
+        {
+          double theta2 = theta * theta;
+          /* Chebyshev polynomial of the form for sin.  */
+          cx = S3 + theta2 * S4;
+          cx = S2 + theta2 * cx;
+          cx = S1 + theta2 * cx;
+          cx = S0 + theta2 * cx;
+          cx = theta + theta * theta2 * cx;
+          return cx;
+        }
+      else if (abstheta >= 0x1p-27)     /* |x| >= 2^-27.  */
+        {
+          /* A simpler Chebyshev approximation is close enough for this range:
+           * for sin: x+x^3*(SS0+x^2*SS1).  */
+          double theta2 = theta * theta;
+          cx = SS0 + theta2 * SS1;
+          cx = theta + theta * theta2 * cx;
+          return cx;
+        }
+      else
+        {
+          /* Handle some special cases.  */
+          if (theta)
+            return theta - (theta * SMALL);
+          else
+            return theta;
+        }
+    }
+  else                          /* |x| >= Pi/4.  */
+    {
+      unsigned long signbit = (x < 0);
+      if (abstheta < 9 * M_PI_4)        /* |x| < 9*Pi/4.  */
+        {
+          unsigned long n = (abstheta * inv_PI_4) + 1;
+          theta = abstheta - pio2_table[n / 2];
+          return reduced (theta, n, signbit);
+        }
+      else if (abstheta < INFINITY)
+        {
+          if (abstheta < 8388608.0)     /* |x| < 2^23.  */
+            {
+              unsigned long n = floor (abstheta * inv_PI_4) + 1.0;
+              double x = floor (n / 2.0);
+              theta = x * PI_2_lo + (x * PI_2_hi + abstheta);
+              /* Argument reduction needed.  */
+              return reduced (theta, n, signbit);
+            }
+          else                  /* |x| >= 2^23.  */
+            {
+              x = fabs (x);
+              int32_t exponent;
+              GET_FLOAT_WORD (exponent, x);
+              exponent =
+                (exponent >> FLOAT_EXPONENT_SHIFT) - FLOAT_EXPONENT_BIAS;
+              exponent += 3;
+              exponent = (exponent * (0x100000000 / 28 + 1)) >> 32;
+              double a = invpio4_table[exponent] * x;
+              double b = invpio4_table[exponent + 1] * x;
+              double c = invpio4_table[exponent + 2] * x;
+              double d = invpio4_table[exponent + 3] * x;
+              unsigned long l = a;
+              l &= ~0x7;
+              a -= l;
+              double e = a + b;
+              l = e;
+              e = a - l;
+              if (l & 1)
+                {
+                  e -= 1.0;
+                  e += b;
+                  e += c;
+                  e += d;
+                  e *= M_PI_4;
+                  return reduced (e, l + 1, signbit);
+                }
+              else
+                {
+                  e += b;
+                  e += c;
+                  e += d;
+                  if (e <= 1.0)
+                    {
+                      e *= M_PI_4;
+                      return reduced (e, l + 1, signbit);
+                    }
+                  else
+                    {
+                      l++;
+                      e -= 2.0;
+                      e *= M_PI_4;
+                      return reduced (e, l + 1, signbit);
+                    }
+                }
+            }
+        }
+      else
+        {
+          int32_t ix;
+          /* High word of x.  */
+          GET_FLOAT_WORD (ix, abstheta);
+          /* sin(Inf or NaN) is NaN.  */
+          if (ix == 0x7f800000)
+            __set_errno (EDOM);
+          return x - x;
+        }
+    }
 }
 
 #ifndef SINF