Message ID | 1507660725-7986-4-git-send-email-Dave.Martin@arm.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 36624 invoked by alias); 10 Oct 2017 18:39:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 36585 invoked by uid 89); 10 Oct 2017 18:39:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=10636 X-HELO: foss.arm.com From: Dave Martin <Dave.Martin@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>, Szabolcs Nagy <szabolcs.nagy@arm.com>, Richard Sandiford <richard.sandiford@arm.com>, Okamoto Takayuki <tokamoto@jp.fujitsu.com>, kvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org, linux-arch@vger.kernel.org Subject: [PATCH v3 03/28] arm64: efi: Add missing Kconfig dependency on KERNEL_MODE_NEON Date: Tue, 10 Oct 2017 19:38:20 +0100 Message-Id: <1507660725-7986-4-git-send-email-Dave.Martin@arm.com> In-Reply-To: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> References: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit |
Commit Message
Dave Martin
Oct. 10, 2017, 6:38 p.m. UTC
The EFI runtime services ABI permits calls to EFI to clobber certain FPSIMD/NEON registers, as per the AArch64 procedure call standard. Saving/restoring the clobbered registers around such calls needs KERNEL_MODE_NEON, but the dependency is missing from Kconfig. This patch adds the missing dependency. This will aid bisection of the patches implementing support for the ARM Scalable Vector Extension (SVE). Signed-off-by: Dave Martin <Dave.Martin@arm.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
On Tue, Oct 10, 2017 at 07:38:20PM +0100, Dave P Martin wrote: > The EFI runtime services ABI permits calls to EFI to clobber > certain FPSIMD/NEON registers, as per the AArch64 procedure call > standard. > > Saving/restoring the clobbered registers around such calls needs > KERNEL_MODE_NEON, but the dependency is missing from Kconfig. > > This patch adds the missing dependency. > > This will aid bisection of the patches implementing support for the > ARM Scalable Vector Extension (SVE). > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 0df64a6..ca711ac 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1063,6 +1063,7 @@ config EFI_STUB > config EFI > bool "UEFI runtime support" > depends on OF && !CPU_BIG_ENDIAN > + depends on KERNEL_MODE_NEON > select LIBFDT > select UCS2_STRING > select EFI_PARAMS_FROM_FDT We could've used select KERNEL_MODE_NEON since it's a feature needed by EFI but this works for me as well as KERNEL_MODE_NEON is def_bool y already. Either way: Acked-by: Catalin Marinas <catalin.marinas@arm.com>
On Wed, Oct 11, 2017 at 03:16:47PM +0100, Catalin Marinas wrote: > On Tue, Oct 10, 2017 at 07:38:20PM +0100, Dave P Martin wrote: > > The EFI runtime services ABI permits calls to EFI to clobber > > certain FPSIMD/NEON registers, as per the AArch64 procedure call > > standard. > > > > Saving/restoring the clobbered registers around such calls needs > > KERNEL_MODE_NEON, but the dependency is missing from Kconfig. > > > > This patch adds the missing dependency. > > > > This will aid bisection of the patches implementing support for the > > ARM Scalable Vector Extension (SVE). > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 0df64a6..ca711ac 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -1063,6 +1063,7 @@ config EFI_STUB > > config EFI > > bool "UEFI runtime support" > > depends on OF && !CPU_BIG_ENDIAN > > + depends on KERNEL_MODE_NEON > > select LIBFDT > > select UCS2_STRING > > select EFI_PARAMS_FROM_FDT > > We could've used select KERNEL_MODE_NEON since it's a feature needed by > EFI but this works for me as well as KERNEL_MODE_NEON is def_bool y > already. Either way: > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> Agreed. I assumed this is moot anyway, since KERNEL_MODE_NEON will rarely/never be deselected in practice. Cheers ---Dave
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 0df64a6..ca711ac 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1063,6 +1063,7 @@ config EFI_STUB config EFI bool "UEFI runtime support" depends on OF && !CPU_BIG_ENDIAN + depends on KERNEL_MODE_NEON select LIBFDT select UCS2_STRING select EFI_PARAMS_FROM_FDT