[1/1] Added country_isbn for Netherlands

Message ID 1504099943-37872-1-git-send-email-akhilesh.k@samsung.com
State Rejected
Delegated to: Mike Fabian
Headers

Commit Message

Akhilesh Kumar Aug. 30, 2017, 1:32 p.m. UTC
  [BZ #22043]
	* locales/fy_NL (LC_ADDRESS): Add country_isbn.
	* locales/li_NL (LC_ADDRESS): Add country_isbn.
	* locales/nds_NL(LC_ADDRESS): Fix country_isbn.
 	* locales/nl_NL (LC_ADDRESS): Add country_isbn.
---
 localedata/locales/fy_NL  |    1 +
 localedata/locales/li_NL  |    2 +-
 localedata/locales/nds_NL |    2 +-
 localedata/locales/nl_NL  |    1 +
 4 files changed, 4 insertions(+), 2 deletions(-)
  

Comments

Mike FABIAN Aug. 31, 2017, 6:52 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #22043]
> 	* locales/fy_NL (LC_ADDRESS): Add country_isbn.
> 	* locales/li_NL (LC_ADDRESS): Add country_isbn.
> 	* locales/nds_NL(LC_ADDRESS): Fix country_isbn.
>  	* locales/nl_NL (LC_ADDRESS): Add country_isbn.
> ---
>  localedata/locales/fy_NL  |    1 +
>  localedata/locales/li_NL  |    2 +-
>  localedata/locales/nds_NL |    2 +-
>  localedata/locales/nl_NL  |    1 +
>  4 files changed, 4 insertions(+), 2 deletions(-)

[...]

> --- a/localedata/locales/nds_NL
> +++ b/localedata/locales/nds_NL
> @@ -47,7 +47,7 @@ country_ab2 "<U004E><U004C>"
>  country_ab3 "<U004E><U004C><U0044>"
>  country_car "<U004E><U004C>"
>  country_num 528
> -country_isbn "3"
> +country_isbn "978-90,978-94"
>  lang_name "<U004E><U0065><U0064><U0064><U0065><U0072><U0073><U0061><U0073><U0073><U0069><U0073><U0063><U0068>"
>  %lang_ab
>  lang_term "<U006E><U0064><U0073>"

I am a bit confused about this ISBN stuff. 

The RangeMessage.xml file downloadable at

https://www.isbn-international.org/range_file_generation

has:

      <Prefix>978-3</Prefix>
      <Agency>German language</Agency>

and: 
      <Prefix>978-90</Prefix>
      <Agency>Netherlands</Agency>
      [...]
      <Prefix>978-94</Prefix>
      <Agency>Netherlands</Agency>

So I wonder whether the "3" in nds_NL was possibly not wrong because
nds is a German dialect. Is the country, Netherlands more important here
or the language? I have no idea.

And what about our de_CH, fr_CH, and it_CH locales? The RangeMessage.xml
file does not have anything for Switzerland, it has an entry for “German
language” but not for “French language” and not for “Italian language”
either. There are entries for “Italy” and “France” but are these
relevant for Switzerland?
  
Akhilesh Kumar Aug. 31, 2017, 10:24 a.m. UTC | #2
>> @@ -47,7 +47,7 @@ country_ab2 "<U004E><U004C>"
>>  country_ab3 "<U004E><U004C><U0044>"
>>  country_car "<U004E><U004C>"
>>  country_num 528
>> -country_isbn "3"
>> +country_isbn "978-90,978-94"
>>  lang_name "<U004E><U0065><U0064><U0064><U0065><U0072><U0073><U0061><U0073><U0073><U0069><U0073><U0063><U0068>"
>>  %lang_ab
>>  lang_term "<U006E><U0064><U0073>"
> 
>I am a bit confused about this ISBN stuff. 
> 
>The RangeMessage.xml file downloadable at
> 
>https://www.isbn-international.org/range_file_generation
> 
>has:
> 
>      <Prefix>978-3</Prefix>
>      <Agency>German language</Agency>

Yes I agree 3 is Language identifier for German Language 
https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups

>and: 
>      <Prefix>978-90</Prefix>
>      <Agency>Netherlands</Agency>
>      [...]
      <Prefix>978-94</Prefix>
      <Agency>Netherlands</Agency>
I took the reference from below link 
https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups

 
>So I wonder whether the "3" in nds_NL was possibly not wrong because
>nds is a German dialect. Is the country, Netherlands more important here
>or the language? I have no idea.

low(lands) saxon language is common in Netherlands and Germany but 3 identifier
Belong to German Language So i think 3 is probably wrong 

>And what about our de_CH, fr_CH, and it_CH locales? The RangeMessage.xml

for Switzerland i am unable to find ISBN identifier

>file does not have anything for Switzerland, it has an entry for “German

>language” but not for “French language” and not for “Italian language”

>either. There are entries for “Italy” and “France” but are these

>relevant for Switzerland?
  
Mike FABIAN Aug. 31, 2017, 2:07 p.m. UTC | #3
AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:

>>So I wonder whether the "3" in nds_NL was possibly not wrong because
>>nds is a German dialect. Is the country, Netherlands more important here
>>or the language? I have no idea.
>
> low(lands) saxon language is common in Netherlands and Germany but 3 identifier
> Belong to German Language So i think 3 is probably wrong 

Yes, probably using the ISDN of the Netherlands is more appropriate for
nds_NL. But I am not sure.

>>And what about our de_CH, fr_CH, and it_CH locales? The RangeMessage.xml
>
> for Switzerland i am unable to find ISBN identifier

Yes, that is what I wrote as well.

So I am not sure whether it is worth “fixing” these country_isdn tags
if we are not sure about what should go in there.

Are they even used at all? For what?
  
Akhilesh Kumar Sept. 1, 2017, 10:04 a.m. UTC | #4
>>
>> for Switzerland i am unable to find ISBN identifier
> 
 I think we can make “fixing” to "replaced Language to Language ISDN"

>Are they even used at all? For what?


Honestly speaking initially we had some marketing requirement to support unsupported locale in glibc 
But now I like to play locale 

regarding this As we know there is no identifier if countries fall in “language groups". Like (Australia, the United States, Canada, France, Austria, Switzerland...)
Same i observed on books (publisher's place with is country ISBN code or the language of the books it publishes).
SO i think For NL country ISBN is more useful then language identifier 

> 


Akhilesh
  

Patch

diff --git a/localedata/locales/fy_NL b/localedata/locales/fy_NL
index 3736401..bb58b7e 100644
--- a/localedata/locales/fy_NL
+++ b/localedata/locales/fy_NL
@@ -132,6 +132,7 @@  country_name "<U004E><U0065><U0064><U0065><U0072><U006C><U00E2><U006E>"
 country_ab2 "<U004E><U004C>"
 country_ab3 "<U004E><U004C><U0044>"
 country_num 528
+country_isbn "978-90,978-94"
 country_car "<U004E><U004C>"
 % Frysk
 lang_name    "<U0057><U0065><U0073><U0074><U002D><U0046><U0072><U0079><U0073><U006B>"
diff --git a/localedata/locales/li_NL b/localedata/locales/li_NL
index 169c5e3..2f3c288 100644
--- a/localedata/locales/li_NL
+++ b/localedata/locales/li_NL
@@ -48,7 +48,7 @@  country_ab2   "<U004E><U004C>"
 country_ab3   "<U004E><U004C><U0044>"
 country_car   "<U004E><U004C>"
 country_num 528
-%FIXME country_isbn "2"
+country_isbn "978-90,978-94"
 % Lèmbörgs
 lang_name    "<U004C><U00E8><U006D><U0062><U00F6><U0072><U0067><U0073>"
 lang_ab "<U006C><U0069>"
diff --git a/localedata/locales/nds_NL b/localedata/locales/nds_NL
index 5d65798..c985594 100644
--- a/localedata/locales/nds_NL
+++ b/localedata/locales/nds_NL
@@ -47,7 +47,7 @@  country_ab2 "<U004E><U004C>"
 country_ab3 "<U004E><U004C><U0044>"
 country_car "<U004E><U004C>"
 country_num 528
-country_isbn "3"
+country_isbn "978-90,978-94"
 lang_name "<U004E><U0065><U0064><U0064><U0065><U0072><U0073><U0061><U0073><U0073><U0069><U0073><U0063><U0068>"
 %lang_ab
 lang_term "<U006E><U0064><U0073>"
diff --git a/localedata/locales/nl_NL b/localedata/locales/nl_NL
index fa6d1fc..baca8e5 100644
--- a/localedata/locales/nl_NL
+++ b/localedata/locales/nl_NL
@@ -167,6 +167,7 @@  country_name "<U004E><U0065><U0064><U0065><U0072><U006C><U0061><U006E><U0064>"
 country_ab2 "<U004E><U004C>"
 country_ab3 "<U004E><U004C><U0044>"
 country_num 528
+country_isbn "978-90,978-94"
 country_car "<U004E><U004C>"
 % Nederlands
 lang_name    "<U004E><U0065><U0064><U0065><U0072><U006C><U0061><U006E><U0064><U0073>"