From patchwork Thu Aug 17 21:30:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 22202 Received: (qmail 427 invoked by alias); 17 Aug 2017 21:31:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 130622 invoked by uid 89); 17 Aug 2017 21:30:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: NAM03-DM3-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1503005428.2986.20.camel@cavium.com> Subject: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings From: Steve Ellcey Reply-To: sellcey@cavium.com To: libc-alpha Date: Thu, 17 Aug 2017 14:30:28 -0700 Mime-Version: 1.0 X-ClientProxiedBy: MWHPR21CA0026.namprd21.prod.outlook.com (10.175.142.140) To MWHPR07MB3550.namprd07.prod.outlook.com (10.164.192.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ac9a303-9e5b-4f13-94d2-08d4e5b72ffc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHPR07MB3550; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3550; 3:MYZD2CvZK99iqyEIc/L9kQ9ULmt+47jtyWuCtAo5QY+OlZPV0ARLYCxi6ihqtGcDbCQEvQmFxd765Olq6gdjH1vbu+0aUmovxTbKpdj4q/XOXl6q06+42pvmR2psc7ZbogLwu8XyuwE7PTJknwnJn+/aMqfWxPc6W9mlYQYFAF1/8iGvMV4YaAI0kvUa/07SF4BlypqXbIXhapEyEEalKhdOcJU25oC9JhPkV7qxYp+JMvGwpXmlh+JWcrSHPES1; 25:nYhiIgf0A1WlGfIIU8RWJwdRmV0qv6l9wGl4qir7Rxxw2DlZ82vyKYVI730Xbxw+RWJCgnrjp9Mkon9wBUX1wiestqOkn/r7BlQm2CBuGr/CHtOtQoXWRE9LMTvGiFwekHDwC9/HW8KeYBxXrbBNrL40TZ+UqvDnkADH0Sk1BWfffNDvOdlA36mUNV+OoUH5tUUsoQJZ9giACpR2gFYAZiZp4RDtaJJT8H7JCboF6Pbj0N8CrYf3CRa6k9RcgdIH/EumUbfyrnILMHkAFUmoYXdBsCUJcO5Dqo8iu8dpAAGdfUwn0FZHWkbDwT0+ybca2x2dcjp8V4+DzSTF3vslUA==; 31:Bjw/A673veONEDH1Pk0v5qMrgoMXVj8FhtnModfoeApwMDavP5V3wv2CDdnTsxySsgFDLvwNXy7+zm1lYDHViPt3M5DQzekcdne41gvZWbxIsgx5wGBOzhnOtm2bky5pS+58uBhApI46TDVT49lpPQsTCx1q09mjE6Bd5pkxqxLXCs9wKaMMa3PhhR5kDnwoM+bpqrON4VHTggZuJWuKR2IGXMLQ7cG90QZ4/tPo0xM= X-MS-TrafficTypeDiagnostic: MWHPR07MB3550: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3550; 20:KcxjJZQjk1k6snNZEwtdiwsOLQ1S8cWq6N6XfkS4MmWDi7Vx5NCzfPgqkLLbwmZ7aUnlDahhTHl3IaMdgSYWlKwAELlXI3/osSIynwveXVsUucIEf9aAAQCZHH3VafT+N3Dj/WeWMAU33uCXBMHhWITp1NJ9o+nA0l2xGNnrkYp+Or8qmKv2K1sFndkzq/DZQz/MksDQBs/SdnzvZpaYMWueOeLpzpalPFp8TfdB+p5rIkwN1Mc8yFd9SjkmqdGSBZKoys5EqGOiKp6PDa6bTpNIPda6mwO7z8MHjr7bf9wPbOAmxvE5MkIwq6HLve/Dt9NKCca0wjh8e0XwVJvkm/owCqmIKTCz9ZdD2xHK4yDE9GUpzwjVsd0EYVnOkA5wSbQgHxYc7pLzdWkRtd8NV6ArBPzwDxR1GyGFQuIJ6z5suk5afMN91mZY11ddEqWZx+guH8MFY5aAcdT4TawMjjnMgj0w7VzzeIrGu3Jp/pcqZRMLWbRxlzAnfdJyPod3; 4:EFkLYXcjT12fKwVHFpvleFakxcOjwqOyDJbm1GIADvO7SuAGrJ6hjHy63jGE0Cm7RAxmCO0S39ZrxLiQnf/fKvU1YuX+JnEtBDjlWjIfQUBWH20Jjr2RpuHrNYEuD7u23QKSUxsukoi8WOBgOKdK/AZxJ2x9HlaYWtWWGj+eroLKWRubV0ek4KKO3L674OOvAWW0hCDDlFbf2/CMd1Bhmbt1Hj0YbUmC8+q6uPlcmBELyVbPzVOTNtB9mmmDKj+97unAKEHMjn1uGOmtom5BaeaDDav90IsomcSnd9PlGnn8pPjc4V3QKyRY5J2Rmxz2wfqwS1trrIq9RA3RiLa9rQ== X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3550; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3550; X-Forefront-PRVS: 0402872DA1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(189002)(199003)(377424004)(53936002)(103116003)(50986999)(305945005)(5820100001)(6486002)(6666003)(6506006)(101416001)(110136004)(53416004)(43066003)(47776003)(66066001)(105586002)(5660300001)(551544002)(81166006)(81156014)(7736002)(69596002)(106356001)(33646002)(6306002)(8676002)(72206003)(6116002)(50226002)(6512007)(6916009)(3450700001)(42186005)(7350300001)(2870700001)(189998001)(50466002)(2906002)(36756003)(68736007)(23676002)(97736004)(478600001)(3846002)(966005)(25786009)(99106002)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3550; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA3TUIzNTUwOzIzOkRjVEhIQll3T2lYdnBEYUpKaWY3TkdCaDAx?= =?utf-8?B?TTZsdFBiY0lQaGcwV0Y0ZllCNHNhQldLdXh6c0NQU2FGemRHc2tFUWw5bnNK?= =?utf-8?B?UkV5bi9XMEJpS2lyVG1TM1orQTA3WCtsa2xBdU5tWXUvM0ExWHZKcWJPUHAr?= =?utf-8?B?c2lRc3lBODFKTmtJOXQvUzB6ODBWTmdXb3FTeDlKM25POHdMVGw4WHJlTGRu?= =?utf-8?B?OWxMVVFsbEtGTXJmSWlrRFlSTXdvUWZoQ2thVFA1OXp4aTZwRC9pRElkN0dj?= =?utf-8?B?VGJ5R3lwOGQ0cXUxT1V2YkNnQXIzUngxdGRYbnJxeXdoSVUvRjN4akdtZ0dq?= =?utf-8?B?M1V4UWFGZjAyYXAwVHR2eWdXbDVRdldVRzZQMlBFRGk1UUhGZFR0Wno3SmE2?= =?utf-8?B?U1lGM0kwazAvY1hxOWxPSElwT241eGhwZzg1TEVNQVZnZERUb21tUys2R2Zo?= =?utf-8?B?ZUdIR0xhQmc5MVhJZnBtM2NlNTVMTDhGblBmRGVZU3Yyb3Q0cDhMK1UvRk1P?= =?utf-8?B?QlVLZHhhU21CL1FlUldLUTA4akxLWVZTUnhqanRmTXMvK0RMRDc2NW1URm1U?= =?utf-8?B?bytDaFcyY2F2Zjh3VGNCcWYzM0dCSzErMklzQXVGNkk5R3ZzQkJTZEF1N0Rw?= =?utf-8?B?ZElWWlp3d3R4M3FPTVl5cCsycHVSdVVON0FrRUhMUlYzT3VIRE43WU5UODk2?= =?utf-8?B?b3ozajFwamZzSUVleGV0eVAzOVJneDh3d0hGb09nTGNmbFRwSjVvNlV4OTFl?= =?utf-8?B?bTBidGM2bk9taEcxc0U3WXhUUXhNaVJpbE1pVm1SNTMzQWRaSE5lMUlRVGo3?= =?utf-8?B?Nyt5NDBhWmd6SmRyUWM1alJjSFlJL3lpTnhxZ1FiaElNUmVueDRzazFjd1hq?= =?utf-8?B?TEZlTmVBZUc3OFoxRTdSTTVqK1dXZzQ1OURRV0xhQ3o1SWxKbHhWZUxkbGR2?= =?utf-8?B?UkFScTZ4OEFwL1VQMm9vbTJGU0lGZW9KMklVTTcvTXpXVzFFYWpFM1RDMkZo?= =?utf-8?B?WVNOaFdFekNyellBc2l3SEpOOHpUMzJmSzQyYzlCL1RGZ2VOQkNjbXdDMWtE?= =?utf-8?B?dksyeXFNTGViUVNSQ01PRXM4eWdvY1AzR3BDQStrTi9ibll4cExUYkhqSG4r?= =?utf-8?B?cVV4VEY5SlFBbStDdzRieVJEeHd1MHN6MkZseXlFTEZZd3dXNzE1L0IrQ0cw?= =?utf-8?B?bXRFbDRvdTFjdU9STkN0dG5vVWlrQTVBNXF2d01OYUo1T2lBQXYydWF6cVRI?= =?utf-8?B?ZEd6SExnaEYwL245OE9MV29qUDNwNStLUHlNNnRxZC9XMjVSN1NmTmZTTStQ?= =?utf-8?B?U25CT0tSeVpIWFpiNFhKNzNxcTZnTUszY2lRMk9QVGs5cTF0bFJIVVVUaFFD?= =?utf-8?B?QmkzTUo4d3lwY3B5eE5YNzRNLy9hTVEzQ3BsRjVYbjNDREZoeC9QNGRiUzdF?= =?utf-8?B?Wmg4NnR6ZXJPb1djVVdDNVcrdUZ4cUxCSWJ1UU12SytxcW9Od0VKRjRROGJa?= =?utf-8?B?OFlqaW9jTFl0TUk4ekNlTk9TNkxKS1ZzNVp0SUlnUzJNS2U4eFF4WnMvUGtJ?= =?utf-8?B?SHhRNVJGeklmeVdmeUdRanZEMG80Q2RlQUJObXJ5SVpWazR2VERmZ2R2cDVF?= =?utf-8?B?cGZLMGZibFdJMi95RnJmMlRjbW1WZ2htR0o1UFZoK2lSVnk1bVRMSm1EcDM1?= =?utf-8?Q?CtridsRy8Hlg5EM7HAAzyl3WVmYy/ACjTdx6xeg?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3550; 6:MmN5nHflMdsEhbaU9zS542ApqZgn4TNSSznRGQ5BRIou9iuz2ta9qC0Q2Wf7hNnbiSDc4XK0Hl5jEn/rEUMSOPYhoFXX2eTGmvIm2n8EXZxo/rRtzVI1hE6xaEE+UIu0fgO3iqlp0HNKnLjqKqmXGDzr4UZxanNapUlLn1n3T9aFZDqQ+lQ++9H8XYY69iy2HHzrsjClTOq6VLfBw1l1vlEcKq/Qk57Fo84Ac76z3aH9XwU8Ikps4Q6Jxc7Rj4NFLMKwdncXw5MTEQLn8wAP2CAD1SEMIOe6CviAQawzqr5M4Jga1z0AGJBVugH7C3fvsrB4fcw90Rxkgk6klnzOPQ==; 5:IZtc++a9w9E1TS0tGGSBkTUNh/YdktvhBaqeuuxVCPZfI9ut0REeM7Q0yBf8Z0nRUnFg9nKyUV8SJJwdKfWnRv5OPAbuirUDvfwQ7NPEwTzEQ7kcw88Ex+jShQAxs6C+Cta/2JwY6U3VTJ1fxmbaGg==; 24:OwyU+G7P6pfU0WSzVUGcuiqrP1sXQBFj6nkFvG1caTJC7WTCsvDwJcP8DDaP4JZVkqTSvcrfz9WKV+qh0rNKnRomZnjAfUrzZgTTA7zdFpE=; 7:RMc/d3hzYxgrSGF4Ovd6EdQW1Gn/B8L1Z2hehB7HPEkXWIGqxXKiubUVRJ7LHOs7CmEFHbT7ROBA4QC2xMH357V8Ho8EmqgZIAFoP5Gx9sFkvViVtjz71yly5wTKn9LDWplE+Q5TM3XELTTVj3DTD9hohnxFHLTuSGdU1Ks5SRu1LMJyI4mpa2Tmq57ucOvqBEpcvwcimQ+xPZYuNDIxM3WPdGSxHUTxx47FXAGzMzE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2017 21:30:31.2003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3550 This patch is based on the discussion string at: https://sourceware.org/ml/libc-alpha/2017-08/msg00531.html Basically a change was made to remove the nss compat lookup method by default from glibc.  It is available if glibc is configured with --enable-obsolete-nsl.  Some tests were still using the compat lookup method because DEFAULT_CONFIG still included that method in the files below.  Depending on how you test that might not cause any failures because if libnss_compat could not be found in the glibc build directories the dynamic linker would search the default host directories and pick it up from there, only if it couldn't find it in either place would the tests (grp/testgrp, nss/bug17079, posix/globtest, and pwd/tst-getpwfail) fail. This patch removes the compat lookup method from the DEFAULT_CONFIG strings.  Tested on x86 and aarch64 with no regressions. OK to checkin? 2017-08-17  Steve Ellcey   * nss/grp-lookup.c (DEFAULT_CONFIG): Remove compat method. * nss/pwd-lookup.c (DEFAULT_CONFIG): Likewise. * nss/spwd-lookup.c (DEFAULT_CONFIG): Likewise. diff --git a/nss/grp-lookup.c b/nss/grp-lookup.c index 8cb00aa..256d2af 100644 --- a/nss/grp-lookup.c +++ b/nss/grp-lookup.c @@ -17,6 +17,6 @@     .  */    #define DATABASE_NAME group -#define DEFAULT_CONFIG "compat [NOTFOUND=return] files" +#define DEFAULT_CONFIG "files"    #include "XXX-lookup.c" diff --git a/nss/pwd-lookup.c b/nss/pwd-lookup.c index 00040d4..8612c39 100644 --- a/nss/pwd-lookup.c +++ b/nss/pwd-lookup.c @@ -17,6 +17,6 @@     .  */    #define DATABASE_NAME passwd -#define DEFAULT_CONFIG "compat [NOTFOUND=return] files" +#define DEFAULT_CONFIG "files"    #include "XXX-lookup.c" diff --git a/nss/spwd-lookup.c b/nss/spwd-lookup.c index 319a7bb..2c866d1 100644 --- a/nss/spwd-lookup.c +++ b/nss/spwd-lookup.c @@ -18,6 +18,6 @@    #define DATABASE_NAME shadow  #define ALTERNATE_NAME passwd -#define DEFAULT_CONFIG "compat [NOTFOUND=return] files" +#define DEFAULT_CONFIG "files"    #include "XXX-lookup.c"