[1/1] Added New Locale en_SC
Commit Message
New locale is added for Seychelles which is a member of the African
Union and Official languages is English
[#BZ 21854]
* localedata/SUPPORTED : Added en_SC.UTF-8
* localedata/locales/en_SC: Added New File en_SC
---
localedata/SUPPORTED | 1 +
localedata/locales/en_SC | 120 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 121 insertions(+), 0 deletions(-)
create mode 100644 localedata/locales/en_SC
Comments
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> New locale is added for Seychelles which is a member of the African
> Union and Official languages is English
>
> [#BZ 21854]
> * localedata/SUPPORTED : Added en_SC.UTF-8
> * localedata/locales/en_SC: Added New File en_SC
>
Looks mostly OK, I’ll commit that with the following changes:
diff --git a/localedata/locales/en_SC b/localedata/locales/en_SC
index 387f9ca7f3..49800a83fe 100644
--- a/localedata/locales/en_SC
+++ b/localedata/locales/en_SC
@@ -13,7 +13,7 @@ escape_char /
LC_IDENTIFICATION
title "English locale for the Seychelles"
-source "Samsung Electronics Co., Ltd."
+source "Samsung Electronics Co., Ltd."
Fix trailing whitespace
address ""
contact ""
email "akhilesh.k@samsung.com"
@@ -52,11 +52,11 @@ END LC_COLLATE
LC_MONETARY
int_curr_symbol "SCR "
currency_symbol "SR"
-mon_decimal_point "<U002E>"
-mon_thousands_sep "<U002C>"
+mon_decimal_point "."
+mon_thousands_sep ","
Make it more readable by using ASCII.
mon_grouping 3;3
positive_sign ""
-negative_sign "<U002D>"
+negative_sign "-"
Make it more readable by using ASCII.
int_frac_digits 2
frac_digits 2
p_cs_precedes 1
@@ -88,12 +88,10 @@ END LC_PAPER
LC_TELEPHONE
% https://www.howtocallabroad.com/seychelles/
-% +%c %l
-tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U006C>"
+tel_int_fmt "+%c %l"
Make it more readable by using ASCII.
% 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda
-int_select "<U0030><U0030>"
-% 248
-int_prefix "<U0032><U0034><U0038>"
+int_select "00"
+int_prefix "248"
Make it more readable by using ASCII.
END LC_TELEPHONE
LC_MEASUREMENT
@@ -106,14 +104,15 @@ END LC_NAME
LC_ADDRESS
postal_fmt "%f%N%h%s%N%T"
-country_name "seychelles"
+country_name "Seychelles"
In English, country names start with a capital letter.
country_ab2 "SC"
country_ab3 "SYC"
country_num 690
-country_car "SYC"
+% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes
+country_car "SY"
I think "SYC" was wrong.
country_isbn "978-99931"
% English
-lang_name "<U0045><U006E><U0067><U006C><U0069><U0073><U0068>"
+lang_name "English"
Make it more readable by using ASCII.
lang_ab "en"
lang_term "eng"
lang_lib "eng"
> [#BZ 21854]
> * localedata/SUPPORTED : Added en_SC.UTF-8
> * localedata/locales/en_SC: Added New File en_SC
>
>Looks mostly OK, I’ll commit that with the following changes:
>
> diff --git a/localedata/locales/en_SC b/localedata/locales/en_SC
> index 387f9ca7f3..49800a83fe 100644
> --- a/localedata/locales/en_SC
> +++ b/localedata/locales/en_SC
> @@ -13,7 +13,7 @@ escape_char /
>
> LC_IDENTIFICATION
> title "English locale for the Seychelles"
> -source "Samsung Electronics Co., Ltd."
> +source "Samsung Electronics Co., Ltd."
>
>Fix trailing whitespace
>
> address ""
> contact ""
> email "akhilesh.k@samsung.com"
> @@ -52,11 +52,11 @@ END LC_COLLATE
> LC_MONETARY
> int_curr_symbol "SCR "
> currency_symbol "SR"
> -mon_decimal_point "<U002E>"
> -mon_thousands_sep "<U002C>"
> +mon_decimal_point "."
> +mon_thousands_sep ","
>
>Make it more readable by using ASCII.
>
> mon_grouping 3;3
> positive_sign ""
> -negative_sign "<U002D>"
> +negative_sign "-"
>
>Make it more readable by using ASCII.
>
> int_frac_digits 2
> frac_digits 2
> p_cs_precedes 1
> @@ -88,12 +88,10 @@ END LC_PAPER
>
> LC_TELEPHONE
> % https://www.howtocallabroad.com/seychelles/
> -% +%c %l
> -tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U006C>"
> +tel_int_fmt "+%c %l"
>
>Make it more readable by using ASCII.
>
> % 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda
> -int_select "<U0030><U0030>"
> -% 248
> -int_prefix "<U0032><U0034><U0038>"
> +int_select "00"
> +int_prefix "248"
>
>Make it more readable by using ASCII.
>
> END LC_TELEPHONE
>
> LC_MEASUREMENT
> @@ -106,14 +104,15 @@ END LC_NAME
>
> LC_ADDRESS
> postal_fmt "%f%N%h%s%N%T"
> -country_name "seychelles"
> +country_name "Seychelles"
>
>In English, country names start with a capital letter.
>
> country_ab2 "SC"
> country_ab3 "SYC"
> country_num 690
> -country_car "SYC"
> +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes
> +country_car "SY"
>
>I think "SYC" was wrong.
Agree
> country_isbn "978-99931"
> % English
> -lang_name "<U0045><U006E><U0067><U006C><U0069><U0073><U0068>"
> +lang_name "English"
>
>Make it more readable by using ASCII.
Thanks for Nice review, Integared all your review comments
Please find v2 patch
https://sourceware.org/ml/libc-alpha/2017-08/msg00155.html
@@ -147,6 +147,7 @@ en_NZ.UTF-8/UTF-8 \
en_NZ/ISO-8859-1 \
en_PH.UTF-8/UTF-8 \
en_PH/ISO-8859-1 \
+en_SC.UTF-8/UTF-8 \
en_SG.UTF-8/UTF-8 \
en_SG/ISO-8859-1 \
en_US.UTF-8/UTF-8 \
new file mode 100644
@@ -0,0 +1,120 @@
+comment_char %
+escape_char /
+
+% This file is part of the GNU C Library and contains locale data.
+% The Free Software Foundation does not claim any copyright interest
+% in the locale data contained in this file. The foregoing does not
+% affect the license of the GNU C Library as a whole. It does not
+% exempt you from the conditions of the license if your use would
+% otherwise be governed by that license.
+
+% Locale for English locale in the Seychelles
+% Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>
+
+LC_IDENTIFICATION
+title "English locale for the Seychelles"
+source "Samsung Electronics Co., Ltd."
+address ""
+contact ""
+email "akhilesh.k@samsung.com"
+tel ""
+fax ""
+language "English"
+territory "Seychelles"
+revision "1.0"
+date "2017-07-24"
+
+category "i18n:2012";LC_IDENTIFICATION
+category "i18n:2012";LC_CTYPE
+category "i18n:2012";LC_COLLATE
+category "i18n:2012";LC_TIME
+category "i18n:2012";LC_NUMERIC
+category "i18n:2012";LC_MONETARY
+category "i18n:2012";LC_MESSAGES
+category "i18n:2012";LC_PAPER
+category "i18n:2012";LC_NAME
+category "i18n:2012";LC_ADDRESS
+category "i18n:2012";LC_TELEPHONE
+category "i18n:2012";LC_MEASUREMENT
+END LC_IDENTIFICATION
+
+LC_CTYPE
+copy "en_GB"
+END LC_CTYPE
+
+LC_COLLATE
+
+% Copy the template from ISO/IEC 14651
+copy "iso14651_t1"
+
+END LC_COLLATE
+
+LC_MONETARY
+int_curr_symbol "SCR "
+currency_symbol "SR"
+mon_decimal_point "<U002E>"
+mon_thousands_sep "<U002C>"
+mon_grouping 3;3
+positive_sign ""
+negative_sign "<U002D>"
+int_frac_digits 2
+frac_digits 2
+p_cs_precedes 1
+int_p_sep_by_space 1
+p_sep_by_space 0
+n_cs_precedes 1
+int_n_sep_by_space 1
+n_sep_by_space 0
+p_sign_posn 1
+n_sign_posn 1
+%
+END LC_MONETARY
+
+LC_NUMERIC
+copy "en_GB"
+END LC_NUMERIC
+
+LC_TIME
+copy "en_GB"
+END LC_TIME
+
+LC_MESSAGES
+copy "en_GB"
+END LC_MESSAGES
+
+LC_PAPER
+copy "en_GB"
+END LC_PAPER
+
+LC_TELEPHONE
+% https://www.howtocallabroad.com/seychelles/
+% +%c %l
+tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U006C>"
+% 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda
+int_select "<U0030><U0030>"
+% 248
+int_prefix "<U0032><U0034><U0038>"
+END LC_TELEPHONE
+
+LC_MEASUREMENT
+copy "en_GB"
+END LC_MEASUREMENT
+LC_NAME
+copy "en_GB"
+END LC_NAME
+
+
+LC_ADDRESS
+postal_fmt "%f%N%h%s%N%T"
+country_name "seychelles"
+country_ab2 "SC"
+country_ab3 "SYC"
+country_num 690
+country_car "SYC"
+country_isbn "978-99931"
+% English
+lang_name "<U0045><U006E><U0067><U006C><U0069><U0073><U0068>"
+lang_ab "en"
+lang_term "eng"
+lang_lib "eng"
+END LC_ADDRESS