[1/1] Fix inconsistency in country_isbn and missing prefixes

Message ID 1500534329-23274-1-git-send-email-akhilesh.k@samsung.com
State Committed
Delegated to: Mike Fabian
Headers

Commit Message

Akhilesh Kumar July 20, 2017, 7:05 a.m. UTC
  [BZ #21797]
	* locales/et_EE   (LC_ADDRESS   : Fix country_post.
	* locales/hy_AM   (LC_ADDRESS)  : Fix country_post.

Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 localedata/locales/et_EE |    2 +-
 localedata/locales/hy_AM |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Mike FABIAN July 20, 2017, 8:32 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21797]
> 	* locales/et_EE   (LC_ADDRESS   : Fix country_post.
> 	* locales/hy_AM   (LC_ADDRESS)  : Fix country_post.
                                              ^ country_isbn
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/locales/et_EE |    2 +-
>  localedata/locales/hy_AM |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/localedata/locales/et_EE b/localedata/locales/et_EE
> index bdd8b07..4060d1a 100644
> --- a/localedata/locales/et_EE
> +++ b/localedata/locales/et_EE
> @@ -2242,7 +2242,7 @@ country_ab2     "<U0045><U0045>"
>  country_ab3     "<U0045><U0053><U0054>"
>  country_num     233
>  country_car     "<U0045><U0053><U0054>"
> -country_isbn    "<U0039><U0039><U0038><U0035>"
> +country_isbn    "9949,9985"

According to the RangeMessage.xml file one
can download at https://www.isbn-international.org/range_file_generation
, this should be

   country_isbn "978-9949,978-9985"

>  lang_name       "<U0065><U0065><U0073><U0074><U0069>"
>  lang_ab         "<U0065><U0074>"
>  lang_term       "<U0065><U0073><U0074>"
> diff --git a/localedata/locales/hy_AM b/localedata/locales/hy_AM
> index 521264d..a069ea5 100644
> --- a/localedata/locales/hy_AM
> +++ b/localedata/locales/hy_AM
> @@ -185,7 +185,7 @@ country_ab2 "<U0041><U004D>"
>  country_ab3 "<U0041><U0052><U004D>"
>  country_num 051
>  country_car "<U0041><U004D>"
> -country_isbn "<U0039><U0039><U0039><U0033><U0030>"
> +country_isbn "9939,99930,99941"

And according to
https://www.isbn-international.org/range_file_generation this should be:

    country_isbn "978-9939,978-99930,978-99941"

>  lang_name "<U0570><U0561><U0575><U0565><U0580><U0565><U0576>"
>  % hy
>  lang_ab      "<U0068><U0079>"

By the way, why are you fixing these country_isbn? What is country_isbn
in glibc used for??
  
Mike FABIAN July 25, 2017, 11:34 a.m. UTC | #2
Mike FABIAN <mfabian@redhat.com> wrote:

> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>> [BZ #21797]
>> 	* locales/et_EE   (LC_ADDRESS   : Fix country_post.
>> 	* locales/hy_AM   (LC_ADDRESS)  : Fix country_post.
>                                               ^ country_isbn
>> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
>> ---
>>  localedata/locales/et_EE |    2 +-
>>  localedata/locales/hy_AM |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/localedata/locales/et_EE b/localedata/locales/et_EE
>> index bdd8b07..4060d1a 100644
>> --- a/localedata/locales/et_EE
>> +++ b/localedata/locales/et_EE
>> @@ -2242,7 +2242,7 @@ country_ab2     "<U0045><U0045>"
>>  country_ab3     "<U0045><U0053><U0054>"
>>  country_num     233
>>  country_car     "<U0045><U0053><U0054>"
>> -country_isbn    "<U0039><U0039><U0038><U0035>"
>> +country_isbn    "9949,9985"
>
> According to the RangeMessage.xml file one
> can download at https://www.isbn-international.org/range_file_generation
> , this should be
>
>    country_isbn "978-9949,978-9985"
>
>>  lang_name       "<U0065><U0065><U0073><U0074><U0069>"
>>  lang_ab         "<U0065><U0074>"
>>  lang_term       "<U0065><U0073><U0074>"
>> diff --git a/localedata/locales/hy_AM b/localedata/locales/hy_AM
>> index 521264d..a069ea5 100644
>> --- a/localedata/locales/hy_AM
>> +++ b/localedata/locales/hy_AM
>> @@ -185,7 +185,7 @@ country_ab2 "<U0041><U004D>"
>>  country_ab3 "<U0041><U0052><U004D>"
>>  country_num 051
>>  country_car "<U0041><U004D>"
>> -country_isbn "<U0039><U0039><U0039><U0033><U0030>"
>> +country_isbn "9939,99930,99941"
>
> And according to
> https://www.isbn-international.org/range_file_generation this should be:
>
>     country_isbn "978-9939,978-99930,978-99941"
>
>>  lang_name "<U0570><U0561><U0575><U0565><U0580><U0565><U0576>"
>>  % hy
>>  lang_ab      "<U0068><U0079>"

committed with the above changes.
  

Patch

diff --git a/localedata/locales/et_EE b/localedata/locales/et_EE
index bdd8b07..4060d1a 100644
--- a/localedata/locales/et_EE
+++ b/localedata/locales/et_EE
@@ -2242,7 +2242,7 @@  country_ab2     "<U0045><U0045>"
 country_ab3     "<U0045><U0053><U0054>"
 country_num     233
 country_car     "<U0045><U0053><U0054>"
-country_isbn    "<U0039><U0039><U0038><U0035>"
+country_isbn    "9949,9985"
 lang_name       "<U0065><U0065><U0073><U0074><U0069>"
 lang_ab         "<U0065><U0074>"
 lang_term       "<U0065><U0073><U0074>"
diff --git a/localedata/locales/hy_AM b/localedata/locales/hy_AM
index 521264d..a069ea5 100644
--- a/localedata/locales/hy_AM
+++ b/localedata/locales/hy_AM
@@ -185,7 +185,7 @@  country_ab2 "<U0041><U004D>"
 country_ab3 "<U0041><U0052><U004D>"
 country_num 051
 country_car "<U0041><U004D>"
-country_isbn "<U0039><U0039><U0039><U0033><U0030>"
+country_isbn "9939,99930,99941"
 lang_name "<U0570><U0561><U0575><U0565><U0580><U0565><U0576>"
 % hy
 lang_ab      "<U0068><U0079>"