From patchwork Wed Jun 21 05:52:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajalakshmi S X-Patchwork-Id: 21155 X-Patchwork-Delegate: tuliom@linux.vnet.ibm.com Received: (qmail 10947 invoked by alias); 21 Jun 2017 05:56:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 116072 invoked by uid 89); 21 Jun 2017 05:55:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KHOP_DYNAMIC, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: Rajalakshmi Srinivasaraghavan To: libc-alpha@sourceware.org Cc: Rajalakshmi Srinivasaraghavan Subject: [PATCHv2] powerpc: Add optimized version of [l]lroundf Date: Wed, 21 Jun 2017 11:22:43 +0530 X-TM-AS-MML: disable x-cbid: 17062105-0044-0000-0000-0000027137A3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062105-0045-0000-0000-00000700E988 Message-Id: <1498024363-5326-1-git-send-email-raji@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-21_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=4 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706210095 This patch makes use of optimized double version of llround for single precision as both the versions return [long] long type. 2017-06-21 Rajalakshmi Srinivasaraghavan * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile (libm-sysdep_routines): Add s_llroundf-ppc64. * sysdeps/powerpc/powerpc64/power5+fpu/s_llround.S (__llroundf): Define as strong alias of __llround. (llroundf): Define as weak alias of __llround. (__lroundf): Define as strong alias of __llround. (lroundf): Define as weak alias of __llround. * sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S: Likewise. * sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise. * sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S: New file. * sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c: Likewise. * sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S: Likewise. * sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S: Likewise. * sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S: Likewise. --- sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile | 2 +- .../powerpc64/fpu/multiarch/s_llroundf-ppc64.S | 32 +++++++++++++++ .../powerpc/powerpc64/fpu/multiarch/s_llroundf.c | 46 ++++++++++++++++++++++ sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S | 7 ++++ sysdeps/powerpc/powerpc64/power5+/fpu/s_llroundf.S | 1 + sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S | 7 ++++ sysdeps/powerpc/powerpc64/power6x/fpu/s_llroundf.S | 1 + sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S | 7 ++++ sysdeps/powerpc/powerpc64/power8/fpu/s_llroundf.S | 1 + 9 files changed, 103 insertions(+), 1 deletion(-) create mode 100644 sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S create mode 100644 sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c create mode 100644 sysdeps/powerpc/powerpc64/power5+/fpu/s_llroundf.S create mode 100644 sysdeps/powerpc/powerpc64/power6x/fpu/s_llroundf.S create mode 100644 sysdeps/powerpc/powerpc64/power8/fpu/s_llroundf.S diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile index 317a988..d6f14f3 100644 --- a/sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile @@ -24,7 +24,7 @@ libm-sysdep_routines += s_isnan-power7 s_isnan-power6x s_isnan-power6 \ s_modff-power5+ s_modff-ppc64 e_hypot-ppc64 \ e_hypot-power7 e_hypotf-ppc64 e_hypotf-power7 \ s_isnan-power8 s_isinf-power8 s_finite-power8 \ - s_llrint-power8 s_llround-power8 \ + s_llrint-power8 s_llround-power8 s_llroundf-ppc64 \ e_expf-power8 e_expf-ppc64 \ s_sinf-ppc64 s_sinf-power8 \ s_cosf-ppc64 s_cosf-power8 diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S new file mode 100644 index 0000000..26d08a2 --- /dev/null +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf-ppc64.S @@ -0,0 +1,32 @@ +/* llroundf(). PowerPC64 default version. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#undef weak_alias +#define weak_alias(a,b) +#undef strong_alias +#define strong_alias(a,b) +#undef compat_symbol +#define compat_symbol(a,b,c,d) + +#define __llroundf __llroundf_ppc64 +#define __lroundf __lroundf_ppc64 + +#include diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c new file mode 100644 index 0000000..1e34b5d --- /dev/null +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_llroundf.c @@ -0,0 +1,46 @@ +/* Multiple versions of llroundf. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ +/* Redefine lroundf/__lroundf so that the compiler won't complain about + the type mismatch with the IFUNC selector in strong_alias below. */ +#define lroundf __hidden_lroundf +#define __lroundf __hidden___lroundf + +#include +#undef lroundf +#undef __lroundf +#include "init-arch.h" + +extern __typeof (__llroundf) __llroundf_ppc64 attribute_hidden; +extern __typeof (__llroundf) __llround_power6x attribute_hidden; +extern __typeof (__llroundf) __llround_power8 attribute_hidden; + +/* The ppc64 ABI passes float and double parameters in 64bit floating point + registers (at least up to a point) as IEEE binary64 format, so effectively + of "double" type. Both l[l]round and l[l]roundf return long type. So these + functions have identical signatures and functionality, and can use a + single implementation. */ +libc_ifunc (__llroundf, + (hwcap2 & PPC_FEATURE2_ARCH_2_07) + ? __llround_power8 : + (hwcap & PPC_FEATURE_POWER6_EXT) + ? __llround_power6x + : __llroundf_ppc64); + +weak_alias (__llroundf, llroundf) +strong_alias (__llroundf, __lroundf) +weak_alias (__lroundf, lroundf) diff --git a/sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S b/sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S index 4f9f850..ec42993 100644 --- a/sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S +++ b/sysdeps/powerpc/powerpc64/power5+/fpu/s_llround.S @@ -45,6 +45,13 @@ ENTRY_TOCLESS (__llround, 4) strong_alias (__llround, __lround) weak_alias (__llround, llround) weak_alias (__lround, lround) +/* The double version also works for single-precision as both float and + double parameters are passed in 64bit FPRs and both versions are expected + to return [long] long type. */ +strong_alias (__llround, __llroundf) +weak_alias (__llround, llroundf) +strong_alias (__lround, __lroundf) +weak_alias (__lround, lroundf) #ifdef NO_LONG_DOUBLE weak_alias (__llround, llroundl) diff --git a/sysdeps/powerpc/powerpc64/power5+/fpu/s_llroundf.S b/sysdeps/powerpc/powerpc64/power5+/fpu/s_llroundf.S new file mode 100644 index 0000000..c3f27b6 --- /dev/null +++ b/sysdeps/powerpc/powerpc64/power5+/fpu/s_llroundf.S @@ -0,0 +1 @@ +/* __lroundf is in s_llround.S. */ diff --git a/sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S b/sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S index 6d1db55..d58b338 100644 --- a/sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S +++ b/sysdeps/powerpc/powerpc64/power6x/fpu/s_llround.S @@ -41,6 +41,13 @@ ENTRY_TOCLESS (__llround) strong_alias (__llround, __lround) weak_alias (__llround, llround) weak_alias (__lround, lround) +/* The double version also works for single-precision as both float and + double parameters are passed in 64bit FPRs and both versions are expected + to return [long] long type. */ +strong_alias (__llround, __llroundf) +weak_alias (__llround, llroundf) +strong_alias (__lround, __lroundf) +weak_alias (__lround, lroundf) #ifdef NO_LONG_DOUBLE weak_alias (__llround, llroundl) diff --git a/sysdeps/powerpc/powerpc64/power6x/fpu/s_llroundf.S b/sysdeps/powerpc/powerpc64/power6x/fpu/s_llroundf.S new file mode 100644 index 0000000..c3f27b6 --- /dev/null +++ b/sysdeps/powerpc/powerpc64/power6x/fpu/s_llroundf.S @@ -0,0 +1 @@ +/* __lroundf is in s_llround.S. */ diff --git a/sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S b/sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S index 8bdc162..1dc5142 100644 --- a/sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S +++ b/sysdeps/powerpc/powerpc64/power8/fpu/s_llround.S @@ -35,6 +35,13 @@ END (__llround) strong_alias (__llround, __lround) weak_alias (__llround, llround) weak_alias (__lround, lround) +/* The double version also works for single-precision as both float and + double parameters are passed in 64bit FPRs and both versions are expected + to return [long] long type. */ +strong_alias (__llround, __llroundf) +weak_alias (__llround, llroundf) +strong_alias (__lround, __lroundf) +weak_alias (__lround, lroundf) #ifdef NO_LONG_DOUBLE weak_alias (__llround, llroundl) diff --git a/sysdeps/powerpc/powerpc64/power8/fpu/s_llroundf.S b/sysdeps/powerpc/powerpc64/power8/fpu/s_llroundf.S new file mode 100644 index 0000000..c3f27b6 --- /dev/null +++ b/sysdeps/powerpc/powerpc64/power8/fpu/s_llroundf.S @@ -0,0 +1 @@ +/* __lroundf is in s_llround.S. */