From patchwork Tue Jun 13 19:06:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 20995 Received: (qmail 91006 invoked by alias); 13 Jun 2017 19:06:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89903 invoked by uid 89); 13 Jun 2017 19:06:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:115 X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1497380813.13346.115.camel@cavium.com> Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64 From: Steve Ellcey Reply-To: sellcey@cavium.com To: Szabolcs Nagy , Steve Ellcey , Joseph Myers Cc: nd@arm.com, libc-alpha Date: Tue, 13 Jun 2017 12:06:53 -0700 In-Reply-To: <593FABC2.7020108@arm.com> References: <1487781046.2866.153.camel@caviumnetworks.com> <1487879964.2866.181.camel@caviumnetworks.com> <1487980010.2866.198.camel@caviumnetworks.com> <593A60B1.6090100@arm.com> <593A7CEC.2040001@arm.com> <593E6999.6050405@arm.com> <1497284101.13346.104.camel@cavium.com> <593EC0AE.8070906@arm.com> <593FABC2.7020108@arm.com> Mime-Version: 1.0 X-ClientProxiedBy: MWHPR2201CA0024.namprd22.prod.outlook.com (10.174.164.37) To DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-MS-Office365-Filtering-Correlation-Id: c98ecd8b-f28e-4930-311b-08d4b28f5c79 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:/QPySkdkpF4RpxqXdMrOiSNjkXJP58MfpDVW4G68vFVsTL8GmmoO49rE7OBK5HIRLyXNSxX017m+SKu6ECzB38CrW/9074dqEqKU4EjPMr6Sodr0IuSQbDTr7EP4UGAyGJgWW84cXg5FVXR0iYkodNf+3MlWOvBbpq+0feqJF/2i7bDz0xqyauv2c97JAtOnssF8dZVxIQJIEGd3GXOczr0/Mj3xmwLO58QitbN4SNU1d+Mf6dStbFYjgwLf7IPuTudWQH3yTAhQfze3G4AEDqyW2dhA2gKS/SjYhQcpCNrCWUxz36XryK6G4g6aCN0nDJnfy+ri1ucvxTXup5rNHA==; 25:eaSIUST7pr9VWL4Az56l946tMjGmbi0fr8korHNKXadHkDVTcaXCT+EdWrBXQ2ah9wDtYDv2iZ05N13DFQXfGsqZAP5xnV7qUVIm2/TSSHYYHWg8R14+MYaQnCRfAi8Yd+ZKl+oVDB2j/YSDhrydO3KmTDTAlm6GItQWmd0nJG+lHPFwZl1QgteYtV5VfcLSgtj1tEIJaYAP6Mdq9cDdY4SnUFZeqh8odsaHyuURb9ag7TaSYni0KZGO0xEzp5QLAn28fjPGuq3HVQKyJM/qrg53tko42ibitYAJ/JF4TEEwTa0TxEdsRPu2MgR+m55MBW1OxIkM4Qdmma5wrYJmrWDKJYtG/2EhW4A6BeisIVS6Qa8Yp14qB7345yR/amzxe8AQTW8E71epi9eBr/z23SLm44Iz6f75HHVBwYhq3bzteqVWPwjRU2lzZiFyi71UXlbL4ZS1G176/LjOeIXA78KES33ZvJnnP6ZGFvi5zYg= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 31:kOzrdK8PRpn+qlzSELlk0G5YmCjXgxCDofpWRA5tIFw9H7FFspBwp84xrTNErIKfiZ6zc0hu8SKGnRDiNgskqM7hnE5eIn+/rXIcyNGKcjDxWDm/C2pMkNJwxuoymUJHWtwHqdcAHfRf711ZCps/p3CSmDxs4PdH2Igm3XJOhA5cHXTjQrYTrW5IcoiFRmDbGiLgHPR1Dlf8BbKXWM795vzy+S0J2gAIeQ+tEAcr0oU=; 20:xhFJpIr01dbqVY4Db4RvOUgaiE6+TDfHnoROQFzRXWd7PvVi24oKqoq91L+dRDD9KZHIWXbhpDLmGzvl+0vNprBWDP7UccRidfnL8b4VlKGCD9KyhmpdAIN5KwPhD/VlPCru02BQqUdqEq/oAnEf4oCG9YJXrD/iyE86k/znY3WCRdxzMaRZsbWxz0R6OteacTmgNu0IlHI32JkYbP2FuT8Vy763KWcqi2Kp82nBfThRy5vQkOV7Y60CLnfYlzPH2zngXxlU1wDFP3d9kIJ50S23OQ+nR5Dt21/DEdPSvEYr/n5vZFFAyjvy+OKxsrNYlqvQdYURCVx25rv+lA7CJXH7oeMnYb+C2zNZ9vhScnPjMhrOOKCSXH6kwpUY+HzKc0SQyuDqOZC+6LhP1Bit91RsIUIxUwqzycI4drn7zOLzpsfGIMmwNBd3bGnzzC5EftjjHjgKKYaayMm2LcPHct+l8i7+TrJp7VTP058Vn0DpWqFAHA+/DNoZwJ2wwsaR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzNDY1OzQ6dkV1VVFCUnVFSko2TVF0R1RVN29MWmNqcVdp?= =?utf-8?B?eGlhUlZYUXgvMkpIM1d1UmFwMCt2UGg3VVpzbFMxbCtTNVpETDRWWlFMcFlM?= =?utf-8?B?L0RpY3lvRkxjcmE1K3Y4ZzlDem9FUk9GSnFSQjcveEEyU0h1NmhUeG5vbkZw?= =?utf-8?B?QkdMdC9tWHFqSjVuZEE4Nit4YnkwRVBBUHFGTmcrSjUycndheDd1Mzc3MlVt?= =?utf-8?B?WjlWVTNWUTVaMmJ0VmpjU3NUbWtsRHJiY0ZEdGQ2TGx1VkFEREF0MkJlYVh0?= =?utf-8?B?cnlBNkFuSHAwYWVLR1BDTjFmYkJQeDB6SGI5L3hQS05oVWNrRjROUllhQ0ts?= =?utf-8?B?R01FWlJvOHVCcEp2YnA5TmsrczdGbkN5UTJhTGRKVVpmRzlaU0NNVDd6Q05W?= =?utf-8?B?YTdwVW16YVBLdXJ3eUJpay90T0FtWC92MnRNQTVFeURnRkJVOFNDRWxTYkty?= =?utf-8?B?TG9vcjh5MEkyWlovZHRWeGphR3RSZjh4RmFVM0JDVFdmQkFvNTNhS01BdWM0?= =?utf-8?B?YXo4aC9mSHFpZ1Z3OHFQU3RBWG9YS25BQjViWmR5N3N1TVdSNVNqMUFKdkhp?= =?utf-8?B?MkkwYnRveHBhSkM0ZUJELzJWbEZOQmJkd3VmR291elYzckVNVHBEaDdGSERH?= =?utf-8?B?UFlrRTczNEVkdEVnTzhVTXJEaTlVaFFWRDFZaExOeXp1emFFOU13VWt0RXJI?= =?utf-8?B?ZmZqcm92YVh4SnlML0hHSDZjbkNSK1dSRWhubzdXLzF5MWxqNDg4N2tSdFhr?= =?utf-8?B?VU1icGFtNnJMRGNaMXk2dG5HeHE5cGtrMWVHRlo1WmZITTNqWGduMkwwdnlx?= =?utf-8?B?K1VOY1NZTHRRMVpjRVlwbFRwN1ZWTzlkbU13czgwNUExejJaRHZ3UThtSUZ2?= =?utf-8?B?czA1aDY2MFpqUzhlQlVRZlZvZ0NNT0kvSUFmWnpHNzRTYVpVMGM3SzBqdEJi?= =?utf-8?B?UGF3Rkpndk16UnI3V1hPSnZZRjRyQU5lOXNyb1FOMXZoZUJleUFqbnVxYWJY?= =?utf-8?B?OUNjY0JMTmp5U245WHV2d2RUSm05cU9EVysyUFRNanM2Q0NpMzI4ZWtwRGR0?= =?utf-8?B?aittQnVOajZwSDhPN3FnMHRJb2FzOU1kTGdFci9lejMzY0hoaDVHb1lpL01T?= =?utf-8?B?TWJJb0cxM05wcG5HYnZQdUNEclZSWUEzazhjYmNRZ2VLWng0SVJoWmF3bmNH?= =?utf-8?B?QjBEZnFYazhkcitaT1dHNkprZWkrWktJc01JRzFlbkJENkNHWmxiS01GR0R6?= =?utf-8?B?RTZ2VHJTejZ6SEJRci9CWTFFSk43dThNaFFGcjY1VnRwR2x1VExYeHhQSkNu?= =?utf-8?B?ZzlvQkhqa0NqSDlUY25IdVdRUXQraitxL1NPZXlKZGpBUlBUcjQ5ci9CRVpC?= =?utf-8?B?dndIUzVUYUphcXJRd2g1bGg0QlNMdi9lSWNibXlFYVN6bjVuK3I5ckxoRTln?= =?utf-8?B?aTJOQ29qSUEzM2xJUytXdXE5QmdacVVBNVFLZ2dJWXZlYkR6eTdxTCt3Vmcx?= =?utf-8?Q?Z98q7bP/HhuiBfaNnK215sDo2E/kUyG3ns36WDZZ1ePSZ?= X-Forefront-PRVS: 0337AFFE9A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39840400002)(39410400002)(39400400002)(39850400002)(189002)(24454002)(377424004)(199003)(105586002)(6486002)(25786009)(189998001)(2950100002)(53936002)(33646002)(81166006)(50226002)(8676002)(97736004)(81156014)(6116002)(38730400002)(6666003)(3846002)(6246003)(106356001)(23676002)(50466002)(2906002)(2870700001)(4326008)(68736007)(103116003)(50986999)(47776003)(5660300001)(5820100001)(229853002)(36756003)(53416004)(76176999)(478600001)(101416001)(93886004)(305945005)(3450700001)(6512007)(43066003)(66066001)(6506006)(72206003)(42186005)(69596002)(7736002)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzNDY1OzIzOmFiR1V3Ym1vWUNZOUVRR1Nob0VWOU16OG81?= =?utf-8?B?QUtxeEN4Y2V0Y0VMR21sODZGMmZtMXVlSGtmdUJvdWNNbXdNWmdxWnRGa2M1?= =?utf-8?B?czJVbUVJRXl4M1Yvb2owNFo5SXhTaHJ4eVZ3NjNRRXR2TmtGT0pHL0lJR0pB?= =?utf-8?B?ZCtpazJyRzZMWjdkYkc1WjJGY2lZWld2b21OSUhiTDdWdjF5ZTNjYXNrODA1?= =?utf-8?B?WXlVaTJEbnFlSmUxKzBpMWZqK2twYmt3YmdkdGhPVUtaOEp0cGp2b2d0L3RW?= =?utf-8?B?NWUxdU92WlNUU3VGTEg3Nkw0Q0ErR1JlY2Q1dXFXUno1bTBENHpraGZqMzJw?= =?utf-8?B?UmRrK2hXeks4ZlRpUzc4L3NxQ1VyT3ZoQWVneDduRkxmWGhGa3V0dy9LMlhN?= =?utf-8?B?Vk1UZmJWVndVeXJmcFgrcm02SURZWmZONUE5S2cxS0FvUXRHL3hqUGxNMUx2?= =?utf-8?B?S0ZTc2F6b0VQMlYxS2p6bmU5eVhINXZqdVpobjlDL25TMnQ0TEdRNjArSUg3?= =?utf-8?B?MklyTzc1Q3JyK1NkTFUxT2M2NUdJengrVisvRW0yVGtwZTZGR3FXMjdua3Rs?= =?utf-8?B?OFVyYnFvck5VYld5OTE0cXJLc1dyRnF1R0F5ZnpTMkRLZS9hREhhZWZadERD?= =?utf-8?B?WWJBUi9BZzVSSCtZY1ZNSElqREYvVDd0bm5HOVdhTFBHRzFoRjdTeEVrc0cy?= =?utf-8?B?K0krVUtJTHN2SXlvaWdOVGU0SWFVK3hERi9rNnY1ekZHVk9qM0NhbkltZFFY?= =?utf-8?B?ZkR4LzgybjRjT0RCamtaMU0xSW9tM25FRUJxL1Q0QlFRMnpHc1BWNjZKaW5T?= =?utf-8?B?YXhtOC8vSkx5Sm1VNmg3YmV5ZlViQXgwVEVSMjB0aHQ0YXhnWGF4bGk3ME5D?= =?utf-8?B?aDdGY20xUXB0ZDNQVHhwQTF6b0RJMlFKbzFHVW5lK1JPdUZRRUxxdEMxSVdv?= =?utf-8?B?WUcyK0tSdE9BZnFxNDBpU0hGWUxvUk5vLzA4cUM4WFNNaFkvUzJoZG1XVWYr?= =?utf-8?B?TzZEZkY2N3c1Zk9IOWhjMmFrZDE4SDF4WDVQZXBXTk1tS1hESXB5NUVNZTFF?= =?utf-8?B?RUtlajNtYndzcnZHUWhWNVBVM3NITGgya1hSek5OeUcxUjVJMFZnQlprT0Zq?= =?utf-8?B?MHpHdmRNWVgwNTBmRVBWTUJjR284Sk0vWWlWSnlkYnoxNmhqSmh4NjM5cjFs?= =?utf-8?B?UzlrTUdsdmswWENSNFNhYy92WmZudkVIVjR1b2Z6a2VkcWc4OFIzNDZ5ZUNU?= =?utf-8?B?aXB6RFVlYmFXUjVHRk90L0xxZExNVXpHc2M0NFJET2h5TGJRV0x1N1poNGRE?= =?utf-8?B?OTl2VGNGTk9vbTltbUp1SE50QkJQbnJCWVBFVjRCNXdsWnY2R0JRVWRKd2Fl?= =?utf-8?B?cTZ2QmEyNHhSRkVGV1NQSGoxR1hIajRhYVJMeTM2NmRKbjUyMWZHSkNDVEdk?= =?utf-8?B?Z3YxSjN4czROK29VeE5odXRCbXRuNEtKTklCYUpuSUhDNFE5T094WXVkWlMx?= =?utf-8?B?ZGoxMk0wRmtqZlI0ZEdrZGJWMHNTR3gwODloeGVIZ01kTkJsZDFRY2hlbWdr?= =?utf-8?B?dmxmSkVTNVd5TS9hRmxWM2FRY1NDUWtNbXNjQ2ZjM3R6SmNMbEZUSElDb05w?= =?utf-8?B?NUliWjduUXpnSFMrRXJzTjhZVEFEV1NvcUdBQXYvNTRNUVRueWp2d2trYVpX?= =?utf-8?B?QWxBbjIvRXhuUFpMVlNrYkNSQXFoZTIzNEZyY1JOUm5VSW43REVPY205TTF4?= =?utf-8?B?WkowSHd0N1ZIZjhjOGtrWG5NZVN5UWZtaHFqU0x6WG5UaXNKNGVJU0Y1U2ow?= =?utf-8?B?RHFzeHdTRHR3UjREbU9QOWU4RGcwVDJSbDA1VHhabE82cVcxbkowZGhjRVY4?= =?utf-8?Q?mCYDz9alYGfILsDoiERfKVm6K4zwcziw?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:x8xCDDi67X9unKpWdjXkXadPm98n8/O6Ym+qJJO189JCznYra5zcXd/XZYS7Zi9R8pBzeVX6mLB6z7DhIXY5YkR7vlODorYEDEQ9iPjThaFu5uOrBo89/hjrltVxKqcrMKc4+i4WM0QLp4U0PcBTaxcMre8u8po6gvzYIxe6omlced2W83ic6U9jM7AnzpHzPuXLgswpspf5VCkCfJgvhHc3aYVgR6nJj1TUlYA6szKcVpXfqjR1O3wBr57o58NdXoqb+ejVbX/TueB7o6MrW+8Jtcex2+y3aKy3od3snY4LLLVTa8usbErDqX9sQwb7RCTpdeubRngfBsRq9JjmbZWTcQIMI/Ven7Zb8Rw5oLx5hxdwu5OHpmejZWC39Zg7oDALMW+pCCTy1kvR4WQDYixsRBAQkrc3/svlYYTJYU/rg6UXyJyP0U5cceKDd8Rchq1qhcL5VGwDC/MidQYil77kwgsoo4AJyVZYQfKG70hQM6+PAmWLhXftKYrmvmyBHhagVsRHl7PCUvrxsvKtvg== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 5:uGZ6dDfsOuHm2AXRckfCXx26tZAg3zg8mChY/mc4SU9LRrZM+VCvF94YZt55hmmpkMgpr4el9qcM4Pa4iPCouezQEo6eoLKeZabX3Z/pqp6Z3drvZ9PJh78O0tijuR3vHqf9mXUE98cp0MnaYLKDErorG7fH521lfWw04tVSwCtN99GrXMFdp4BT2Wup/FAFWwGoh/HdAzqCdHOQB0lb4Q79pyOU2c2bY6EynpJgwQBpEVfvRvjj9XiQ5+0z9AZgxc5oUttYLft91ltZ/CZFTPaK277/mS+VN92A8OxGEolpfvFDhLXdmrTVQTeE0khwcKrbMBpW6w0fNeeMTnEGJI7dNVMx6ZLPx2IMFlKBWhMDwn0Pb6xTr8rBgvKm5OhV+jfC15Kg5zgQwAM5VRdN/W5mQR7tsVDRI2Ftj8lfW+Wa9IRHVoTeJUPXaaFx4a15oc3ekmsLs9ZaywaoKvv1YkDCReDX9mXKKQBugnQO0W0q0MqHXlds2RWYZF0iT5QU; 24:Fhlj9fYJvwC03m7a6EQdWqHUmQL82ed2JiAyGNJ46EqulcVTyHpPbpH1swlSsRTbMM5tL4rai1uLC7oDd3P7XkhgRRpd+fdW1S1B5KMFEcU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 7:twJos63jHQLdN637rqK1C9V9i/ZDuWL6yR3dAnsv6C15qqsw87BZOoPJ0oll1rGyEQavuVfFRbA2D0XHx7jACAqy7mISz9dkUalgoILSII0gmDSwWTK2vPbg/aJm2lM6uLg0E64T2RFVNpN2+d0RGvj38PJm7oFq8ARpbbLK1UuNC5t2tkSe9mdZMcI5Z94p+m91t6/cGV5UqsjCDIAr5rLIW1jZrFCmvN64Rh8ImNIwQQNLIMsPLw04Pc85OYWoFsCt5o9ItIXKms2VRX+ZhgcoJpXtul6x7pBiYNFCRFnYEfTPq+JMNLn5zWkj+Bd+akbwzq6cJMIWNuLe/nVAGg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2017 19:06:56.2440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 On Tue, 2017-06-13 at 10:09 +0100, Szabolcs Nagy wrote: >  > FAIL: nptl/tst-initializers1 > FAIL: nptl/tst-initializers1-c11 > FAIL: nptl/tst-initializers1-c89 > FAIL: nptl/tst-initializers1-c99 > FAIL: nptl/tst-initializers1-gnu11 > FAIL: nptl/tst-initializers1-gnu89 > FAIL: nptl/tst-initializers1-gnu99 I took a look at these failures and saw that __PTHREAD_RWLOCK_INT_FLAGS_SHARED is only being set when in 64 bit mode.  I updated sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h to define this macro and that fixed these failures.  I will include that change in my next patch submission (currently waiting on the kernel patches). Steve Ellcey sellcey@cavium.com % git diff sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h diff --git a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h index d13a75d..9aa9f04 100644 --- a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h +++ b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h @@ -65,5 +65,6 @@ struct __pthread_rwlock_arch_t  };    #define __PTHREAD_RWLOCK_ELISION_EXTRA 0 +#define __PTHREAD_RWLOCK_INT_FLAGS_SHARED 1    #endif /* bits/pthreadtypes.h */