[08/13] posix: Consolidate Linux fsync syscall
Commit Message
This patch consolidates the fsync Linux syscall generation on
sysdeps/unix/sysv/linux/fsync.c. It basically removes it from
architectures auto-generation list.
For arm it also removes the __errno_location call since fsync
is not called with SYSCALL_CANCEL with call arch-specific
INLINE_SYSCALL macro which in turn will call __set_errno macro
(and setting errno directly).
Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32,
arch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu,
sparc64-linux-gnu, and sparcv9-linux-gnu.
* misc/Makefile (CFLAGS-fsync.c): New flag.
* nptl/Makefile (CFLAGS-fsync.c): Likewise.
* sysdeps/unix/syscalls.list (fsync): Remove from auto-generation
syscall list.
* sysdeps/unix/sysv/linux/fsync.c: New file.
* sysdeps/unix/sysv/linux/arm/localplt.data [libpthread.so]
(__errno_location): Remove.
---
ChangeLog | 8 ++++++++
misc/Makefile | 1 +
nptl/Makefile | 1 +
sysdeps/unix/syscalls.list | 1 -
sysdeps/unix/sysv/linux/arm/localplt.data | 1 -
sysdeps/unix/sysv/linux/fsync.c | 28 ++++++++++++++++++++++++++++
6 files changed, 38 insertions(+), 2 deletions(-)
create mode 100644 sysdeps/unix/sysv/linux/fsync.c
Comments
On Friday 12 May 2017 11:28 PM, Adhemerval Zanella wrote:
> This patch consolidates the fsync Linux syscall generation on
> sysdeps/unix/sysv/linux/fsync.c. It basically removes it from
> architectures auto-generation list.
>
> For arm it also removes the __errno_location call since fsync
> is not called with SYSCALL_CANCEL with call arch-specific
> INLINE_SYSCALL macro which in turn will call __set_errno macro
> (and setting errno directly).
>
> Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32,
> arch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu,
> sparc64-linux-gnu, and sparcv9-linux-gnu.
>
> * misc/Makefile (CFLAGS-fsync.c): New flag.
> * nptl/Makefile (CFLAGS-fsync.c): Likewise.
> * sysdeps/unix/syscalls.list (fsync): Remove from auto-generation
> syscall list.
> * sysdeps/unix/sysv/linux/fsync.c: New file.
> * sysdeps/unix/sysv/linux/arm/localplt.data [libpthread.so]
> (__errno_location): Remove.
LGTM.
Siddhesh
@@ -110,6 +110,7 @@ CFLAGS-err.c = -fexceptions
CFLAGS-tst-tsearch.c = $(stack-align-test-flags)
CFLAGS-msync.c = -fexceptions
CFLAGS-fdatasync.c = -fexceptions
+CFLAGS-fsync.c = -fexceptions
# Called during static library initialization, so turn stack-protection
# off for non-shared builds.
@@ -219,6 +219,7 @@ CFLAGS-write.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-nanosleep.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-msync.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-fdatasync.c = -fexceptions -fasynchronous-unwind-tables
+CFLAGS-fsync.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-pt-system.c = -fexceptions
@@ -19,7 +19,6 @@ fchmod - fchmod i:ii __fchmod fchmod
fchown - fchown i:iii __fchown fchown
fcntl - fcntl Ci:iiF __libc_fcntl __fcntl fcntl
fstatfs - fstatfs i:ip __fstatfs fstatfs
-fsync - fsync Ci:i __libc_fsync fsync
ftruncate - ftruncate i:ii __ftruncate ftruncate
getdomain - getdomainname i:si getdomainname
getgid - getgid Ei: __getgid getgid
@@ -5,7 +5,6 @@ libc.so: memalign
libc.so: raise
libc.so: realloc
libm.so: matherr
-libpthread.so: __errno_location
libpthread.so: raise
# The dynamic loader needs __tls_get_addr for TLS.
ld.so: __tls_get_addr
new file mode 100644
@@ -0,0 +1,28 @@
+/* Synchronize a file's in-core state with storage device Linux
+ implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <unistd.h>
+#include <sysdep-cancel.h>
+
+/* Make all changes done to FD actually appear on disk. */
+int
+fsync (int fd)
+{
+ return SYSCALL_CANCEL (fsync, fd);
+}