From patchwork Mon Mar 27 20:53:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 19738 Received: (qmail 96392 invoked by alias); 27 Mar 2017 20:53:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 96378 invoked by uid 89); 27 Mar 2017 20:53:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1490644, H*MI:sk:1490644, H*i:sk:1490644 X-HELO: NAM02-CY1-obe.outbound.protection.outlook.com Authentication-Results: gotplt.org; dkim=none (message not signed) header.d=none;gotplt.org; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <1490647988.19074.94.camel@caviumnetworks.com> Subject: Re: [PATCH v3] Add random memcpy test From: Steve Ellcey To: Siddhesh Poyarekar , Wilco Dijkstra , "libc-alpha@sourceware.org" Cc: nd , Szabolcs Nagy Date: Mon, 27 Mar 2017 13:53:08 -0700 In-Reply-To: <1490644674.19074.88.camel@caviumnetworks.com> References: <139a1878-1b85-1af9-011d-5045bda6fd88@gotplt.org> <1490392173.19074.60.camel@caviumnetworks.com> <1490393681.19074.67.camel@caviumnetworks.com> <81e573fa-9ec7-8097-46a9-a46f50631366@gotplt.org> <1490644674.19074.88.camel@caviumnetworks.com> Mime-Version: 1.0 X-ClientProxiedBy: CY4PR04CA0042.namprd04.prod.outlook.com (10.172.133.28) To BY2PR07MB2437.namprd07.prod.outlook.com (10.166.115.17) X-MS-Office365-Filtering-Correlation-Id: beaa3ed6-d80c-4c3c-8c4f-08d4755347d8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR07MB2437; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 3:1gUQbP95SlG6Ho2SHUXT2gLyr4DcSc+0w/JTCv9k8V/2IuLxVoia7RI4FpgNucr8FW2L6lsR7Rk/4fBeqr+wVG1xq3yot5ffwGYRPYkM6GChgluD3YGwVJt0Lbg9fsJ8gJDDEuS19DRqKaxOOrQ6oqAb/zHB52mJVgPmafVzaT2VLYqEbyBJrQ4X9EZAAaL+Y3Ws+g3lnKE9cUXDooXTU9djHl01bNwNLaJNWPldBmWYkVogJyJ2TjsDI/UOSKzFQzS0tMux6u+RAn/8L+4V5A==; 25:fWyfQlXIWiegzWryW9xMZw8sG7t1mVfUOVz3jvZo54foctAeZ5sqCdjvZuOIjg3YgFmHCCridM+isrCji6eqxDYRDMbCVybxaKdhnYN4ywUbERsGEq2ezdwHDn7RjWMWhnIvau0Dwn0p5oQXjSpn4ih8KVWsGZMgm8jtAv8C/ZZ2gKdri8wDCABUffN/z3rQGJPsATvxY4J1H15P/+HmM819sVQRUdKPgGC96YLu4NCAsddJ7sQUaKKz4THbFhvaRQNNRmo0hSkhByzWzHZ/MAWIqzaP8ddur0QNByXEK7kztL5qCcaZcxLpjIB+8ZOF/jHrE4kWhUPZ0RiWXTGXcAkBEsppuAV09hQSXc4woCjgzCg5ID4fTHKtVDJ31Oc10lsGeOs5h7nBxOcxN8cbXsYpZM4XceP3LNrTeeUkOZtEnux00h9VctYmFm9HVo4Z1ILnfBi2M/cVBanpfa0WVebo0ds1m3ox3GU07xVGdHxl90vNI3cGdbdlPefHSNKe X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 31:eHgNvT3Y/e1ENEfGjF2/esAGxgpQXQOC0A3EFOjsmAi21fICKhHQ8HCCEfFF9wJDo2NsZSC7PIRrNFeKWFENqC6lT7pHZAuQFowZjJb9YZB3fAP9ABy0gdaqax0errDvMwdT+qgXkKTejD26+VAOQgFtRlq4XeaOHHTqJkICYdDZuVbSK9NvzibnklOdvtMP0t35z5LQ9sKP8TckvWHN2B2jG1RVEAB80Pw907Vc6RsyGR6mAZqoVD3/C7jl62CFUGhcCIIjdZdS4cHZtONBAorq2PKhem34uQW7zlyeyf3adaFMRPJD1Dc0NkVPStjJq/JOA0zb5HI0IhxktOKSiQ== X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 20:Xh5DCmtdZ+Yx9F5C8s8jrN6bqr7yG3eoEcGaV6aY2p9juWG/aftyJg1nHja+kmPp2TDmcHifJADuNump9HxqfVxk3oQ6pv/znuB3zk3/cmdiCgcJF5Oh1Yv8w1BlYRmyuZ5ur1RiH4gSPVxLvKKUf+suHvqRIexCSan26SWuHEAJW8Jy7+P6h37QDUAnDsSLNcSxpvPeMuV79NU6CL2Ep3OaD0yJ8JZ3TigQ1BSIImo4d8c38UY5dFafCWPcxusZCKdKsOe4pw9GbBq/1XBupGtTovP7hJNuvlrdHwqTA9b032lQNPl1ja/rtEhP47qt8NPtdxkAbmHbEJOGubuhqCiATbOjPwf0rskoIQ52y1IehgderrWGvftgIcU5Xn4xb6r7pOHXDKUswYUAwvEGHIuKf5cmrBJ71jJj4ubMeuDSMpfbTiul17mErrzuIAVW62jW9I4thePGaGO10QlbiXUyMHKDnoo1h6kBsq45TWezew3UanuHGOxU8G9Q++rAzCr5YNJwLYlxIEhxzfk9NC7mkNb3siMohwG6sv3KAyM9TakpkAcy8G/FBG80SCL8owgeQMXhU9A93mrO8w1HowohHZ5NNY3ND6UV62hO+Tc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415395)(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123558025)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:BY2PR07MB2437; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB2437; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 4:Go0hUwiXZ85Y+9N/qx1H6bZK4RmM3111H4AojF02hszbfcla0IuS/LOv9WOHklMWVPVUEqyPSDtIGkFUTpXxPiRpRQQGpp6GilBUfCxRTKVTrHhNQmUhJOGalZkwjzT+jdjixnxYvl8RNd2P0qPqC6ZLMUw0wmdII2In5W2HK3+LJaaSN1V1y72w4C9AgVn2/ydNnI3sTu6u8BQaiKNz9V96Yj2wEC2hKSTi6OnyjL7950K8HcVwerL/0L9lQN8QBdFFOQewC2C9rHEO8l2j4KFs1bYHVX87HdBo/498VLq8tSjnIs9NcvR6JmjTN5rJoM3+eo/clTpV+5atKUQ0/rlEehgxKYJPxEitAQipmNSE9HlsdJBQEZCMVLFfAM5XHaJbwZe+f4P/5k7CTxDON1W8TMtO40bIItiPRGiMAjQLcY6SnlZ9/RUWXs0h4T+I2f56n/7F+B3IvMMwfWCkBO/QBd4A6A55za62Q5gXzsWle+CjYVMPt3f6DTCDgoAZlWN2fG2TgGhyDg6JUxEx7wTJd71q2jPX6KbpLaFqPjQSb3Kuaci3ddJ+/hqx3awWmabxb+4HAYyF30q4AWVlfJYfi5xijTM+MO/kk1zz95edUNprwHpGtY02WEYEdzPd X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39450400003)(39410400002)(24454002)(377424004)(568964002)(5890100001)(50226002)(81166006)(8676002)(305945005)(5660300001)(33646002)(3846002)(7736002)(6116002)(53416004)(54906002)(2501003)(42186005)(6512007)(21490400002)(53936002)(229853002)(36756003)(2476003)(93886004)(66066001)(38730400002)(6246003)(4326008)(189998001)(2906002)(50986999)(76176999)(6506006)(42882006)(2950100002)(6666003)(6486002)(84326002)(4610100001)(103116003)(25786009)(512874002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB2437; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB2437; 23:JSaDvTDUNmUQQ7wVm24e1W9OWAU9teTkDgE3aneZO?= =?us-ascii?Q?lFr3+q2tM/Npp4ktGLXY4AjwI55x5A9HSgc7o80BuyHnLZPvaTuV2DJxgdti?= =?us-ascii?Q?id8uFovgRNBLP8kSQTmausgpgZgfsQAYb27prm7axWK14CdMmGIDXHEieNEO?= =?us-ascii?Q?20v7zZWPcwg/dsZ7W556DnXdIL6oUcmxjPWpPAUgWGHQ/I95GUM5yR/ynrQJ?= =?us-ascii?Q?99azL7Qtn2/d34XNrRjlkhTdZh/BWvpoacTIlrbmtqUbdT5BlB+kxwTYcD1+?= =?us-ascii?Q?QiWXgniguHGuXJX6BbBzYkWy+l/VJxluIpeuhCjl/eihrHGw5H5/1szKppY/?= =?us-ascii?Q?zBlkarA6ddIHDraKp2PwPURS2QSx0Jl8RGoI9e1NECMUj7B/PTAlMMyL+mhl?= =?us-ascii?Q?IfpUmSukFhH1/yqfTl1ECULk0pDTSrh+J9zK3wjKY66PsdomgNHgrWDsxnuh?= =?us-ascii?Q?ty8bbOQguyJqAWOzmxCALuL8Kr3QG44qU+o7NkvdIE3QM/pJhq1JMRr2hMvm?= =?us-ascii?Q?PAdFBUFknJ7NBn0gZdXIh71WFU2Bjgw9wqR6fKgPOx04wZnGdYZjWz7Cn3uy?= =?us-ascii?Q?532mUdL7mSs42KM53BBzayVjD0DnNM7IxADBrlBHtq0ITG2u4YSNU43/l3I9?= =?us-ascii?Q?/ahGrPz5hH/yPQeFR18eJiMfX/duJ+biku91Oua7i9Xx6VzNKvKF8X9OUhCH?= =?us-ascii?Q?2FHza89hdJVthRr225PwWlcIcmu0bzFgWqrna9ogjnf7PgRq0bpEeNLb+AvD?= =?us-ascii?Q?Z0Cq1PAtrUgMwF3sK4f8f35q28kaC0xNUnLd/bCqb/NmRXSFFGOxpmBk+it1?= =?us-ascii?Q?2BdqwNtYy5rSr552AyKissxQrw2o3yiq1vlEI2CQ/Cx0aEZ4mtyQQyFt9SEk?= =?us-ascii?Q?pnw1lwZ+hu/nNmQEhfE7gte8Pj5SrsddvkcxKwQ79bvVB4uMu77V/tnbqdIl?= =?us-ascii?Q?xg5QfiIxjdklObToltGaTtBAGHCsKu8BAHDFmoVMUm12PeNL8RYD3efF8Sjr?= =?us-ascii?Q?rpWtZUFptjl2+jLWfFCQEcLbcqqZdBqE3E1jZm1OQpiK3+xcgm2es9RdEqe4?= =?us-ascii?Q?lJqN07DfE4oWq3+VuE8vc5nrLbT4/FUvIJUAN1TwGypStqFyOCjbbGjzAYbG?= =?us-ascii?Q?kvOZZK8A+/AveCXZL+giKQm/QKdgU75FRNnpTJBUYjaEnTnaEhYNg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 6:eNZBwtVA2Ki9t8Fh6u2bu68tWlOvqW5mnrF/vuiOhRrsYr57hF0WcsA7+sQ54VzbFX5DCJD6dFvEBLEaziNX8VGD1YF1yzCr95bbiPFqtTnKaIDHVgqNRx1cAZZTjZ57z8rzwE4GU+pUd4SCkN6Wesx1dZnUQ5sES9BB3GOe+hg1pqQCEtAAcSLG8K+3YH9CiBT0PGBvv5OJQrEkDO2LxqBArkvQIhZaO5ntghXWpQGSqO3U1bY0x1TDPNG2GCIuw+XroYzHD1NBxy7iiKrKKp850hCoPegTuk9loogZIG5TJRICg/vmqcopvnKC6vMBY84xwKu8u4fQ5q7I7J1h8fNGqMAizFFe02U4BT7DXe3S7mAr6a2TNc4M9ntjo3dvgh/74Fi6ZK/DU2dywLu7Kw==; 5:NxaLaXW7OWDcRNTbbTsohB+QyoFGpJfOzsc2fFNPf2xfxiGaBuB2ELrHF9P8eBStG7rFsaJZDBGLo0DAgDIesjHdRZa4AYzlbp/00Vm/xgRHz71QwmvG+UiVoskWFsXJAKaptAdq2PsOAP1AEjGs5A==; 24:2jSApIOIRghBAFhtRuBoOPc1qFLSZk2X8O67m1amRSGnSNvmtdgEoHHaCNJAjisleN6zYZ4Ceix+rNzG8BqKGK+uxTHVrUw0cZYZnQ8oSZU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 7:ffjW7rO3yHJPZjVPg7d0fj6eZrYtPzC9CHPe2zlAFzHAJ86G34c5PjqpIdjjyC/t4+vzkgdd9G2zVqbqzuQuseUN8uXa0rUfgfM8TXOR72ObvKwu7jggYZ+d7vY+adA129iqgu/mv7Jib7zSERzbg0EwceXWXTYte7xroqsCtnWo1reVdg0Dwim906Mc1llM72rPXyE8qrs1sOUglyXzBTFicDyl3y4ZBCpSXu48yLtC5we5Ql+2VVC2sz4k+1BCRhj3APoxDdKVLzozJE8QvhFXzG7CDQeLCRlzsKCagET0ug9NrWWUo923E9FnSi9J33jbcxQwKqMOPH7To9iaoA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 20:53:11.0018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB2437 On Mon, 2017-03-27 at 12:57 -0700, Steve Ellcey wrote: >  > I see the bench-memcpy-random.c file now but I think there is still > something wrong.  I am using a glibc that has my aarch64 IFUNC version > of memcpy and memmove implemented in it but I do not get measurements > of the different implementations for the random memcpy test like I do > for the other two memcpy tests. Here is a patch so that bench-memcpy-random.c prints out timings for all the IFUNC versions of memcpy.  The TEST_NAME change is clear, TEST_NAME isn't really the name of the test but the name of the routine being tested.  If you call it memcpy-random it looks for IFUNC versions of the memcpy-random function instead of the memcpy function.  I also changed the IMPL call to have 1 instead of 0 as the second argument.  I don't really understand this change, but it is what the other two memcpy tests do so I copied them and it seems to work.  Tested on x86 and aarch64. Steve Ellcey sellcey@cavium.com 2017-03-27  Steve Ellcey   * benchtests/bench-memcpy-random.c (TEST_NAME): Change to memcpy. (IMPL) Call with 1 instead of 0 as argument. diff --git a/benchtests/bench-memcpy-random.c b/benchtests/bench-memcpy-random.c index 4cd6209..9ae925e 100644 --- a/benchtests/bench-memcpy-random.c +++ b/benchtests/bench-memcpy-random.c @@ -18,11 +18,11 @@ #define MIN_PAGE_SIZE 131072 #define TEST_MAIN -#define TEST_NAME "memcpy-random" +#define TEST_NAME "memcpy" #include "bench-string.h" #include -IMPL (memcpy, 0) +IMPL (memcpy, 1) #define NUM_COPIES 4096