From patchwork Mon Nov 14 16:55:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Metcalf X-Patchwork-Id: 17461 Received: (qmail 75803 invoked by alias); 14 Nov 2016 16:56:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 75780 invoked by uid 89); 14 Nov 2016 16:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=__END_DECLS, __end_decls, sysdep_routines, Contributed X-HELO: mellanox.co.il From: Chris Metcalf To: Joseph Myers , libc-alpha@sourceware.org Cc: Chris Metcalf Subject: [PATCH] Make tile's set_dataplane API compatibility-only Date: Mon, 14 Nov 2016 11:55:45 -0500 Message-Id: <1479142545-13207-1-git-send-email-cmetcalf@mellanox.com> In-Reply-To: The set_dataplane() API in originally supported the Tilera version of Linux as shipped to our customers. Once we started upstreaming the dataplane support in the kernel, the API changed to use fcntl() as part of the current task-isolation patch series. It doesn't seem like continuing to support the old API is useful for newly-compiled code, and even supporting the old glibc binary API on an upstream kernel that supports the new task isolation mode isn't straightforward, since the semantics have changed in ways that make it hard to map the old semantics precisely to the new ones, so just return ENOSYS. --- 2016-11-14 Chris Metcalf * sysdeps/unix/sysv/linux/tile/set_dataplane.c (__old_set_dataplane): Rename from set_dataplane and make a compatibility symbol. * sysdeps/unix/sysv/linux/tile/sys/dataplane.h: Remove file. * sysdeps/unix/sysv/linux/tile/Makefile (sysdep_headers): Remove sys/dataplane.h. sysdeps/unix/sysv/linux/tile/Makefile | 3 +-- sysdeps/unix/sysv/linux/tile/set_dataplane.c | 8 +++++-- sysdeps/unix/sysv/linux/tile/sys/dataplane.h | 33 ---------------------------- 3 files changed, 7 insertions(+), 37 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/tile/sys/dataplane.h diff --git a/sysdeps/unix/sysv/linux/tile/Makefile b/sysdeps/unix/sysv/linux/tile/Makefile index 43acea363350..04605a69acde 100644 --- a/sysdeps/unix/sysv/linux/tile/Makefile +++ b/sysdeps/unix/sysv/linux/tile/Makefile @@ -8,8 +8,7 @@ sysdep_headers += sys/reg.h sysdep_headers += sys/cachectl.h sysdep_routines += cacheflush -# Control dataplane properties of current thread. -sysdep_headers += sys/dataplane.h +# Control dataplane properties of current thread (compatibility only). sysdep_routines += set_dataplane endif diff --git a/sysdeps/unix/sysv/linux/tile/set_dataplane.c b/sysdeps/unix/sysv/linux/tile/set_dataplane.c index 5a4bffe4f311..e2ea896e88d0 100644 --- a/sysdeps/unix/sysv/linux/tile/set_dataplane.c +++ b/sysdeps/unix/sysv/linux/tile/set_dataplane.c @@ -23,9 +23,9 @@ #include #endif -/* Request dataplane modes from the kernel. */ +/* Request dataplane modes from the kernel (compatibility only). */ int -set_dataplane (int flags) +__old_set_dataplane (int flags) { #ifdef __NR_set_dataplane return INLINE_SYSCALL (set_dataplane, 1, flags); @@ -34,3 +34,7 @@ set_dataplane (int flags) return -1; #endif } + +#if SHLIB_COMPAT (libc, GLIBC_2_12, GLIBC_2_25) +compat_symbol (libc, __old_set_dataplane, set_dataplane, GLIBC_2_12); +#endif diff --git a/sysdeps/unix/sysv/linux/tile/sys/dataplane.h b/sysdeps/unix/sysv/linux/tile/sys/dataplane.h deleted file mode 100644 index 82677f1f5f13..000000000000 --- a/sysdeps/unix/sysv/linux/tile/sys/dataplane.h +++ /dev/null @@ -1,33 +0,0 @@ -/* Copyright (C) 2011-2016 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by Chris Metcalf , 2011. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#ifndef _SYS_DATAPLANE_H -#define _SYS_DATAPLANE_H 1 - -#include - -/* Get the kernel definition for the flag bits. */ -#include - -__BEGIN_DECLS - -extern int set_dataplane (int flags); - -__END_DECLS - -#endif /* sys/dataplane.h */