Fix arg used as litteral suffix in tst-strfrom.h

Message ID 1478716612-2570-1-git-send-email-gftg@linux.vnet.ibm.com
State Committed
Headers

Commit Message

Gabriel F T Gomes Nov. 9, 2016, 6:36 p.m. UTC
  The macro ENTRY in tst-strfrom.h is used to generate the input values for
each floating-point type (float, double, long double).  It should append
the parameter LSUF (Literal suffix) to the floating-point number, but is
using CSUF (C function suffix).  This patch fixes it.

Tested for powerpc64le and x86_64.

2016-10-28  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>

	* stdlib/tst-strfrom.h (ENTRY): Replace use of CSUF with LSUF.
---
 stdlib/tst-strfrom.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Gabriel F T Gomes Dec. 12, 2016, 7:50 p.m. UTC | #1
Ping.

On Wed,  9 Nov 2016 16:36:52 -0200
"Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> wrote:

> The macro ENTRY in tst-strfrom.h is used to generate the input values for
> each floating-point type (float, double, long double).  It should append
> the parameter LSUF (Literal suffix) to the floating-point number, but is
> using CSUF (C function suffix).  This patch fixes it.
> 
> Tested for powerpc64le and x86_64.
> 
> 2016-10-28  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
> 
> 	* stdlib/tst-strfrom.h (ENTRY): Replace use of CSUF with LSUF.
> ---
>  stdlib/tst-strfrom.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stdlib/tst-strfrom.h b/stdlib/tst-strfrom.h
> index 31a6492..75be55f 100644
> --- a/stdlib/tst-strfrom.h
> +++ b/stdlib/tst-strfrom.h
> @@ -36,7 +36,7 @@
>  #define STRUCT_FOREACH_FLOAT_FTYPE GEN_TEST_STRTOD_FOREACH (FTYPE_MEMBER)
> 
>  #define ENTRY(FSUF, FTYPE, FTOSTR, LSUF, CSUF, ...)  \
> -   CONCAT (__VA_ARGS__, CSUF),
> +   CONCAT (__VA_ARGS__, LSUF),
>  /* This is hacky way around the seemingly unavoidable macro
>   * expansion of the INFINITY or HUGE_VAL like macros in the
>   * above.  It is assumed the compiler will implicitly convert
  
Rajalakshmi S Dec. 13, 2016, 5:07 a.m. UTC | #2
On 12/13/2016 01:20 AM, Gabriel F. T. Gomes wrote:
> Ping.
>
> On Wed,  9 Nov 2016 16:36:52 -0200
> "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> wrote:
>
>> The macro ENTRY in tst-strfrom.h is used to generate the input values for
>> each floating-point type (float, double, long double).  It should append
>> the parameter LSUF (Literal suffix) to the floating-point number, but is
>> using CSUF (C function suffix).  This patch fixes it.
>>
>> Tested for powerpc64le and x86_64.
>>
>> 2016-10-28  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
>>
>> 	* stdlib/tst-strfrom.h (ENTRY): Replace use of CSUF with LSUF.
>> ---
>>   stdlib/tst-strfrom.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/stdlib/tst-strfrom.h b/stdlib/tst-strfrom.h
>> index 31a6492..75be55f 100644
>> --- a/stdlib/tst-strfrom.h
>> +++ b/stdlib/tst-strfrom.h
>> @@ -36,7 +36,7 @@
>>   #define STRUCT_FOREACH_FLOAT_FTYPE GEN_TEST_STRTOD_FOREACH (FTYPE_MEMBER)
>>
>>   #define ENTRY(FSUF, FTYPE, FTOSTR, LSUF, CSUF, ...)  \
>> -   CONCAT (__VA_ARGS__, CSUF),
>> +   CONCAT (__VA_ARGS__, LSUF),
>>   /* This is hacky way around the seemingly unavoidable macro
>>    * expansion of the INFINITY or HUGE_VAL like macros in the
>>    * above.  It is assumed the compiler will implicitly convert
>
LGTM.
  

Patch

diff --git a/stdlib/tst-strfrom.h b/stdlib/tst-strfrom.h
index 31a6492..75be55f 100644
--- a/stdlib/tst-strfrom.h
+++ b/stdlib/tst-strfrom.h
@@ -36,7 +36,7 @@ 
 #define STRUCT_FOREACH_FLOAT_FTYPE GEN_TEST_STRTOD_FOREACH (FTYPE_MEMBER)
 
 #define ENTRY(FSUF, FTYPE, FTOSTR, LSUF, CSUF, ...)  \
-   CONCAT (__VA_ARGS__, CSUF),
+   CONCAT (__VA_ARGS__, LSUF),
 /* This is hacky way around the seemingly unavoidable macro
  * expansion of the INFINITY or HUGE_VAL like macros in the
  * above.  It is assumed the compiler will implicitly convert