From patchwork Mon Oct 24 16:28:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 16769 Received: (qmail 24397 invoked by alias); 24 Oct 2016 16:28:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 24381 invoked by uid 89); 24 Oct 2016 16:28:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:stdbool.h, libcinternalh, stdbool.h, stdboolh X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1477326501.8523.51.camel@caviumnetworks.com> Subject: [PATCH] Fix -Wformat-length warning in time/tst-strptime2.c From: Steve Ellcey To: Date: Mon, 24 Oct 2016 09:28:21 -0700 MIME-Version: 1.0 X-ClientProxiedBy: BY2PR12CA0024.namprd12.prod.outlook.com (10.160.121.34) To DM2PR0701MB1068.namprd07.prod.outlook.com (10.160.26.21) X-MS-Office365-Filtering-Correlation-Id: 12e41a97-282e-47c1-ae3d-08d3fc2ac895 X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1068; 2:kP6U/+io3ws7HCpenfb1T5bUGNRYijb/FjJ4eJyDYZyYDQxAiVJTKAd/qsKtWampoIyw7XC9xNUNONzqv3xOzMJRy5OvPpZV9Vm4CA+9PSsb6OVq0nLOwlN8suqZDyFrz3cfGkn966yrJHSfnOjDbs3O8ImUP2kRMKF3jmKxc62sEYUvCNVG+muYwwKLsvvHzIAYGSkirRCYerA2Rxw/GA==; 3:iWEWOWpJ3n4Us7tN28QXSwkAP3ygASvydQ0XMeEGubjYzjjxL5ZRjXoRtyseP+XfFeUvyr78hZceyeGA4virLz9Hx8pLQAshcjxeIRHINQxej5F5Kec4CBunzbHeHa+n5+uJGgsWmS8M+iigPPmdbQ==; 25:1o4IM3JSQJOLGJamVNt8DPeBAoiLj3MufqCGyjwMANCSOzC78xZos0kG71vvnHDmNZ3pXdbUDEjEhd+erOsM61hwEkStzGCL8NDRdzVshAM8RfoyWzByKDqC4N8XP8ZgNdD7OiKqXBonhhR4q9kKu3KvM+qH1Nt69XF780x6KgKd5bMRl6zNHMUOaey94vE5A5dErminDS9ZBamrMBNl/0Uo+qlWch5Aj+9+DSwZHObi0y2VfQNai+pmqXfuPGOU+9b/63M456RF7jtS58LjugkBR/l6zx/9r8TM5gv4ty1TTl2VKh867M3eOl7JGjBZ8/+jnBMN+dGWvdlOGp1cR2L+yG6slAr6tHNsonZ/ATA/OW5sG9Dn5I0vyVeaqeMZJbh2tGYacZAv4UgWFQE/mV9GsduZYFFtoikS7JoX/6h6F8k2sMwOO0v2g5KdkjSh X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0701MB1068; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1068; 31:RL1alKN9XT+cOlPnNKrrs5KlSbbcZ0ooWvGxbizWJXLzH633ruTFJQC6UxXJ+waiMIRMRqwVaOKrFFepcz9V/0ir9GOw2oUL+HE6kcHMm8hmmLAx9WQaMfCS2PM8RiEM9499WYAuLZVuRPTjwyH3uwXItO0C4t8AbWe4+T1HG88Div3nnu34bNSBMwrZkl6btcP+7gzanwjzq1x2gVu8crclepiFS1fZhpkxPbCY70SwWR+Y7Lbn8ayROb7xB1hyJ3Dm2vuEtx+XeHiC0/5z1g==; 20:cxoX+v5Sv7inE/sdogYrQCIbON+XAsLqSSZzzNCV58yOk0rYNUIK0CHks67tKzEvYEupZKaZUnM5lZhbbSG891gyv+9UH9xkaJFf+Cg7EHQ70mpxghio2AfkOihZf1RVvKLNBw0gNKZrjVVE9eDAaUuexPqP0gEBm0LQNOIZik3IK3hEYJbGFrEkOCQ43WvcmfYBCOlxEcAKRob1Nuq29b41ePykFGDLk80gcJey5W9dSppJXuafKSzeYwcfZXk5Y2KHBBN/OKCslonBlEwZL0+1I2FcK5KfhwDi07uKuklen+D78fsulvj9nf34wU1qy3YVZ/tELslI7LQh4ScirMOhshYJun6JMAeR71dgmhF1NxygoOaNt+1N9qg+5tZP8lSHfLxxbEz/3HD1Ge0wwn2nSjrvZaPZY1MQFuXZvt4BlPg0Kjvq7Pma74mfBdfozWFCZ4+x38KsYUb216lpZFb2hGbeTeoSnJsCJxqcfKo6JSiikvh1fC2gu5yhMjGJnKIlJs2OMjUzVRfs/LzL0e4S7qwsUPhUc1LQ+xDz4eYIDc/fTTurwy7paC1r26QoHHoNPNQTsoM/nAa2cOrYhzYZ37mw9ctJb+PFfOokFCk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:DM2PR0701MB1068; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0701MB1068; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1068; 4:p5a0DZ45JEn0+j4k8fytVwA8DugZHOPZYRALXeVeqmA0LXexHkhXBcfwSjbeoZYRmsFHy8W96Sij2FPm2x7n45sRCmI6YDJ7uZLMOwdU49lZ68AetyaOk+9L/8FdYrw29gqgFhKSKNHrTBrOAg6w3b8Qb2ZNHS4SV3qQFffj0Swlf0YFhBHfULJ3d93SZYQ3eDaruT0hNZK/yKG0mO1VZQsS0JH/fD3oJjY3gav62UapoH42AIbun3OB+nJeii/uLzNZIOj+BEXu1zR6hWxFTvyKhjcdBYb3OT0NKxSbBOCUapn3uZtfQyWnkCpo8bRMrH07LAj7vsUO1yw8skNBWB4wSFu14Yixnf5vIFfxFpJaKG/r+oUMjr6UymxfQXyhfFHSTMBqg4rLPS/TnIbGKQ== X-Forefront-PRVS: 0105DAA385 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(377424004)(305945005)(81156014)(6666003)(101416001)(8676002)(92566002)(107886002)(50466002)(97736004)(4001150100001)(2870700001)(7736002)(7846002)(5820100001)(106356001)(105586002)(50986999)(81166006)(68736007)(36756003)(6116002)(66066001)(450100001)(2351001)(189998001)(229853001)(47776003)(33646002)(5660300001)(3846002)(42186005)(103116003)(586003)(110136003)(77096005)(19580405001)(19580395003)(23676002)(50226002)(69596002)(2906002)(6916009)(42882006)(53416004)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0701MB1068; H:sellcey-lt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjA3MDFNQjEwNjg7MjM6ak5IaWVoRS82UkQ3aEVvV1NTb01Ob0VO?= =?utf-8?B?QmFsV3Arc3pDY1JUWFk5cUJaQ2dxemo4Q0pyeFJNamt0b1VoNk1OakFFRzhG?= =?utf-8?B?bkxOb0R1aEtocCt5NlVYZ2g4OU1DeTRUbHI0NXdEbnhTTW04a3MycUwvWE9M?= =?utf-8?B?SzlpdVpmaTJhOGRUSWEyOEhCMHpxOEhnWXpiVzN3eUsybU14UHcvQTFqcGVq?= =?utf-8?B?VTRNT3ViTXF6TnNQVWxSYTRGMzNwQUZlMkNjUUZxRVdRb3dpRGxDU2REUjUw?= =?utf-8?B?d3RMTlhOalRhaW9ZK1Z0UDkzR282UFpDazl2OXMvVHBPbytpK1VLUkFUblh6?= =?utf-8?B?c2FXNWVCbVZUeDFjdFp3RnRJenlDRUJDMGJWamQ5cms0Smxmc01MUThGWFZK?= =?utf-8?B?eHcvVmdSamVGNlRQVkwybE5JUjFrdkUvaGZvVjZVZkhiNW5YZ3BuVDFPZG9B?= =?utf-8?B?VU9TSytIWGlhV05jTU82MmVLYWZXN0dDcDV1bXpISDJSRFRvb0wwNjc0cWU5?= =?utf-8?B?Yy9WNDZrQVd4SDdTdW9xQVQ5Q3pOVE5yQURBMHpLL0JoejhLQWxySnhLYWU4?= =?utf-8?B?SHVuRXN2TzdFUjArZEYzeFQxdHBaU20wSUxHRmVwVmQ5VUNlVDJROGxWejF5?= =?utf-8?B?OGJ0Rnd6bGVtTzAvMm8wMEJDYkpzYmNNNEhNTFNhdVdFa25kWjBVTVpYN1Ba?= =?utf-8?B?cEJjVnBiRjQzZWZWcHJiN3FwVWxGNDVWTnVvTzBWRzZNU3FWUUVwWTdPUk5a?= =?utf-8?B?cFZraG5ZdHd1enlQSzYybkZqZW9ralJKNk5sREkyS1d5cFEybHk3YjNMRmI5?= =?utf-8?B?bitsNkp3Vnd0Y2EyZ0lkRm9XRllqSDMwSkNQbFFqZW5oVzFaMlFEQ2h1WitW?= =?utf-8?B?RkpoaDZoTXVYQmR2SysvK2hGYmZRamFtUUdSbXk3ZThQeFZHZlcwK3Z2Snk4?= =?utf-8?B?RkoyZ3MyTHlHSWl0Y2xYbXN5d3MrN0swcGlhODNTblAwRWFCQkFQME5PSHpO?= =?utf-8?B?dXRRTzdRUnJPMFVKNVZnMVo1cmxTaVFERVBJRXdhNy9WQU1uanZVTFdlZHo3?= =?utf-8?B?azE3aXFKSnllNFpJRElsUVd0V1JsMko1Y1lIR1kxak50WktVNTUvUG1TaFIx?= =?utf-8?B?d3VOYjFuZ1JkNURzUUFHK2pWaHlMK2RYL055U3lWbFpqRXpoc1lObHdhd3U0?= =?utf-8?B?d0RyU2VZN2JlZ0ZIQnduNDg0ZVVFUllRYml1bDV5dTRXVU9FeU9ydldHeTc0?= =?utf-8?B?MGRyd2pzQmQ2ZDNtblk2SVNmVkNwRVlaMzVZS0Y0RndUYnR4ZDA1YWN5eFdk?= =?utf-8?B?YmZtYnB1T1NMNFE0Tk5NQ2NrU2FMeHFRK0h2dFBEQlNBQnJrdnhnUU9odGYx?= =?utf-8?B?SDd5RzEvRWxYb3d4THVjUWpTNmhNRW9SSk5UK2x5MzBGN2dRbGFlVFJMRml6?= =?utf-8?B?R3dXbTV5NlBnY0pvQkhKZ29lclZVc09aS21PZEpXQ2ZhUFJTbjRxUW1ZQkxT?= =?utf-8?B?MVQ5d0YwSHZrM0NDQkgzcFZoL0svdDFmNkVlTk1PazNzaHhFTlR1TWJFVzdy?= =?utf-8?B?UGFFY1YzaXY3TEpYa0RjM2hsVS9lYVkrQk9aRGIzQnpzbnNZU0xaTk5ERWJE?= =?utf-8?B?Z0k4Ync1NFVINFp1b0tMbTJMQ1VUcHhyeXUxTThoS0lpaG9aR3VBVzJuYWFr?= =?utf-8?Q?/RvlF6XAko3QbBzy9l3VRuNu2TTDd7jiAH1nr2Xjq?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1068; 6:+14jHStB83gMCIq4n2DmQUR11F3uSWUIKSWgScyaY7mhMBSdPhMx1iebABKW6RWzd5JLTX7adxqPw0pQoqQHuHXEQ6Mj2M4WsrVCUinmCunQBnsZQDRTL9OdXnzXyGIcd4KW/M0cYrQVX1sjsvdla9qUZxzE6fRsd28Mf3NZtSbPqRSvU5R2KV6dMo4yExjaSmGSAkv60sbRoZ58jFpMi1Q692lYc5mv75x+KfIXSoD6BHnlm8/s+8IY8jdyp/OO2WnvtA63YjUWXqPf16JEuIqwhFTQNt1Oz25S1nmKJe0DLmQEImTbcHNzR0eQQKJ9; 5:fHu5FZ/VxnMzdq4WUMiEXqOyqXKWgynpVHU6vU599FV9mmGHocYxWpDkCCGuKnVUVzghuwmWe2eOKJ9AYlTAv7TM3YEN93greIDSI12FpSmmkTsSAHpSDT7BXFO17IkMKBSc9dn4AFJegC0Ots7n2A==; 24:fQp+/LsqevAkDEi6q+TNNiNGVBlfFu/WtD4Oe+KMzbHptSa8zVDk46+vKMsSbdk6BhmUoFpPUChvGN7aV3HFUNNlr9/R+I31uBP/r67YF38=; 7:yiSaqnMoh929fCHjMmve4eXzX3bmVWY26tJh2t9qwrS97qFzFc75gnNbjbRpGXJWOjBXy2b3pu+yHMWNlV1oD+2ME5sD8VEkofTvkn02KWl0M1EyWyWuRd2S4tm5iAhlJgTWkiLV7Z2+zf3thgXTbYBiEGFbl7ivchk0cR+TEZWuFuRVySWkHjPmc77/uQ+nxnrRBlfx469dbwYV7Pw/AUlgnrRdSolnICW2Kq/OawyiVba9kJ/1CLlVJx5xaG83g1mJWpDnd969VTJAx12+D81wdRENzw5aEzB52bnDZvjnGgoClgRGfE8g7p4j8CVDYtBGd0X5rQ5EoUxy6q8XzSlSPFnyuljW5J1EnEC1IzU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2016 16:28:27.2039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1068 This is the third of three patches to deal with the new -Wformat-length warning in GCC 7.0.  Changing the size of the buffer looked like it might interfer with what the test was trying to check so I added a DIAG_IGNORE macro for this test. Steve Ellcey sellcey@caviumnetworks.com 2016-10-24  Steve Ellcey   * time/tst-strptime2.c: Ignore -Wformat-length warning.      { diff --git a/time/tst-strptime2.c b/time/tst-strptime2.c index 7fe7350..2f411a4 100644 --- a/time/tst-strptime2.c +++ b/time/tst-strptime2.c @@ -4,6 +4,7 @@  #include  #include  #include +#include    /* Dummy string is used to match strptime's %s specifier.  */   @@ -67,10 +68,16 @@ mkbuf (char *buf, bool neg, bool colon, unsigned int hhmm, s ize_t ndigits)    long int expect = LONG_MAX;      i = sprintf (buf, "%s %c", dummy_string, sign); +  /* GCC cannot be certain that the buffer is long enough so it issues a +     warning.  We know that hhmm is never more than 4 digits so we can ignore +     the warning.  */ +  DIAG_PUSH_NEEDS_COMMENT; +  DIAG_IGNORE_NEEDS_COMMENT (7.0, "-Wformat-length");    if (colon)      snprintf (buf + i, ndigits + 2, "%02u:%02u", hh, mm);    else      snprintf (buf + i, ndigits + 1, "%04u", hhmm); +  DIAG_POP_NEEDS_COMMENT;      if (mm <= mm_max && (ndigits == 2 || ndigits == 4))