From patchwork Thu Oct 20 22:43:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 16713 Received: (qmail 20254 invoked by alias); 20 Oct 2016 22:43:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 20225 invoked by uid 89); 20 Oct 2016 22:43:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1585, thinks, HX-ClientProxiedBy:sk:BY1PR05, H*r:sk:NAM01-S X-HELO: NAM01-SN1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1477003405.8523.21.camel@caviumnetworks.com> Subject: [PATCH] Fix warning from latest GCC in tst-printf.c From: Steve Ellcey To: Date: Thu, 20 Oct 2016 15:43:25 -0700 MIME-Version: 1.0 X-ClientProxiedBy: BY1PR0501CA0038.namprd05.prod.outlook.com (10.162.139.48) To BLUPR0701MB1058.namprd07.prod.outlook.com (10.160.34.155) X-MS-Office365-Filtering-Correlation-Id: e852af4d-7e97-42c1-8166-08d3f93a84c2 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1058; 2:damqgpINyjgsjwg27hHf0OlLqkwaJ4XnjGy43O9uyh1/O03XSL9M1PTwZ9I8v0NgRHzEf4r6ITNQYgD3XyzviMBJNDEGw/pCeAbXWtxlEB+FJO3nbH0uN2xdc/E10QXlY1OCXNyLvApxXH2Xzk3acaPQcZCvEv92VmwZlwmFHS0joG6JnXmZIzlbrA+G4xbiP5tnqogPQpwrvpT8gI6thA==; 3:NsDK2faqrtURjp5bfmudbALXBfIynHjlXq7YVF2WcD4aVN/v87Pia6xK4LoWPpFgWPk0/C4zgwDITenjT9KqYdU+xbnJa5SddsnULyvIv2Zqu/pytoZBPzbEqeDG+ZO91JEwgmiF+0aMMZ88Epl5bQ==; 25:QU4AiZ5fnLdWkEsDXiXa7La6jwRTDdi9rUI2MaUJO6GpIQ40jMdRlTG/WE4F+/jXY6Pf7TifjyqYGZggNpAca/4PHtyGredH/G14d8LNF/EfXwI/RDsj+6IrRhaxEeCTa4Z9GOFOzpSlhi1R5yr435OIQmijPxnq6huBrUTNFoo9lbS9z7b9oeIvCPJ0jawF+47mSQ0YdosQwVTAZdfIWR3kTeTAs+3kFbPqeiU0YO7rP7FTt7+GIoFpr8na3EFlBUnp/UEvc9P61JIt476d4qIVA1ul5QpvBbNWMpTEdRZLGvAbKq1T7cR2AF05CnbQpXDNdrtEKuYG9tDDlMFXq0rgMYg+b+PGvhcL9Ww/MmbyB4X+C5x+Zz+/sNse+c4/z8WAdj59zrc0nJtlIhFGJdJfm1AYUTcdaONQDrt5GnyMarQa1+SRcQF6J1wUxgAP X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1058; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1058; 31:ulUBup2Q++Af/McNp+QKFeK1H48J1vBjEqYkFV7YVFujjGz+mk9NACMBuAZHWTov1oIt6Ah9OiTc70iKcqaaECHgotg3AUNrkhaldMkNtJRKVPTlYneiSRi22Qf1585yEpL5i/iPjaZE16cam26wcH0ewVW8egMgHWsxCzmUWOXSvhGC/w5BUJr8N7m3vUHePZTtFPBl/fD5lWtHS9iVqaZ0movyPeGtC88vHOnu2FBBIerHx4svbnL8LLviE3lm; 20:KhKNsQZ0OfQqudcaRPmBCTGCF/PfDG2LhFPNO5CBfWy8iPlTkCjI1gzFQ1WC/HoorseLwc7uFgfKf5FVMlkOh1rz4EoiG59u9pHjaLZh+WaqAns3iTM33bvDZ0GQFAQy3LDJVqmB9y+SDdUgvwiOKd/g+iUlGACv3cxDltTF1tM+HqWZ2Q2HpBeFdLVaToY4RJZjbMLG710uRVYMlrhbB3x+Meqvn55JXh4vnTRFbXhTHkqwj+/tmN2h7IiAESd7LPHn/PPgKIpJyNwMxLg69Did2ypafzy+ElYX9KW3I5Xw/ijwmPmXjIhpfRsS1DCvusCJKb4gx7VJloTSDZVK1S69PrPb6neW+a0uDlQzROESEYsiC3QjUeIsrKoMxCaAyhUkmGULUzg0pczs6i1Gqn3vt/jMuDQ1xscbjYcqoWDFl+a/MRvVaUUB+5PMxK6/jAuLuR18oC4/8D5kcK21mVW/b5PrcReze0soX/6FiwIHqmsyTYYwC5DPY/fGdmihTjjQKn1PFPrm5n4ZkDEs4FwEblihmLu2111ZgldmILLoMnXPIyBXI99GNwTB/hCOIR7Lm1AZZR4rTmLBF55Ds7DYTjzlcmaTzLjnODkARM4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1058; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1058; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1058; 4:3oV3kudVSpI1FjYpjtYxD4ek/1Sd19gsVlrgCclkUYvLwAJErR7YzIG+CoV2g9QGQUw4KBOHHebLyV1Jg3iSbfrZo5FRx1jf4amSZ+7/UjTyd7TefvkDYR5Dda+/EVjqACHu+1/8lQg3rR9rpFbg7FkKOPlvi/lgztwaIemVe95D8rwOy5aoXfr+HDapQnBXzmcmPNY/q3o6HKQKonFld1FTBjyT/it5+KAwJaLoCMA+Jzx+DZtUezHA/M7d++Dcae7S/Sl13vZe3M9u7ght7jusk2tYfyk/ny2O3lt9N60zsO0zn4bOjReAk7LK8GiRXAxXgTtFRImBq7LSd9ZjPmoa+6GrSue52heX7c5JquF9gPq8p/5RKx2YzY+MMpTHBHTSG6GQe/wq3dbmV1yUSw== X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(377424004)(199003)(189002)(47776003)(50986999)(19580405001)(42186005)(6116002)(66066001)(19580395003)(23676002)(103116003)(586003)(3846002)(69596002)(101416001)(106356001)(2351001)(105586002)(36756003)(50466002)(229853001)(33646002)(53416004)(50226002)(2870700001)(4001150100001)(68736007)(81166006)(450100001)(92566002)(7846002)(305945005)(6916009)(8676002)(97736004)(107886002)(42882006)(189998001)(81156014)(5660300001)(110136003)(7736002)(2906002)(77096005)(6666003)(5820100001)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1058; H:sellcey-lt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3MDFNQjEwNTg7MjM6WXowUGJSakorQkFkb0xpTzhOWEVvemhX?= =?utf-8?B?QmpWMXlqTHA4SUpHSTRjZktxOFI5VXUzYzdMUFNpdkY2Z3d6YTZXYWFlQWkr?= =?utf-8?B?S3lpT0IwYThGWXROd0UrQ2J5dWFVeTlNVHdXVjVMQ2dpN3VtZmtNL1Mvc1lE?= =?utf-8?B?cTBYYmhpZTRXNFMyZFdUd1g1OTkrYjZScnIzWlliVndBZXdQM3ZOQ3kxZjhE?= =?utf-8?B?ckJ2a3J5NUltaXYrZWxoTjJzRVR3bVlrU3Z5bDVwTXo2NDNCZ21Wa1FGWFMv?= =?utf-8?B?VURnZGhuVmhHVk1zVnBycUdFKzlNcVRwTXhJVnNTYllaalRIR3NNd3JFRm53?= =?utf-8?B?NDkyK3MvMjg0UkJYNWNRRmxjcXh0SDZDM2JsN1dKWU5xQ3duZ1BWc3lrSE9v?= =?utf-8?B?S2w0VGNmcDlrd2ZxcmdCTTFncmZUd3hZZU9LR0JmallhRk9XVnN4a0x0UXhr?= =?utf-8?B?T2x3SFZBMWxqRkdKSVhsUnBiWndHWElnOE5acEorOHdXNzZ3cElnUlcxUDhl?= =?utf-8?B?cHJQMGdxaHI1YnlnaFdrZmN2dmZmOXBrWUhXRUp2TlRGVDJlUCs0aXNESGxE?= =?utf-8?B?MHdGWlc5QmZDWDNRV09wK3JpL1dWOFIwZ21NTWxab2M3WndzQzZKYk5qZ1E2?= =?utf-8?B?TVdvMDNIVnlpdkdIaHRFVlQvZlVUVGN2cE1tbUF5cHhtV21RWjFtSUEyUWxu?= =?utf-8?B?TTFxbDhCdDNWbjVMRFRuNlRlSmJGTDN4RVl4MWlmdDRreEVBSGcvSEpHT0VD?= =?utf-8?B?cFI2djlwM0VxcEVuVnZiK1pCQkxkcERuWUV5dC9PSVBKRkxzSytVbTQ5dTYy?= =?utf-8?B?QjB2cHhndS8xRThUbVFmc2dzRDFZTms2ZE11QU9KV2V3ZGhUUzd1c04rcVNw?= =?utf-8?B?YXRNY09aNmlDWEhLK0gyR0lFclRvU05WTTRVak05aGhORU1YK3Q4Ym9hRFJK?= =?utf-8?B?VlJ6QVY5enZIZ3dlS0czYkRWY3kxODB4Q3p6dGhQa09OMmkzdzBidklLSGJx?= =?utf-8?B?WmhMaXdqYS8walNBdVRkQ2pBUWVHcFB1VlVjc0hJU0ZYSktBL0d1MFB5TCsw?= =?utf-8?B?dnpSME04MjBtSmpuNEZ3K01qWkJGVllWNDVXQUZXOCtlNWZzUk50WkxocTF4?= =?utf-8?B?L1ZvdWVSRHpiRlkzNG1RUy90MjJjeUFkalNkM2pBd0FubXJVOUhodGg0WlR6?= =?utf-8?B?ZHp3a2VObXJhVDVxTkRwSk9JaGNOQlY5TkdVcVdraThOY3JoOE56aUY1ZUFV?= =?utf-8?B?blFsUW51WnUxcE5hdjZQZVplUjRCTTNZUVF4L1NwMHBOa2U4aGR4MWMwUEkw?= =?utf-8?B?ZFh0N0Jkd2VqTFozTTJmb3JyUGZnenRKWkVZMjZIMHdNbFEwYllUM0xNc0Iy?= =?utf-8?B?ckNDdEhIV1AvODZnbXluNXljRTdOeU9CS3VNZ0pnM0lEdWhZK1ZpbDFSZVo2?= =?utf-8?B?QTJmcnZnM2tBK1NMZkNLb3hMQ3N1bHd1MjBIc1pjd21xdzh6SS9CSEFyMzl0?= =?utf-8?B?MUJMK1Fxc0FVWXM4SWtQdWI0Z2dLeDBUVWFMZ25ubjFZODJkclNNWUgwSW52?= =?utf-8?B?d0pmM3prYWZhT3paN2pTRVZzTzE2YTdiR01ld2NIN090U0N0VVpZb0tEVmpE?= =?utf-8?B?OEh3S1ZOSWpzR2QvcDBRTTc3R0JLSUd4WXdTNHRKWDZTRUE2dXZXamFrR2NL?= =?utf-8?Q?z26PrKmLFDHgcaAh9EYRJpigUlmKuwiI4DRbeDfqV?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1058; 6:EZHmhLa7yYTL58TL2WLC1RCdqytyj1oHg8RDoUQ8/sAvqDjG2ETYD8H08ukpN32tDU2hAoOG0VM5467qhjxcYNU7mbhG4yDKSCmd5j59HU2+MOE0oRrcwppOSM0JMo+JKDTjXxci7fOFuo/j2uthxWAQ8wvRUI2V9/qOlBCrI4DNnLbo85Sd8SmKvEnDSuaNljD4OyNmdzy2Mi7cN+FFQY32ASEwp+mA6vCeihqCrDXFJIn8atdiiaLDf8T9Z1/83mBDwp50sokaPz+13YoL8tAtyn4zRjsYz8G4Wv0NhRlfL0IO1dJfVffDEeX40bdL; 5:ze3/IcssXka5ShLE93q1VqJ5pTJ6ZT8NjhX33OJA/lPx46y31KOIJq+5ELEtCWUi9Dfeg9tPze2UtUCoHv/K7814aGc0KNrYoXY13pMFVyrKtR71zQRWX9SIq2D62BLOl6Y0A4jKh+s0Sf+OeUJ8WrH7eE6MQuQTnEwUPXqLmwI=; 24:un2Q9JaxFA9d63dwWKdnRVjs32Z43AqZ3vm6TTC0R54zyWH91GsivEL2SVE5GFJjEnB1PLJrDBfvXWYrtU7eDECmEsy9xxGTETZgw8DOe+w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1058; 7:2JAKfy4j62JOdpXR7SAOlYBS/pak0T4lKrQq5PP1uCt2Poszo5RyJo/eLrr/EKzsoPsMwQ8d6/xPON7CUkfOBkUN+9ijiXGKn5G+9Ywk5miaP6fAfDXZKpjXvqzXuTa+VaWXxuUeRTTsdsuGWvJsds1Qe6i9sh0q8+VdB9nqc7w4Sel9nmo3GPJmgEgufpr0EPUalYOaxfhmVMiLkyA+xcIn4fvoBvM1sixas1t1q0So1zjyBwcvD+HzQ+nEJQprqQRg52NvIKLHTlieBK0jcridWfLsuJUwvQwG8qR5cb6n0iknsegVp8UeyMxozuGBLkEDIMPYPzLeMcRJr0lttvG2Qp6h/+8bYHLpEaE3mfw= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 22:43:31.8009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1058 GCC 7.0 (prerelease) adds a a new warning, -Wformat-length, if it thinks an snprintf call may go beyond the end of the buffer length being written to.  This warning is an approximation since GCC may not know how many characters a '%d' format will expand to, but it makes a worse case guess and warns if that would take the print beyond the buffer length. Here is a fix for one GLIBC test that fails to compile due to this warning.  I think we want to ignore the warning in this case and not increase the buffer size because I believe the test is intentionally trying to go beyond the buffer limit. The warnings are coming from the snprintf statements at line 225 and 228 of the original stdio-common/tst-printf.c and I could do a push and pop of the warning down at those lines but I thought it made more sense to put it up with the other DIAG_IGNORE. OK to checkin? Steve Ellcey sellcey@caviumnetworks.com 2016-10-20  Steve Ellcey   * stdio-common/tst-printf.c: Ignore -Wformat-length warning. diff --git a/stdio-common/tst-printf.c b/stdio-common/tst-printf.c index 2896b18..1ae1eea 100644 --- a/stdio-common/tst-printf.c +++ b/stdio-common/tst-printf.c @@ -32,6 +32,9 @@     The compiler warnings are not useful here.  */  DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wformat");   +/* Compiler warnings about format lengths should also be ignored.  */ +DIAG_IGNORE_NEEDS_COMMENT (7.0, "-Wformat-length"); +  static void rfg1 (void);  static void rfg2 (void);  static void rfg3 (void);