From patchwork Thu Mar 31 15:45:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 11580 Received: (qmail 60743 invoked by alias); 31 Mar 2016 15:45:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 60686 invoked by uid 89); 31 Mar 2016 15:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=os, 888, Hx-languages-length:2075, HX-Received:10.66.190.40 X-HELO: mail-pa0-f47.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Tdopxv7UUDiH5lvw79bFGGgnq6iYBIqrjoQJB9jBdG4=; b=YByjRB/qSuOuXPh1BU2+75g5eEVlPGYEq2Wu0UxBkM2RBnFHfWKHvhH21AyNzCQHzw Wtk2bejXqPizhhDxzljFTEPa1+jmDDMv/aEsZAdgA/5W4sk/3A55MMNRkP0seECU8jHF lj67bhnLuJyL2GXOf6oZLFn4rsaSdfD3U8WhWF2H7ZoFwjy1DA4luXxFU/rODH+PgImy 5FGYRQpymQfg9YYlUnOsYZd5N59zmaPvt9YM25fMo9YaPXNL9wPmsJOIeqg/L0vTmGMh OCippMZH82gsKjdXtPryf6Bvpl//UqlX07gfvVC3qZtyqI89hoqKolaDByQuFl+12Nsi mVBg== X-Gm-Message-State: AD7BkJItLMoykySSf3r4DLQ0OkAu+xwvjCFWnStU0aiAfbyTKcYZO8sIbYCxegvkt04GzQ== X-Received: by 10.66.190.40 with SMTP id gn8mr22853627pac.64.1459439118915; Thu, 31 Mar 2016 08:45:18 -0700 (PDT) From: Khem Raj To: libc-alpha@sourceware.org Cc: Khem Raj Subject: [PATCH V3] When disabling SSE, make sure -fpmath is not set to use SSE either Date: Thu, 31 Mar 2016 08:45:12 -0700 Message-Id: <1459439112-30153-1-git-send-email-raj.khem@gmail.com> This fixes errors when we inject sse options through CFLAGS and now that we have -Werror turned on by default this warning turns to become error on x86 gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -x c /dev/null -S -mno-sse -mno-mmx generates warning /dev/null:1:0: warning: SSE instruction set disabled, using 387 arithmetics where as gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -x c /dev/null -S -mno-sse -mno-mmx -mfpmath=387 Generates no warnings Signed-off-by: Khem Raj --- Changes since v1: - Add BZ enry to ChangeLog and commit message Changes since v2: - Add commentary in makefile, describing why the change is needed ChangeLog | 6 ++++++ sysdeps/i386/Makefile | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 4fc73b1..6d2fd80 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2016-03-31 Khem Raj + + [BZ #17950] + * sysdeps/i386/Makefile [$(subdir) == elf] (CFLAGS-.os): + Add -mfpmath=387. + 2016-03-31 Adhemerval Zanella * elf/tst-dlsym-error.c: Include for strchrnul. diff --git a/sysdeps/i386/Makefile b/sysdeps/i386/Makefile index 168512f..929b377 100644 --- a/sysdeps/i386/Makefile +++ b/sysdeps/i386/Makefile @@ -88,8 +88,12 @@ ifeq ($(subdir),elf) # Make sure no code in ld.so uses mm/xmm/ymm/zmm registers on i386 since # the first 3 mm/xmm/ymm/zmm registers are used to pass vector parameters # which must be preserved. +# with SSE disabled, ensure -fpmath is not set to use sse either, this +# avoids below compiler diagnostic +# warning: SSE instruction set disabled, using 387 arithmetics +# which is treated as error with -Werror CFLAGS-.os += $(if $(filter $(@F),$(patsubst %,%.os,$(all-rtld-routines))),\ - -mno-sse -mno-mmx) + -mno-sse -mno-mmx -mfpmath=387) tests-special += $(objpfx)tst-ld-sse-use.out $(objpfx)tst-ld-sse-use.out: ../sysdeps/i386/tst-ld-sse-use.sh $(objpfx)ld.so