From patchwork Mon Mar 7 17:36:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 11236 Received: (qmail 126104 invoked by alias); 7 Mar 2016 17:36:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 126037 invoked by uid 89); 7 Mar 2016 17:36:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=908, 906, Hx-spam-relays-external:mga04.intel.com, H*RU:192.55.52.120 X-HELO: mga04.intel.com X-ExtLoop1: 1 From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: Ondrej Bilka Subject: [PATCH 1/7] Remove dead code from memcpy-sse2-unaligned.S Date: Mon, 7 Mar 2016 09:36:24 -0800 Message-Id: <1457372190-12196-2-git-send-email-hjl.tools@gmail.com> In-Reply-To: <1457372190-12196-1-git-send-email-hjl.tools@gmail.com> References: <1457372190-12196-1-git-send-email-hjl.tools@gmail.com> There are ENTRY(__memcpy_sse2_unaligned) movq %rsi, %rax leaq (%rdx,%rdx), %rcx subq %rdi, %rax subq %rdx, %rax cmpq %rcx, %rax jb L(overlapping) When branch is taken, cmpq %rsi, %rdi jae .L3 will never be taken. We can remove the dead code. [BZ #19776] * sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S (.L3) Removed. --- sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S b/sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S index c450983..7207753 100644 --- a/sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S +++ b/sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S @@ -90,8 +90,6 @@ L(loop): jne L(loop) jmp L(return) L(overlapping): - cmpq %rsi, %rdi - jae .L3 testq %rdx, %rdx .p2align 4,,5 je L(return) @@ -146,15 +144,6 @@ L(less_16): movzwl -2(%rsi,%rdx), %eax movw %ax, -2(%rdi,%rdx) jmp L(return) -.L3: - leaq -1(%rdx), %rax - .p2align 4,,10 - .p2align 4 -.L11: - movzbl (%rsi,%rax), %edx - movb %dl, (%rdi,%rax) - subq $1, %rax - jmp .L11 L(between_9_16): movq (%rsi), %rax movq %rax, (%rdi)