[10/14] Enable -fstack-protector=* when requested by configure.
Commit Message
From: Nick Alcock <nick.alcock@oracle.com>
This finally turns on all the machinery added in previous commits.
---
Makeconfig | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Comments
Nix <nix@esperi.org.uk> writes:
> -+cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags)
> ++cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags) $(+stack-protector)
Please fold long lines.
Andreas.
On 24 Feb 2016, Andreas Schwab stated:
> Nix <nix@esperi.org.uk> writes:
>
>> -+cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags)
>> ++cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags) $(+stack-protector)
>
> Please fold long lines.
I wasn't sure it was syntactically valid here (as in the bit of
configure.ac with a long line). Clearly I was missing the nose on my
face: glibc folds += lines *all the time*. Will fix.
@@ -762,6 +762,11 @@ endif
# disable any optimization that assume default rounding mode.
+math-flags = -frounding-math
+# We might want to compile with some stack-protection flag.
+ifneq ($(stack-protector),)
++stack-protector=$(stack-protector)
+endif
+
# This is the program that generates makefile dependencies from C source files.
# The -MP flag tells GCC >= 3.2 (which we now require) to produce dummy
# targets for headers so that removed headers don't break the build.
@@ -821,7 +826,7 @@ ifeq "$(strip $(+cflags))" ""
+cflags := $(default_cflags)
endif # $(+cflags) == ""
-+cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags)
++cflags += $(cflags-cpu) $(+gccwarn) $(+merge-constants) $(+math-flags) $(+stack-protector)
+gcc-nowarn := -w
# Don't duplicate options if we inherited variables from the parent.