diff mbox series

string: Amend grammar and add description <byteswap.h>

Message ID 0ec75b22-6921-f79b-facd-61288aac9dd2@jguk.org
State Committed
Headers show
Series string: Amend grammar and add description <byteswap.h> | expand

Commit Message

Jonny Grant Oct. 26, 2020, 2:57 p.m. UTC
Please find attached patch created against latest git.

Regards, Jonny

Comments

Carlos O'Donell Oct. 26, 2020, 3:32 p.m. UTC | #1
On 10/26/20 10:57 AM, Jonny Grant wrote:
> Please find attached patch created against latest git.

Thank you very much for the patch!

I don't see an assignment on file for you for "GLIBC."

Just for clarity...

Could you please confirm that you would like to submit this patch
under the exception for copyright relevance?

That is to say that these changes can't really be copyrighted
and that they are below the 15 line exemption even if they were.
Jonny Grant Oct. 26, 2020, 3:44 p.m. UTC | #2
On 26/10/2020 15:32, Carlos O'Donell wrote:
> On 10/26/20 10:57 AM, Jonny Grant wrote:
>> Please find attached patch created against latest git.
> 
> Thank you very much for the patch!
> 
> I don't see an assignment on file for you for "GLIBC."
> 
> Just for clarity...
> 
> Could you please confirm that you would like to submit this patch
> under the exception for copyright relevance?
> 
> That is to say that these changes can't really be copyrighted
> and that they are below the 15 line exemption even if they were.
> 

Hi Carlos

Yes, happy to submit under the exception. 

Happy to submit copyright assignment for GLIBC as well for the future.

Jonny
Carlos O'Donell Oct. 26, 2020, 3:51 p.m. UTC | #3
On 10/26/20 11:44 AM, Jonny Grant wrote:
> 
> 
> On 26/10/2020 15:32, Carlos O'Donell wrote:
>> On 10/26/20 10:57 AM, Jonny Grant wrote:
>>> Please find attached patch created against latest git.
>>
>> Thank you very much for the patch!
>>
>> I don't see an assignment on file for you for "GLIBC."
>>
>> Just for clarity...
>>
>> Could you please confirm that you would like to submit this patch
>> under the exception for copyright relevance?
>>
>> That is to say that these changes can't really be copyrighted
>> and that they are below the 15 line exemption even if they were.
>>
> 
> Hi Carlos
> 
> Yes, happy to submit under the exception. 
> 
> Happy to submit copyright assignment for GLIBC as well for the future.

Jonny,

It would be great if you had a future assignment in place which would
allow me to just accept these patches without further review.

Thank you again for the patch.
Carlos O'Donell Oct. 26, 2020, 3:55 p.m. UTC | #4
On 10/26/20 10:57 AM, Jonny Grant wrote:
> Please find attached patch created against latest git.
> 
> Regards, Jonny
> 

OK for master. Obvious improvement. I've pushed this.

Removed Signed-off-by: line (we don't use it in glibc), but
added my Reviewed-by line.

For more details see:
https://sourceware.org/glibc/wiki/Contribution%20checklist

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Jonny Grant Oct. 26, 2020, 8:53 p.m. UTC | #5
On 26/10/2020 15:55, Carlos O'Donell wrote:
> On 10/26/20 10:57 AM, Jonny Grant wrote:
>> Please find attached patch created against latest git.
>>
>> Regards, Jonny
>>
> 
> OK for master. Obvious improvement. I've pushed this.
> 
> Removed Signed-off-by: line (we don't use it in glibc), but
> added my Reviewed-by line.
> 
> For more details see:
> https://sourceware.org/glibc/wiki/Contribution%20checklist
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 

Thank you Carlos.

I couldn't see exactly what to do next from the wiki, so I've emailed assign@gnu.org to ask them what I should do next for GLIBC copyright assignment.

Jonny
Carlos O'Donell Oct. 26, 2020, 8:56 p.m. UTC | #6
On 10/26/20 4:53 PM, Jonny Grant wrote:
> I couldn't see exactly what to do next from the wiki, so I've emailed
> assign@gnu.org to ask them what I should do next for GLIBC copyright
> assignment.

Download this:
http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

Fill in the details and send to assign@gnu.org to kick off the future
assignment process.

If you have any questions please don't hesitate to ask for help.
diff mbox series

Patch

From db2140094c0948b2dca801aa1253af0aeb8241e7 Mon Sep 17 00:00:00 2001
From: Jonny Grant <jg@jguk.org>
Date: Mon, 26 Oct 2020 14:55:14 +0000
Subject: [PATCH] Amend grammar and add a description

Signed-off-by: Jonny Grant <jg@jguk.org>
---
 string/byteswap.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/string/byteswap.h b/string/byteswap.h
index ca600d863d..8f6939717c 100644
--- a/string/byteswap.h
+++ b/string/byteswap.h
@@ -1,4 +1,5 @@ 
-/* Copyright (C) 1997-2020 Free Software Foundation, Inc.
+/* Swap byte order for 16, 32 and 64 bit values
+   Copyright (C) 1997-2020 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -24,10 +25,10 @@ 
 #include <bits/byteswap.h>
 
 
-/* The following definitions must all be macros since otherwise some
+/* The following definitions must all be macros, otherwise some
    of the possible optimizations are not possible.  */
 
-/* Return a value with all bytes in the 16 bit argument swapped.  */
+/* Return a value with both bytes in the 16 bit argument swapped.  */
 #define bswap_16(x) __bswap_16 (x)
 
 /* Return a value with all bytes in the 32 bit argument swapped.  */
-- 
2.25.1