diff mbox

build break in strcpy.c

Message ID 002f01d0081f$567941a0$036bc4e0$@rt-rk.com
State Committed
Headers show

Commit Message

Petar Jovanovic Nov. 24, 2014, 7:46 p.m. UTC
➢ commit b863d2bc4db728213e54ff502d2c3ae5dfa0db25
➢ Author: Wilco Dijkstra <wdijkstr@arm.com>
➢ Date:   Mon Nov 24 15:09:07 2014 +0000
➢ 
➢     Improve strcpy performance.

Can you actually build the code after this change?

You may want to follow up with:


Regards,
Petar

Comments

Wilco Dijkstra Nov. 24, 2014, 9:48 p.m. UTC | #1
> Petar Jovanovic wrote:
> 
> Can you actually build the code after this change?
> 
> You may want to follow up with:
> 
> diff --git a/string/strcpy.c b/string/strcpy.c
> index 91f9cc6..94ca1df 100644
> --- a/string/strcpy.c
> +++ b/string/strcpy.c
> @@ -24,6 +24,6 @@
>  char *
>  strcpy (char *dest, const char *src)
>  {
> -  return memcpy (dest, src, strlen (src) + 1));
> +  return memcpy (dest, src, strlen (src) + 1);
>  }
>  libc_hidden_builtin_def (strcpy)

Sorry, not sure where that extra character came from - it seems to
be in the email with the patch but not in my original code...
Anyway, committed as obvious, and it builds again now.

Wilco
diff mbox

Patch

diff --git a/string/strcpy.c b/string/strcpy.c
index 91f9cc6..94ca1df 100644
--- a/string/strcpy.c
+++ b/string/strcpy.c
@@ -24,6 +24,6 @@ 
 char *
 strcpy (char *dest, const char *src)
 {
-  return memcpy (dest, src, strlen (src) + 1));
+  return memcpy (dest, src, strlen (src) + 1);
 }
 libc_hidden_builtin_def (strcpy)