Message ID | cover.1585587351.git.vivek@collabora.com |
---|---|
Headers |
Return-Path: <vivek@collabora.com> X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by sourceware.org (Postfix) with ESMTPS id 52028385DC05 for <libc-alpha@sourceware.org>; Mon, 30 Mar 2020 17:42:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52028385DC05 Received: from noise.collabora.co.uk (unknown [IPv6:2a00:5f00:102:0:c0a7:51ff:feaf:e642]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 97BBF2966B4; Mon, 30 Mar 2020 18:42:15 +0100 (BST) From: =?utf-8?q?Vivek_Das=C2=A0Mohapatra?= <vivek@collabora.com> To: vivek@etla.org, libc-alpha@sourceware.org Subject: [RFC][PATCH 0/6] binutils patches to add DT_FLAGS_1 / DF_1_UNIQUE Date: Mon, 30 Mar 2020 18:42:01 +0100 Message-Id: <cover.1585587351.git.vivek@collabora.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-17.7 required=5.0 tests=BAYES_00, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <http://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> X-List-Received-Date: Mon, 30 Mar 2020 17:42:18 -0000 |
Series |
binutils patches to add DT_FLAGS_1 / DF_1_UNIQUE
|
|
Message
Vivek Dasmohapatra
March 30, 2020, 5:42 p.m. UTC
This patch series is in support of the glibc RTLD_SHARED work discussed in https://sourceware.org/bugzilla/show_bug.cgi?id=22745. It adds a DT_FLAGS_1 value DF_1_UNIQUE which is intended to mark libraries which should implicitly be opened as if RTLD_SHARED had been passed to dlmopen when the target namespace is not LM_ID_BASE. This patch series adds support for DF_1_UNIQUE to ld, gold, and readelf (and documents it in the help text and so forth). Vivek Das Mohapatra (6): Define a new DT_FLAGS_1 flag DF_1_UNIQUE for ld, readelf et al Handle DF_1_UNIQUE in ld Document DF_1_UNIQUE in the man page and ld help output Handle DF_1_UNIQUE in readelf Define DT_FLAGS_1 flag DF_1_UNIQUE for gold Implement and document DF_1_UNIQUE handling in gold binutils/readelf.c | 5 +++++ elfcpp/elfcpp.h | 4 +++- gold/layout.cc | 2 ++ gold/options.h | 3 +++ include/elf/common.h | 1 + ld/emultempl/elf.em | 2 ++ ld/ld.texi | 7 +++++++ ld/lexsup.c | 2 ++ 8 files changed, 25 insertions(+), 1 deletion(-)
Comments
* Vivek Das Mohapatra via Libc-alpha: > This patch series is in support of the glibc RTLD_SHARED work > discussed in https://sourceware.org/bugzilla/show_bug.cgi?id=22745. > > It adds a DT_FLAGS_1 value DF_1_UNIQUE which is intended to mark > libraries which should implicitly be opened as if RTLD_SHARED > had been passed to dlmopen when the target namespace is not > LM_ID_BASE. > > This patch series adds support for DF_1_UNIQUE to ld, gold, and > readelf (and documents it in the help text and so forth). I think you should repost this series to the binutils list. It would perhaps be less controversial to add a new dynamic tag in the GNU range for this, rather than a global flag value (in the space shared with other operating systems).
> It would perhaps be less controversial to add a new dynamic tag in the > GNU range for this, rather than a global flag value (in the space > shared with other operating systems). Ok, I'll do that. Thanks. Other than that, do you see any problems with the implementation or documentation?
On Tue, 31 Mar 2020, Vivek Das Mohapatra via Libc-alpha wrote: >> It would perhaps be less controversial to add a new dynamic tag in the >> GNU range for this, rather than a global flag value (in the space >> shared with other operating systems). > > Ok, I'll do that. Thanks. Other than that, do you see any problems with > the implementation or documentation? Finally got back round to this bit - could you tell me what the GNU range is exactly? Did you mean put it in DT_FLAGS instead? or inbetween DT_LOOS and DT_HIOS? Or something else?
* Vivek Das Mohapatra via Libc-alpha: > On Tue, 31 Mar 2020, Vivek Das Mohapatra via Libc-alpha wrote: > >>> It would perhaps be less controversial to add a new dynamic tag in the >>> GNU range for this, rather than a global flag value (in the space >>> shared with other operating systems). >> >> Ok, I'll do that. Thanks. Other than that, do you see any problems with >> the implementation or documentation? > > Finally got back round to this bit - could you tell me what the GNU range > is exactly? Did you mean put it in DT_FLAGS instead? or inbetween DT_LOOS > and DT_HIOS? Or something else? Yes, I expect a constant value somewhere around DT_GNU_PRELINKED or DT_GNU_HASH, depending on exact semantics. Thanks, Florian