mbox series

[v3,0/5] iconv: module for IMAP-UTF-7

Message ID 20210125090226.39967-1-mg@max.gautier.name
Headers
Series iconv: module for IMAP-UTF-7 |

Message

Max Gautier Jan. 25, 2021, 9:02 a.m. UTC 
  Here are the updated patchs , using the name IMAP-UTF-7

Comments

Florian Weimer Feb. 7, 2021, 9:49 a.m. UTC | #1 
* Max Gautier via Libc-alpha:

> ---
>  iconvdata/TESTS                     |  1 +
>  iconvdata/testdata/IMAP-UTF-7       | 25 +++++++++++++++++++++++++
>  iconvdata/testdata/IMAP-UTF-7..UTF8 | 25 +++++++++++++++++++++++++
>  3 files changed, 51 insertions(+)
>  create mode 100644 iconvdata/testdata/IMAP-UTF-7
>  create mode 100644 iconvdata/testdata/IMAP-UTF-7..UTF8

The charset name should be UTF-7-IMAP.

I'd recommend to add coverage for the mandatory-to-encode ASCII
characters (“/” etc.).

You could also add a test that checks for the presence of the -
terminator.

Thanks,
Florian
Adhemerval Zanella March 21, 2022, 12:28 p.m. UTC | #2 
On 25/01/2021 06:02, Max Gautier via Libc-alpha wrote:
> Here are the updated patchs , using the name IMAP-UTF-7 
> 

Hi Max,

I have fixed the 'enum variant' issue on patch 2 [1] and if you
are ok I can install this patchset.  Or you can resend it so I 
can apply it directly from the maillist.

[1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/imap-utf7
Max Gautier March 21, 2022, 2:09 p.m. UTC | #3 
On Mon, Mar 21, 2022 at 09:28:26AM -0300, Adhemerval Zanella wrote:
> 
> 
> On 25/01/2021 06:02, Max Gautier via Libc-alpha wrote:
> > Here are the updated patchs , using the name IMAP-UTF-7 
> > 
> 
> Hi Max,
> 
> I have fixed the 'enum variant' issue on patch 2 [1] and if you
> are ok I can install this patchset.  Or you can resend it so I 
> can apply it directly from the maillist.
> 
> [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/imap-utf7

I'm totally ok with it, thanks; and sorry for the mistake on my side.