From patchwork Tue Apr 1 17:19:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 375 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id D8B4B3600CD for ; Tue, 1 Apr 2014 10:19:22 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 8214C622AF652; Tue, 1 Apr 2014 10:19:22 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 596CE622C7EAA for ; Tue, 1 Apr 2014 10:19:22 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=LOunPg4VJZ4Q1iEdeT9rsQ1jtR6X2 8AAtSgENrk268o0lfw2UWQbdZG2KbBozioGL9b9m33R+TWoPiyAciVCkh2PzXn3g MgkmDl7+xfuSsdadHDoOzYsNTicggaNhjy/g1kVk6+v3uLAwBVzm7ycfhFkAmCv2 qUmK0CEfDQRkQs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=YHvibGDYZiTklekBwfgr86jq9k8=; b=P8D bmB7q2G77yaTV73Ptis9jke6XbBMM7Owp5+0yH/uuKCRuQcs3Fln4sggB6IC2k1N y8lJoxq9zogdmcMBFFKGDnEC/mlb2jppSQh0vqIzA0RUESJNwIGD4+Pm3pYZ+36T 7m/PTs/DSmCMm3uehTNGHgYJWhlsuYvExXtsR5Ug= Received: (qmail 25043 invoked by alias); 1 Apr 2014 17:19:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25033 invoked by uid 89); 1 Apr 2014 17:19:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f201.google.com Received: from mail-qc0-f201.google.com (HELO mail-qc0-f201.google.com) (209.85.216.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 01 Apr 2014 17:19:18 +0000 Received: by mail-qc0-f201.google.com with SMTP id c9so1378211qcz.4 for ; Tue, 01 Apr 2014 10:19:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=R1cGPCguNDY2+P3DVzPHXmZkPbKqo8c8ATDAOVWd8r4=; b=PStEucmgvvK1EZY9DDREBY0XLhMTnkI0DNs6Rcej3zoK6FmX3kzKcDdnOXkMeLn6z9 d3TawQ+kjRoUUtncgBhfURY+XcGNpikXqIqDjdLxt4SOGZvIHSIF8oPgO82p0BEqC6Jw 9jYCauQkTP3lH7TR82/w7h/KwQlDc0jwrdbcan/OAbiOBJyWEcgzvmRUUpCgZkUd+rFc UOrnWGvziGBgbjrXdZWeT+BSUJDiFeDxgNorP2vbjWdL2Lnd+L4OL5bsVOgBX6KEwEQ2 oKl7MWdtzQcXqMqOdwj4ZLw6UCrtJRtqc/whdEXyek92UvVgJOEr/KvMqHfbXBG675uX eh2A== X-Gm-Message-State: ALoCoQmlDjUk34+7ZqpPRro6tT/0Jl5VWHgvHlRUG8QVej3cDwg35rkMQsWxeL6F7kUgl7Xc6eoNiJr4muyXFNageyMkZjQ22QoZrksbBoN1OQ4Ul27WtYJkTASA54Lz2d07iFjckSTdDG+xAhbytsLC1TIvxnt4Km4bFOQLRuAPKhRNA1SiaI5Fx29wpL6mOSwbXqD8kgaBSuDDrxlnh28ISxiGfje9xScpIRwGmIprDUMDV8Z7vYM= X-Received: by 10.236.83.112 with SMTP id p76mr11313790yhe.51.1396372756065; Tue, 01 Apr 2014 10:19:16 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id g21si3430901yhe.3.2014.04.01.10.19.16 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Apr 2014 10:19:16 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id A1A825A420F for ; Tue, 1 Apr 2014 10:19:15 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [commit] dwarf2read.c (read_cutu_die_from_dwo): Improve comment. Date: Tue, 01 Apr 2014 10:19:14 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Hi. While hacking on the Fission support I noticed this comment left out DW_AT_comp_dir, so I added it. Committed. 2014-04-01 Doug Evans * dwarf2read.c (read_cutu_die_from_dwo): Improve comment. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 0c8d99f..3e77cf8 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -4982,9 +4982,11 @@ read_cutu_die_from_dwo (struct dwarf2_per_cu_data *this_cu, /* These attributes aren't processed until later: DW_AT_stmt_list, DW_AT_low_pc, DW_AT_high_pc, DW_AT_ranges. - However, the attribute is found in the stub which we won't have later. - In order to not impose this complication on the rest of the code, - we read them here and copy them to the DWO CU/TU die. */ + DW_AT_comp_dir is used now, to find the DWO file, but it is also + referenced later. However, these attributes are found in the stub + which we won't have later. In order to not impose this complication + on the rest of the code, we read them here and copy them to the + DWO CU/TU die. */ stmt_list = NULL; low_pc = NULL;