From patchwork Tue Dec 9 02:30:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 4117 Received: (qmail 18677 invoked by alias); 9 Dec 2014 02:30:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18663 invoked by uid 89); 9 Dec 2014 02:30:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-yh0-f73.google.com Received: from mail-yh0-f73.google.com (HELO mail-yh0-f73.google.com) (209.85.213.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 09 Dec 2014 02:30:41 +0000 Received: by mail-yh0-f73.google.com with SMTP id f10so335617yha.2 for ; Mon, 08 Dec 2014 18:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=0JN+yhM9wtir8Xuja7TvKxzG+IMTyNuYUkTve5mkdX4=; b=S4SFCP2Gu64HEWLg88YBKdP4OY/aWOauxVAW/5A2SIv7nAmvXxVzREqXXcQfkicI9j 0w14W9RBmkNvOEPJRVV7+EyFGbdVtHlwLKRu+cIegbBcVwZeZGJokTo3SWcrF2l4AQOp x9w9VHZUUX9HWv0BeO+mqeGX/m8nncEQs+v6MvITr8EGb/eKc9SvvxbOdPZbRExrmzEN BSOODd+gG05wO2dfAlv3LtgCtcy0pp39LDiIgnRG6kV1qEJnQMAwxDbbsxwcS5lLDjkz nA7eQ/vevAA0vpySxcf/stOpPMnxLdUZmOQ8LvaIoSBlihGJw/UF1OZahXh01LPB2JD6 apwA== X-Gm-Message-State: ALoCoQkWZqI0KFG6+C+M/71oI9ihGXJGVPtKdKlIFZUw8ajkHowY1UMKe39i7cBTZCuv6WNQ0EAFE6PdnoTYwQKkRjeDt251Q996jp/QG4nN8/k3zO94tlIgaO4qxqppaJn9FFxjec7VjUj932/gx/L5m4ESeHZEZ2JfnLtILLLgkf6lDwdrHqw= X-Received: by 10.236.42.137 with SMTP id j9mr31167395yhb.35.1418092239160; Mon, 08 Dec 2014 18:30:39 -0800 (PST) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id t28si1718839yhb.4.2014.12.08.18.30.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Dec 2014 18:30:39 -0800 (PST) Received: from ruffy.mtv.corp.google.com ([172.17.128.44]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTPS id VbcHl61k.1; Mon, 08 Dec 2014 18:30:39 -0800 From: Doug Evans To: gdb-patches@sourceware.org Subject: [COMMITTED PATCH] (objfpy_get_owner): Increment refcount of result. Date: Mon, 08 Dec 2014 18:30:38 -0800 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi. I noticed this while debugging another objfile refcount problem (in a new patch I'm working on). 2014-12-08 Doug Evans * python/py-objfile.c (objfpy_get_owner): Increment refcount of result. diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c index 51cf47c..e78ceba 100644 --- a/gdb/python/py-objfile.c +++ b/gdb/python/py-objfile.c @@ -93,9 +94,13 @@ objfpy_get_owner (PyObject *self, void *closure) OBJFPY_REQUIRE_VALID (obj); owner = objfile->separate_debug_objfile_backlink; - if (owner != NULL) - return objfile_to_objfile_object (owner); + { + PyObject *result = objfile_to_objfile_object (owner); + + Py_XINCREF (result); + return result; + } Py_RETURN_NONE; }