From patchwork Wed Nov 26 04:14:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 3927 Received: (qmail 22341 invoked by alias); 26 Nov 2014 04:14:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22319 invoked by uid 89); 26 Nov 2014 04:14:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ie0-f201.google.com Received: from mail-ie0-f201.google.com (HELO mail-ie0-f201.google.com) (209.85.223.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 26 Nov 2014 04:14:13 +0000 Received: by mail-ie0-f201.google.com with SMTP id rp18so246850iec.4 for ; Tue, 25 Nov 2014 20:14:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=p3QjpEex1W/QWOUp948BYiOV/reT5uXBxz7auiI5cwQ=; b=mEACJDJsmsym+IEVgHUf8BMy19+l5I1kWlKOxkAq/9rDyXXrWE2v2IqTpf8kUrFStG zaqIiqCKvY1EnS4ytUS1W0URl87Olu7ntv+7Gnj7OEHmNSJJqbXTFGOKFZcZust6fkDy iMQ+JmiFGEpgBUPill2UYE8oTo2aF6UIF3jEnjFeSwtniD6g4zAUH7ejWS25uMvD7huu GCQMPeyrQDNn6o1/JP7PiS0JSvfq7BY0PoGyoNeTqEAwYmoR4Xb5gfhmiahbjhj+sYqL PwRtbTk3w5/E2lctT2G2xrmnru6p8GCfkklSqiEy6p6p9+/qWn/F0tVbZ6k6LllwXgVR d49Q== X-Gm-Message-State: ALoCoQnYgJk9Pj+sgsGbqgDqzpZfL3cKXm/yX9nSMXEvLjpUtmZJgGhTk7S9/UyUoHfkdYtflx66/tfGYOxPsmJ96xO70/ma4hROsEEzweKvId4jKBMEj3l3DyRjbVVd/ILzIhPWCvdLETwqvso5hm1tc/25gnA77qMkq/7ovqpr9msgr/BQedM= X-Received: by 10.182.121.170 with SMTP id ll10mr29356996obb.12.1416975251546; Tue, 25 Nov 2014 20:14:11 -0800 (PST) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id 5si127547yhd.6.2014.11.25.20.14.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Nov 2014 20:14:11 -0800 (PST) Received: from ruffy.mtv.corp.google.com ([172.17.128.44]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTPS id 17pLy3UL.1; Tue, 25 Nov 2014 20:14:11 -0800 From: Doug Evans To: gdb-patches@sourceware.org Subject: [PATCH 1/2] [PR symtab/17602] Split up gdb.cp/anon-ns.cc Date: Tue, 25 Nov 2014 20:14:10 -0800 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi. A lot of our tests live in just one source file which is bad because gdb expands the symbol table with main() at startup. Thus such tests exercise less than they could. This patch splits up the gdb.cp/anon-ns test, it was useful in diagnosing pr 17602. 2014-11-25 Doug Evans PR symtab/17602 * gdb.cp/anon-ns.cc: Move guts of this file to ... * gdb.cp/anon-ns-2.cc: ... here. New file. * gdb.cp/anon-ns.exp: Update. diff --git a/gdb/testsuite/gdb.cp/anon-ns.cc b/gdb/testsuite/gdb.cp/anon-ns.cc index 26bc307..31b05c9 100644 --- a/gdb/testsuite/gdb.cp/anon-ns.cc +++ b/gdb/testsuite/gdb.cp/anon-ns.cc @@ -17,76 +17,11 @@ Contributed by Red Hat, originally written by Keith Seitz. */ -#include - -namespace -{ - void doit1 (void) { } // doit1(void) - void doit1 (int a) { } // doit1(int) - void doit1 (char *a) { } // doit1(char *) - - class one - { - public: - one (void) { } // one::one(void) - one (int a) { } // one::one(int) - one (char *a) { } // one::one(char *) - static void doit (void) { } // one::doit(void) - }; - - namespace A - { - void doit2 (void) { } // A::doit2(void) - void doit2 (int a) { } // A::doit2(int) - void doit2 (char *a) { } // A::doit2(char *) - - class two - { - public: - two (void) { } // A::two::two(void) - two (int a) { } // A::two::two(int) - two (char *a) { } // A::two::two(char *) - static void doit (void) { } // A::two::doit(void) - }; - - namespace - { - namespace - { - void doit3 (void) { } // A::doit3(void) - void doit3 (int a) { } // A::doit3(int) - void doit3 (char *a) { } // A::doit3(char *) - - class three - { - public: - three (void) { } // A::three::three(void) - three (int a) { } // A::three::three(int) - three (char *a) { } // A::three::three(char *) - static void doit (void) { } // A::three::doit(void) - }; - } - } - } -} +extern void doit (void); int main (void) { - one a, b (3), c (static_cast (NULL)); - one::doit (); - A::two d, e (3), f (static_cast (NULL)); - A::two::doit (); - A::three g, h (3), i (static_cast (NULL)); - A::three::doit (); - doit1 (); - doit1 (3); - doit1 (static_cast (NULL)); - A::doit2 (); - A::doit2 (3); - A::doit2 (static_cast (NULL)); - A::doit3 (); - A::doit3 (3); - A::doit3 (static_cast (NULL)); + doit (); return 0; } diff --git a/gdb/testsuite/gdb.cp/anon-ns.exp b/gdb/testsuite/gdb.cp/anon-ns.exp index 0cbb71b..f8d4970 100644 --- a/gdb/testsuite/gdb.cp/anon-ns.exp +++ b/gdb/testsuite/gdb.cp/anon-ns.exp @@ -19,9 +19,9 @@ if {[skip_cplus_tests]} { continue } -standard_testfile .cc +standard_testfile .cc anon-ns2.cc -if {[prepare_for_testing $testfile $testfile $srcfile {c++ debug}]} { +if {[prepare_for_testing $testfile $testfile "$srcfile $srcfile2" {c++ debug}]} { return -1 } diff --git a/gdb/testsuite/gdb.cp/anon-ns2.cc b/gdb/testsuite/gdb.cp/anon-ns2.cc new file mode 100644 index 0000000..0d29d9f --- /dev/null +++ b/gdb/testsuite/gdb.cp/anon-ns2.cc @@ -0,0 +1,91 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2011-2014 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . + + Contributed by Red Hat, originally written by Keith Seitz. */ + +#include + +namespace +{ + void doit1 (void) { } // doit1(void) + void doit1 (int a) { } // doit1(int) + void doit1 (char *a) { } // doit1(char *) + + class one + { + public: + one (void) { } // one::one(void) + one (int a) { } // one::one(int) + one (char *a) { } // one::one(char *) + static void doit (void) { } // one::doit(void) + }; + + namespace A + { + void doit2 (void) { } // A::doit2(void) + void doit2 (int a) { } // A::doit2(int) + void doit2 (char *a) { } // A::doit2(char *) + + class two + { + public: + two (void) { } // A::two::two(void) + two (int a) { } // A::two::two(int) + two (char *a) { } // A::two::two(char *) + static void doit (void) { } // A::two::doit(void) + }; + + namespace + { + namespace + { + void doit3 (void) { } // A::doit3(void) + void doit3 (int a) { } // A::doit3(int) + void doit3 (char *a) { } // A::doit3(char *) + + class three + { + public: + three (void) { } // A::three::three(void) + three (int a) { } // A::three::three(int) + three (char *a) { } // A::three::three(char *) + static void doit (void) { } // A::three::doit(void) + }; + } + } + } +} + +void +doit (void) +{ + one a, b (3), c (static_cast (NULL)); + one::doit (); + A::two d, e (3), f (static_cast (NULL)); + A::two::doit (); + A::three g, h (3), i (static_cast (NULL)); + A::three::doit (); + doit1 (); + doit1 (3); + doit1 (static_cast (NULL)); + A::doit2 (); + A::doit2 (3); + A::doit2 (static_cast (NULL)); + A::doit3 (); + A::doit3 (3); + A::doit3 (static_cast (NULL)); +}