From patchwork Thu May 15 22:57:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 954 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A11133600C0 for ; Thu, 15 May 2014 15:57:22 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 54E6F63A3E068; Thu, 15 May 2014 15:57:22 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 902906399AE79 for ; Thu, 15 May 2014 15:57:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=m9iMFZWj0Sl+w7q8xy0iE01a296BR TJuA7IQFuZG05K5jv+4jcckD4IWZLGbrwpDEUVrQOul3ce6Iig6oGfCsmS//w25i gr8vSZiTYgqjnFGFY3iRTgoLyLT4K6Y1PpGrKvRdH+gnwDFGoc4cXqySUU8OmqsQ AVvvoIoszW3Lzc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=l1Osk+9NNxtx7bKAEJLdErAz1Ds=; b=Adn ipuT4LvREWu07WpMwUBhUVSRRjWEAkYqkVFjrP7FsnJJojktC0+1rNY6Z3D7/3bs gTcc/Mjr4HYgVLp4jMY2o2Ra7ovPYiK2MWUqMegQoj5/IxjvfeKbdQRuJlS09u2z XDefSvEWLtjtpLgjrY4qpBd4V676oz48ag1+88Lg= Received: (qmail 10613 invoked by alias); 15 May 2014 22:57:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 10603 invoked by uid 89); 15 May 2014 22:57:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f74.google.com Received: from mail-pb0-f74.google.com (HELO mail-pb0-f74.google.com) (209.85.160.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 15 May 2014 22:57:17 +0000 Received: by mail-pb0-f74.google.com with SMTP id rr13so343960pbb.3 for ; Thu, 15 May 2014 15:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=4JgVsKtx2tV0hoYTXzTe0EtSr3Xqn3AYVaMmuFbApi0=; b=bvHLLs9/wNxmNmnBTQDv8nbw4/gRJjeINzgtmw4QW8VfZTRV5j7Q+mvhAasCXQR6js ZoIN/PZWfaYYnrh9jGBrMi57bhrDmzcKVeKZYc7S81wPtibAsvOHLnqi4oNZKB4RqYsd 1JFvIKPizwcdppPrIf/agMafeAxBAI/Nj12Qo1WYErxnlUQ6KdrLQKums6CAKODck2Vq BumfGktKfoUp9zQByT8mxneXiO4rjh7ELiaWrnE0EBZu3hkIASL2T/7k1Yqkm+aEaHt8 4Je3mTjUAlpvGc+CaFxD8oJzRA6WKIKPxlUQK6ZNP9gMihl56ATB9EwYEGdYbNbYYEQP neRA== X-Gm-Message-State: ALoCoQkSQRZivmsCaqE/FfwLvoBjP2AYod9MpCKVi84NA7AdmRddupH5Z9L3txderSyUPpgzTDXoGLq2v6UIPLctTKWuHXfWoK6EISTZS+2mra35XEx4Mf4vkgIwCrjuLZNOE0+X+Tyc X-Received: by 10.66.232.38 with SMTP id tl6mr4121608pac.33.1400194635774; Thu, 15 May 2014 15:57:15 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id k43si316676yhq.3.2014.05.15.15.57.15 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 May 2014 15:57:15 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 6123A31C1ED for ; Thu, 15 May 2014 15:57:15 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [commit] Make fission-reread.exp work in parallel mode. Date: Thu, 15 May 2014 15:57:14 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Hi. This test was passing in parallel mode, but mostly accidentally. gdb wasn't finding the DWO file. This patch changes fission-reread.exp to do what the other assembler-based fission tests do, which is to set debug-file-directory before loading the file. Regression tested on amd64-linux (with/without testsuite parallel mode), and committed. 2014-05-15 Doug Evans * gdb.dwarf2/fission-reread.S: Remove directory from .dwo file path. * gdb.dwarf2/fission-reread.exp: Set debug-file-directory before loading file. Add test for TU lookup. diff --git a/gdb/testsuite/gdb.dwarf2/fission-reread.S b/gdb/testsuite/gdb.dwarf2/fission-reread.S index 6d013c3..3e006bc 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-reread.S +++ b/gdb/testsuite/gdb.dwarf2/fission-reread.S @@ -134,7 +134,7 @@ main: .4byte 0 /* Offset to Type DIE */ .uleb128 0x2 /* (DIE (0) DW_TAG_type_unit) */ .ascii "/tmp/src/gdb/testsuite\0" /* DW_AT_comp_dir */ - .ascii "gdb.dwarf2/fission-reread.dwo\0" /* DW_AT_GNU_dwo_name */ + .ascii "fission-reread.dwo\0" /* DW_AT_GNU_dwo_name */ .4byte .Ldebug_pubnames0 /* DW_AT_GNU_pubnames */ .4byte .Ldebug_pubtypes0 /* DW_AT_GNU_pubtypes */ .4byte .Ldebug_addr0 /* DW_AT_GNU_addr_base */ @@ -205,7 +205,7 @@ main: .4byte .Letext0-.Ltext0 /* DW_AT_high_pc */ .4byte .Ldebug_line0 /* DW_AT_stmt_list */ .ascii "/tmp/src/gdb/testsuite\0" /* DW_AT_comp_dir */ - .ascii "gdb.dwarf2/fission-reread.dwo\0" /* DW_AT_GNU_dwo_name */ + .ascii "fission-reread.dwo\0" /* DW_AT_GNU_dwo_name */ .4byte .Ldebug_pubnames0 /* DW_AT_GNU_pubnames */ .4byte .Ldebug_pubtypes0 /* DW_AT_GNU_pubtypes */ .4byte .Ldebug_addr0 /* DW_AT_GNU_addr_base */ diff --git a/gdb/testsuite/gdb.dwarf2/fission-reread.exp b/gdb/testsuite/gdb.dwarf2/fission-reread.exp index e7c3d9d..7eb792b 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-reread.exp +++ b/gdb/testsuite/gdb.dwarf2/fission-reread.exp @@ -32,10 +32,19 @@ if [build_executable_from_fission_assembler \ return -1 } -clean_restart ${binfile} +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +# Make sure we can find the .dwo file, regardless of whether we're +# running in parallel mode. +gdb_test_no_output "set debug-file-directory [file dirname $binfile]" \ + "set debug-file-directory" +gdb_load $binfile gdb_test "break main" "Breakpoint.*at.*" +gdb_test "ptype baz" "type = class foo {.*" + # If we get this far gdb didn't crash, nor did an error occur. pass $testfile