From patchwork Fri May 16 19:49:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 981 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A5ACE36007A for ; Fri, 16 May 2014 12:49:12 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14314964) id 5BE61419EC183; Fri, 16 May 2014 12:49:12 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 32B8E4186D679 for ; Fri, 16 May 2014 12:49:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=GsFsZdllc1Wa1tQC8CFqC4Qpx0cH4 QwUF1eVR6JA/s5vnmWmSEROLr0bu4Df3X6nIijaYsztkBosZkdjR6L4AxtJngelE +CcMtgpSPE0+6fB3dnOzIYJDngJ+tDANROTtUXa6MWkcKFGGIzqnAsSEkp/oykby STFebZYhQakA1s= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=lvSMcC9jjalDvt95tZRg3PWbvF8=; b=Rh0 P5DEUyy1BzSHkI93u7qXpmwSC4jmZh6D7VXs07GAH12MND8HM04uFBbARiHDKCcE /K20jm8mPkQND2t7jRZrN+GSOi3dPUFDWgS2TXD6bqpwhyFcalJG8oo3TbZXf9vj yxDp0RtAIJ/bXgBMEd9A1rDxqhnTcObbzeOLD6U8= Received: (qmail 26340 invoked by alias); 16 May 2014 19:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26322 invoked by uid 89); 16 May 2014 19:49:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f202.google.com Received: from mail-ob0-f202.google.com (HELO mail-ob0-f202.google.com) (209.85.214.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 16 May 2014 19:49:08 +0000 Received: by mail-ob0-f202.google.com with SMTP id wm4so621043obc.1 for ; Fri, 16 May 2014 12:49:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=/zKqkLlM98pmFoKMo3flISIqXZdOt4b0iz0oBBvP0qc=; b=kBaQ4nBpkDAwNjVReBGh1zltrMoX5odg5rRtBXUDeQKTe3AqQ65zLhFMrZ4eX2OBSd LpNE1xQOiBez/4SqEuswfV3OuRHUYCnEQClU5QlqmZIeRbrHY70+T7zinvnDMFYqys/g I045VL9dNn7UA24/lrTkyScjrD6rhqsaoMzDxeLrnkyBNiNBiZd/6yqHBEo4r9epIDW3 nkZofV4BrGJRBtAkUz6Udwhha+F+0RAa51aa2+qEA09TYy/zxM9nyzH5lQ8/AkaVpK7N GtM78edlpVTtQ01xYtsMohXb2RpG8ug3FhXB/ET0eslCoUnyq3SZgeUXNhYWU9499enE Ev1Q== X-Gm-Message-State: ALoCoQmeO24QIiSWvQYklTNAQFUPd14d6KdlG0RdSCULEKxy9ycacJlSfYjYPOjbNc4ihrLSxcCjeW3TTZ7BMKRCrrYybgcxU/YK+HpKdqw7R9bkBKU8R1lpc6RNgcCq/YUNt5sBdIYn X-Received: by 10.182.19.231 with SMTP id i7mr9318864obe.25.1400269746605; Fri, 16 May 2014 12:49:06 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id r79si460026yhj.2.2014.05.16.12.49.06 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 May 2014 12:49:06 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 3EA595A40F6 for ; Fri, 16 May 2014 12:49:06 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [commit] gdb.base/Makefile.in (EXECUTABLES): Add completion. Date: Fri, 16 May 2014 12:49:05 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Hi. I was seeing the following failures. FAIL: gdb.base/completion.exp: complete target core ./gdb.base/completion FAIL: gdb.base/completion.exp: complete target tfile ./gdb.base/completion FAIL: gdb.base/completion.exp: complete target exec ./gdb.base/completion A bit of head scratching and digging later, I found them due to this bit of code in completion.exp: foreach dir1 [ list "./gdb.base" "./outputs/gdb.base/completion" ] { if [remote_file host exists ${dir1}/completion] { foreach target_name ${targets} { gdb_test "complete target ${target_name} ${dir1}/completion" \ "target ${target_name} ${dir1}/completion.*${dir1}/completion0\\.o.*${dir1}/completion1\\.o.*" } break } } If you test completion.exp first in serial mode, do a make clean in the testsuite directory, and then run the test in parallel mode, that will trigger these failures. Either of these changes will fix the problem. Applying both for completeness sake (heh). Regression tested on amd64-linux and committed. 2014-05-16 Doug Evans * gdb.base/Makefile.in (EXECUTABLES): Add completion. * gdb.base/completion.exp: Check that all expected files exist before doing file completion. diff --git a/gdb/testsuite/gdb.base/Makefile.in b/gdb/testsuite/gdb.base/Makefile.in index 828ec26..dda3169 100644 --- a/gdb/testsuite/gdb.base/Makefile.in +++ b/gdb/testsuite/gdb.base/Makefile.in @@ -8,7 +8,7 @@ EXECUTABLES = a2-run advance all-types annota1 annota1-watch_thread_num \ breakpoint-shadow break-on-linker-gcd-function \ call-ar-st call-rt-st call-sc-t* call-signals \ call-strs callexit callfuncs callfwmall charset checkpoint \ - chng-syms code_elim1 code_elim2 commands compiler complex \ + chng-syms code_elim1 code_elim2 commands compiler completion complex \ condbreak consecutive constvars coremaker cursal cvexpr \ dbx-test del disasm-end-cu display dprintf-pending dump dup-sect \ dup-sect.debug \ diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp index 1e152f6..2608309 100644 --- a/gdb/testsuite/gdb.base/completion.exp +++ b/gdb/testsuite/gdb.base/completion.exp @@ -110,7 +110,9 @@ gdb_test_multiple "target ctf" "" { # do the test on file completion. foreach dir1 [ list "./gdb.base" "./outputs/gdb.base/completion" ] { - if [remote_file host exists ${dir1}/completion] { + if { [remote_file host exists ${dir1}/completion] + && [remote_file host exists ${dir1}/completion0.o] + && [remote_file host exists ${dir1}/completion1.o] } { foreach target_name ${targets} { gdb_test "complete target ${target_name} ${dir1}/completion" \ "target ${target_name} ${dir1}/completion.*${dir1}/completion0\\.o.*${dir1}/completion1\\.o.*"