From patchwork Tue Jul 29 21:32:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 2225 Received: (qmail 22210 invoked by alias); 29 Jul 2014 21:32:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22196 invoked by uid 89); 29 Jul 2014 21:32:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f74.google.com Received: from mail-qg0-f74.google.com (HELO mail-qg0-f74.google.com) (209.85.192.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 29 Jul 2014 21:32:52 +0000 Received: by mail-qg0-f74.google.com with SMTP id z60so14631qgd.5 for ; Tue, 29 Jul 2014 14:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=OA8D8kh8DWgHOQsTS9I67JlwD8RkkoM49iJRyOplFxM=; b=Vpt2kXaowZ2IJDI9xIcnhJOu6N1skFPBleWQ+6s79K3t6nh1NWWSFhdd8e859P5HY/ Jked0klFOq7PIkbhyZrMRKQ617uCjEOgUsJZQUBlkqfwDBGeXK6MdVbBoOb3hWYlWGzm 0aNCCnIQsqTT7Exd0wecO1CcaiyvC80z5BweRZ/AKSrNb4njX3Wuxo9DrhmkyV6iJam6 6rNqFQkdKWFcjKw64ugYU67Fg5/zqe+CFvpW+Y1CDZIHR2XHtKV/nUMZncnzUz32Cz8n 9g2OspnVYC+vOvPPf6eZS1uGuJeXLsqdNUDXdIwS/CSbfJ0x5T7auYHp+4cnSvpduhG6 ILow== X-Gm-Message-State: ALoCoQkpQL2BM+72zwe0ZAcUOPICvBSDztsHDe0nYEt6xQq2QwziMAvKzKwoCfOXF7VKSyOj/IiTewmJ9X+3xCQK0ORZP8jiY1YgCboHk9Z0GKwqN39puAXNNYzKq7+HFUvFh8kL1XO2 X-Received: by 10.236.202.143 with SMTP id d15mr1708566yho.18.1406669570116; Tue, 29 Jul 2014 14:32:50 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id l23si12972yhg.1.2014.07.29.14.32.50 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Jul 2014 14:32:50 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id AF3115A425F for ; Tue, 29 Jul 2014 14:32:49 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [PATCH] infcmd.c (attach_command): Improve comment. Date: Tue, 29 Jul 2014 14:32:49 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi. I always have to re-lookup what target_attach_no_wait means, and what targets set it to non-zero, every time I look at this code. This patch is a modest attempt at clearing things up for me. [maybe a good example of why double negatives should be avoided, in this case "! no-wait". maybe not.] 2014-07-29 Doug Evans * infcmd.c (attach_command): Improve comment. diff --git a/gdb/infcmd.c b/gdb/infcmd.c index d84c591..1def6cd 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2578,7 +2578,7 @@ attach_command (char *args, int from_tty) } /* Some system don't generate traps when attaching to inferior. - E.g. Mach 3 or GNU hurd. */ + E.g. Mach 3 or GNU hurd. Skip waiting for these targets. */ if (!target_attach_no_wait) { struct inferior *inferior = current_inferior ();