From patchwork Tue Aug 7 11:23:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 28769 Received: (qmail 116410 invoked by alias); 7 Aug 2018 11:23:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 116392 invoked by uid 89); 7 Aug 2018 11:23:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=j X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Aug 2018 11:23:34 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 438AD1394; Tue, 7 Aug 2018 13:23:32 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IN1du2yzavad; Tue, 7 Aug 2018 13:23:30 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 3FEB31393; Tue, 7 Aug 2018 13:23:30 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w77BNTOB019595; Tue, 7 Aug 2018 13:23:29 +0200 (MEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Support parallel make check with GNU make 4.2+ References: <871sbr16e3.fsf@tromey.com> Date: Tue, 07 Aug 2018 13:23:29 +0200 In-Reply-To: <871sbr16e3.fsf@tromey.com> (Tom Tromey's message of "Wed, 25 Jul 2018 13:07:16 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Hi Tom, >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> The fix is trivial: just accept an optional arg to -j in Makefile.in > Rainer> (saw_dash_j). Tested on i386-pc-solaris2.11 with just make and make > Rainer> -j/-jN with both make 3.82 and 4.2.1. > > Rainer> Ok for master? > > Thanks for doing this, and nice work noticing it. > This is OK if you first fix the nit that Andreas pointed out. here's what I've checked in. Thanks. Rainer # HG changeset patch # Parent 4aa118a772bdc3c80b028bbb31ccbe3866b6199e Support parallel make check with GNU make 4.2+ diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -137,10 +137,11 @@ uninstall: force installcheck: -# See whether -j was given to make. Either it was given with no -# arguments, and appears as "j" in the first word, or it was given an -# argument and appears as "-j" in a separate word. -saw_dash_j = $(or $(findstring j,$(firstword $(MAKEFLAGS))),$(filter -j,$(MAKEFLAGS))) +# See whether -j was given to make. Before GNU make 4.2, either it was +# given with no arguments, and appears as "j" in the first word, or it was +# given an argument and appears as "-j" in a separate word. Starting with +# GNU make 4.2, it always appears as "-j"/"-jN" in a separate word. +saw_dash_j = $(or $(findstring j,$(firstword $(MAKEFLAGS))),$(filter -j%,$(MAKEFLAGS))) # Try to run the tests in parallel if any -j option is given. If RUNTESTFLAGS # is not empty, then by default the tests will be serialized. This can be