diff mbox

Fix compilation of dyn_arrayidx ada testcase

Message ID m3lhks9bts.fsf@sspiff.org
State New
Headers show

Commit Message

Doug Evans Jan. 24, 2015, 8:13 p.m. UTC
Hi.

I was looking into this testcase as boilerplate for another test
I want to write for a cleanup patch, and noticed it doesn't compile.

gcc -c -m64 -g -lm -I- -gnatA /hack/build/vptr-cleanup-1/vptr-cleanup-1/gdb/testsuite/gdb.ada/dyn_arrayidx/foo.adb
foo.adb:23:13: iterator is an Ada 2012 feature

2015-01-24  Doug Evans  <xdje42@gmail.com>

	* gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12.

Comments

Joel Brobecker Jan. 29, 2015, 7:42 a.m. UTC | #1
> 2015-01-24  Doug Evans  <xdje42@gmail.com>
> 
> 	* gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12.

Thanks for the fix, Doug. I didn't see this, because we changed our
compiler to build with -gnat12 by default. This is an Ada Front End
change, so I would assume that this made it to the FSF GCC by now;
just don't know which version.

Looking at the testcase, it would have been easy to adjust it to avoid
that Ada 2012 feature. But since your fix is really easy, might as well
keep it that way.

OK to push if you haven't already.

> diff --git a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
> index 25351db..06702b8 100644
> --- a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
> +++ b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
> @@ -19,7 +19,7 @@ if { [skip_ada_tests] } { return -1 }
>  
>  standard_ada_testfile foo
>  
> -if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} {
> +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug additional_flags=-gnat12}] != ""} {
>      return -1
>  }
>
Doug Evans Jan. 31, 2015, 10:28 p.m. UTC | #2
Joel Brobecker <brobecker@adacore.com> writes:
>> 2015-01-24  Doug Evans  <xdje42@gmail.com>
>> 
>> 	* gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12.
>
> Thanks for the fix, Doug. I didn't see this, because we changed our
> compiler to build with -gnat12 by default. This is an Ada Front End
> change, so I would assume that this made it to the FSF GCC by now;
> just don't know which version.
>
> Looking at the testcase, it would have been easy to adjust it to avoid
> that Ada 2012 feature. But since your fix is really easy, might as well
> keep it that way.
>
> OK to push if you haven't already.
>
>> diff --git a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> index 25351db..06702b8 100644
>> --- a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> +++ b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> @@ -19,7 +19,7 @@ if { [skip_ada_tests] } { return -1 }
>>  
>>  standard_ada_testfile foo
>>  
>> -if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} {
>> +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug additional_flags=-gnat12}] != ""} {
>>      return -1
>>  }
>>  

Committed.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
index 25351db..06702b8 100644
--- a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
+++ b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
@@ -19,7 +19,7 @@  if { [skip_ada_tests] } { return -1 }
 
 standard_ada_testfile foo
 
-if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} {
+if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug additional_flags=-gnat12}] != ""} {
     return -1
 }