diff mbox

single-step.exp (SINGLE_STEP_COUNT): Change to 1000 from 10000.

Message ID m3egjvym6b.fsf@sspiff.org
State New
Headers show

Commit Message

Doug Evans July 26, 2015, 3:26 p.m. UTC
Hi.

single-step.exp takes a while to run, and while that's not necessarily
bad, here it's because the default value of SINGLE_STEP_COUNT is 10,000.

We're not going to gain any more insight into perf issues
single-stepping (stepi) 10,000 times over 1,000 times,
so this patch changes the default to 1,000.

IWBN to rename "single-step" to something like "single-stepi"
or some such as the name is misleading, but that's left for
another patch.

2015-07-26  Doug Evans  <xdje42@gmail.com>

	* single-step.exp (SINGLE_STEP_COUNT): Change to 1000 from 10000.

Comments

Yao Qi July 27, 2015, 10:03 a.m. UTC | #1
Doug Evans <xdje42@gmail.com> writes:

> IWBN to rename "single-step" to something like "single-stepi"
> or some such as the name is misleading, but that's left for
> another patch.

That is fine.

>
> 2015-07-26  Doug Evans  <xdje42@gmail.com>
>
> 	* single-step.exp (SINGLE_STEP_COUNT): Change to 1000 from 10000.

Patch looks good to me.
Doug Evans Aug. 3, 2015, 4:34 p.m. UTC | #2
On Mon, Jul 27, 2015 at 3:03 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Doug Evans <xdje42@gmail.com> writes:
>
>> IWBN to rename "single-step" to something like "single-stepi"
>> or some such as the name is misleading, but that's left for
>> another patch.
>
> That is fine.
>
>>
>> 2015-07-26  Doug Evans  <xdje42@gmail.com>
>>
>>       * single-step.exp (SINGLE_STEP_COUNT): Change to 1000 from 10000.
>
> Patch looks good to me.

Thanks. Committed.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.perf/single-step.exp b/gdb/testsuite/gdb.perf/single-step.exp
index d5aa7e2..1b89145 100644
--- a/gdb/testsuite/gdb.perf/single-step.exp
+++ b/gdb/testsuite/gdb.perf/single-step.exp
@@ -29,7 +29,7 @@  set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='single-step.exp SINGLE_STEP_COUNT=300'
 if ![info exists SINGLE_STEP_COUNT] {
-    set SINGLE_STEP_COUNT 10000
+    set SINGLE_STEP_COUNT 1000
 }
 
 PerfTest::assemble {