From patchwork Thu Dec 5 15:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36543 Received: (qmail 130088 invoked by alias); 5 Dec 2019 15:51:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129877 invoked by uid 89); 5 Dec 2019 15:51:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 15:51:52 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id F031320959; Thu, 5 Dec 2019 10:45:03 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 7C60420484 for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 70DFD2816F for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 5 Dec 2019 10:44:59 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Avoid ARI warnings with #include X-Gerrit-Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9 X-Gerrit-Change-Number: 746 X-Gerrit-ChangeURL: X-Gerrit-Commit: f26577b5c12dc6a600abca1e0ba0239d62f1b211 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/746 ...................................................................... Avoid ARI warnings with #include ARI will complain about the use of certain include files, but in isolated spots, these includes are actually necessary. This patch marks these spots to silence ARI. gdb/ChangeLog 2019-12-05 Tom Tromey * gdb_regex.h: Add ARI comments. * gdb_vfork.h: Add ARI comment. Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9 --- M gdb/ChangeLog M gdb/gdb_regex.h M gdb/gdb_vfork.h 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fe81ff8..aa7e9ab 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-12-05 Tom Tromey + * gdb_regex.h: Add ARI comments. + * gdb_vfork.h: Add ARI comment. + +2019-12-05 Tom Tromey + * target-float.c (host_float_ops::from_target): Add ARI comment. diff --git a/gdb/gdb_regex.h b/gdb/gdb_regex.h index 58a0f22..5b81642 100644 --- a/gdb/gdb_regex.h +++ b/gdb/gdb_regex.h @@ -20,11 +20,11 @@ #define GDB_REGEX_H 1 #ifdef USE_INCLUDED_REGEX -# include "xregex.h" +# include "xregex.h" /* ARI: xregex.h */ #else /* Request 4.2 BSD regex functions. */ # define _REGEX_RE_COMP -# include +# include /* ARI: regex.h */ #endif /* A compiled regex. This is mainly a wrapper around regex_t. The diff --git a/gdb/gdb_vfork.h b/gdb/gdb_vfork.h index 8bf72d6..b76776b 100644 --- a/gdb/gdb_vfork.h +++ b/gdb/gdb_vfork.h @@ -20,7 +20,7 @@ #define GDB_VFORK_H #if HAVE_VFORK_H -#include +#include /* ARI: vfork.h */ #endif #endif /* GDB_VFORK_H */