From patchwork Thu Dec 5 15:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36534 Received: (qmail 64744 invoked by alias); 5 Dec 2019 15:45:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64704 invoked by uid 89); 5 Dec 2019 15:45:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=contrib X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 15:45:03 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 525CB20A7E; Thu, 5 Dec 2019 10:45:01 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 3E2C0203AC for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 211C728174 for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 5 Dec 2019 10:44:59 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Remove ATTRIBUTE_UNUSED check from ARI X-Gerrit-Change-Id: I13fd8e9b40dbaab3978dbf9b6c4228b62299d944 X-Gerrit-Change-Number: 742 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6839ec0a4b6e05b7fdb3087a71b78de73601759f References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/742 ...................................................................... Remove ATTRIBUTE_UNUSED check from ARI The text for the ATTRIBUTE_UNUSED check in ARI is plainly incorrect now -- gdb does in fact use ATTRIBUTE_UNUSED, and there's no issue in doing so, when done properly. This patch removes this check. gdb/ChangeLog 2019-12-05 Tom Tromey * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check. Change-Id: I13fd8e9b40dbaab3978dbf9b6c4228b62299d944 --- M gdb/ChangeLog M gdb/contrib/ari/gdb_ari.sh 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b865214..9d9ab85 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2019-12-05 Tom Tromey + * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check. + +2019-12-05 Tom Tromey + * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean" checks. diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index ee9f16a..b5a5433 100755 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -581,17 +581,6 @@ fail("long long") } -BEGIN { doc["ATTRIBUTE_UNUSED"] = "\ -Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, \ -consequently, is not able to tolerate false warnings. Since -Wunused-param \ -produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED \ -are used by GDB" - category["ATTRIBUTE_UNUSED"] = ari_regression -} -/(^|[^_[:alnum:]])ATTRIBUTE_UNUSED([^_[:alnum:]]|$)/ { - fail("ATTRIBUTE_UNUSED") -} - BEGIN { doc["ATTR_FORMAT"] = "\ Do not use ATTR_FORMAT, use ATTRIBUTE_PRINTF instead" category["ATTR_FORMAT"] = ari_regression