From patchwork Thu Dec 5 15:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36542 Received: (qmail 130006 invoked by alias); 5 Dec 2019 15:51:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129907 invoked by uid 89); 5 Dec 2019 15:51:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 15:51:52 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 5174D201E8; Thu, 5 Dec 2019 10:45:03 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 5E11D203C1 for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4CF322816F for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 5 Dec 2019 10:44:59 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Silence ARI for valid calls to abort X-Gerrit-Change-Id: I09ce6aa5010bbe4e5bb73ffdb727481be39d34d6 X-Gerrit-Change-Number: 744 X-Gerrit-ChangeURL: X-Gerrit-Commit: 424c4ec8259eb64c1249309bc96a68c6fac7cfeb References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/744 ...................................................................... Silence ARI for valid calls to abort There are a handful of spots in gdb that validly call abort. This patch adds the appropriate ARI marker to these lines, to silence the ARI report. gdb/ChangeLog 2019-12-05 Tom Tromey * utils.c (abort_with_message, dump_core, internal_vproblem): Add ARI marker to abort. * event-top.c (handle_sigsegv): Add ARI marker to abort. Change-Id: I09ce6aa5010bbe4e5bb73ffdb727481be39d34d6 --- M gdb/ChangeLog M gdb/event-top.c M gdb/utils.c 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e0ac58e..36f407f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2019-12-05 Tom Tromey + * utils.c (abort_with_message, dump_core, internal_vproblem): Add + ARI marker to abort. + * event-top.c (handle_sigsegv): Add ARI marker to abort. + +2019-12-05 Tom Tromey + * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text. 2019-12-05 Tom Tromey diff --git a/gdb/event-top.c b/gdb/event-top.c index 9ec599e..5feb292 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -881,7 +881,7 @@ install_handle_sigsegv (); if (thread_local_segv_handler == nullptr) - abort (); + abort (); /* ARI: abort */ thread_local_segv_handler (sig); } diff --git a/gdb/utils.c b/gdb/utils.c index f7fae35..08be146 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -186,7 +186,7 @@ else fputs_unfiltered (msg, gdb_stderr); - abort (); /* NOTE: GDB has only three calls to abort(). */ + abort (); /* ARI: abort */ } /* Dump core trying to increase the core soft limit to hard limit first. */ @@ -200,7 +200,7 @@ setrlimit (RLIMIT_CORE, &rlim); #endif /* HAVE_SETRLIMIT */ - abort (); /* NOTE: GDB has only three calls to abort(). */ + abort (); /* ARI: abort */ } /* Check whether GDB will be able to dump core using the dump_core @@ -320,7 +320,7 @@ does not fix this problem. This is the solution suggested at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509. */ if (write (STDERR_FILENO, msg, sizeof (msg)) != sizeof (msg)) - abort (); /* NOTE: GDB has only three calls to abort(). */ + abort (); /* ARI: abort */ exit (1); } }